Skip to contentSkip to conversation

fsl_pci_init enable COMMAND_MEMORY if inbound window

PATCH New Ed Swarthout 3 participants 3 messages Oct 19, 2007 – Oct 23, 2007

lore
Share & tools
lore

Ed Swarthout

author
#0 lore raw

PATCH 1/1 fsl_pci_init enable COMMAND_MEMORY if inbound window

Patch 16e23c3f removed PCSRBAR allocation. But passing zero windows to pciauto_setup_device has the side effect of not getting COMMAND_MEMORY set.

Signed-off-by Ed Swarthout <[email protected]>

---

This fixes the PCI ethernet card problem that use dma for the mpc8544ds and mpc8610hpcd boards.

 drivers/fsl_pci_init.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
drivers/fsl_pci_init.c +8 -0
index 6394234..e0c3bed 100644
@@ -54,6 +54,7 @@ fsl_pci_init(struct pci_controller *hose)
 	u8 temp8;
 	int r;
 	int bridge;
+	int inbound = 0;
 	volatile ccsr_fsl_pci_t *pci = (ccsr_fsl_pci_t *) hose->cfg_addr;
 	pci_dev_t dev = PCI_BDF(busno,0,0);
 

@@ -74,6 +75,7 @@ fsl_pci_init(struct pci_controller *hose)
 				PIWAR_READ_SNOOP | PIWAR_WRITE_SNOOP |
 				(__ilog2(hose->regions[r].size) - 1);
 			pi++;
+			inbound = hose->regions[r].size > 0;
 		} else { /* Outbound */
 			po->powbar = (hose->regions[r].phys_start >> 12) & 0x000fffff;
 			po->potar = (hose->regions[r].bus_start >> 12) & 0x000fffff;

@@ -138,6 +140,12 @@ fsl_pci_init(struct pci_controller *hose)
 	pciauto_setup_device(hose, dev, 0, hose->pci_mem,
 			     hose->pci_prefetch, hose->pci_io);
 
+	if (inbound) {
+		pci_hose_read_config_word(hose, dev, PCI_COMMAND, &temp16);
+		pci_hose_write_config_word(hose, dev, PCI_COMMAND,
+					   temp16 | PCI_COMMAND_MEMORY);
+	}
+
 #ifndef CONFIG_PCI_NOSCAN
 	printf ("               Scanning PCI bus %02x\n", hose->current_busno);
 	hose->last_busno = pci_hose_scan_bus(hose,hose->current_busno);
Signature · 1 line
1.5.3.4.225.gbee42
Applied
#2 lore raw

PATCH 1/1 fsl_pci_init enable COMMAND_MEMORY if inbound window

In reply to Ed Swarthout
Quoted 4 lines · In message <[email protected]> you…

Patch 16e23c3f removed PCSRBAR allocation. But passing zero windows to pciauto_setup_device has the side effect of not getting COMMAND_MEMORY set.

Quoted 9 lines
Signed-off-by Ed Swarthout <[email protected]>

---

This fixes the PCI ethernet card problem that use dma for the mpc8544ds and mpc8610hpcd boards.

 drivers/fsl_pci_init.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Stanford research group advertised for participants in a  study  of
obsessive-compulsive  disorder. They were looking for therapy clients
who had been diagnosed with this disorder. The  response  was  grati-
fying;  they  got  3,000 responses about three days after the ad came
out. All from the same person.