Skip to contentSkip to conversation

fix warning: no return statement in function returning non-void

PATCH New Jean-Christophe PLAGNIOL-VILLARD 2 participants 2 messages Oct 19, 2007 – Oct 23, 2007 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix warning: no return statement in function returning non-void

cpu/arm920t/at91rm9200/usb.c +4 -4
index 366262e..c121de6 100644
@@ -28,7 +28,7 @@
 
 #include <asm/arch/hardware.h>
 
-int usb_cpu_init()
+int usb_cpu_init(void)
 {
 	/* Enable USB host clock. */
 	*AT91C_PMC_SCER = AT91C_PMC_UHP;	/* 48MHz clock enabled for UHP */
@@ -36,7 +36,7 @@ int usb_cpu_init()
 	return 0;
 }
 
-int usb_cpu_stop()
+int usb_cpu_stop(void)
 {
 	/* Initialization failed */
 	*AT91C_PMC_PCDR = 1 << AT91C_ID_UHP;	/* Peripheral Clock Disable Register */
@@ -44,9 +44,9 @@ int usb_cpu_stop()
 	return 0;
 }
 
-int usb_cpu_init_fail()
+int usb_cpu_init_fail(void)
 {
-	usb_cpu_stop();
+	return usb_cpu_stop();
 }
 
 # endif /* CONFIG_AT91RM9200 */
cpu/pxa/usb.c +3 -3
index 3c11d4d..d2812a4 100644
@@ -28,7 +28,7 @@
 
 #include <asm/arch/pxa-regs.h>
 
-int usb_cpu_init()
+int usb_cpu_init(void)
 {
 #if defined(CONFIG_CPU_MONAHANS)
 	/* Enable USB host clock. */
@@ -65,7 +65,7 @@ int usb_cpu_init()
 	return 0;
 }
 
-int usb_cpu_stop()
+int usb_cpu_stop(void)
 {
 	UHCHR |= UHCHR_FHR;
 	udelay(11);
@@ -86,7 +86,7 @@ int usb_cpu_stop()
 	return 0;
 }
 
-int usb_cpu_init_fail()
+int usb_cpu_init_fail(void)
 {
 	return 0;
 }
Signature · 1 line
1.5.3.2
#1 lore raw

PATCH 1/1 fix warning: no return statement in function returning non-void

cpu/arm920t/at91rm9200/usb.c

Quoted 3 lines · In message <[email protected]> you wrote:
cpu/arm920t/at91rm9200/usb.c +0 -0

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Those who do not  understand  Unix  are  condemned  to  reinvent  it,
poorly.              - Henry Spencer, University of Toronto Unix hack