serial/8250_pci: Fix a warning in pciserial_resume_one
PATCH 1/1 serial/8250_pci: Fix a warning in pciserial_resume_one
Fix the following warning:drivers/serial/8250_pci.c: In function "pciserial_resume_one":drivers/serial/8250_pci.c:1998: warning: ignoring return value of "pci_enable_device", declared with attribute warn_unused_result
Signed-off-by Jean Delvare <[email protected]>
---
As a side note, I'm curious why the call to pci_enable_device() is conditioned by priv being set. I'm also not sure if additional cleanups should be performed if an error occurs.
drivers/serial/8250_pci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/serial/8250_pci.c +4 -1
@@ -1987,6 +1987,7 @@ static int pciserial_suspend_one(structstatic int pciserial_resume_one (struct pci_dev *dev) {struct serial_private *priv =pci_get_drvdata (dev); +int rc;pci_set_power_state (dev,PCI_D0 );pci_restore_state (dev);
@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct p/* * The device may have been disabled. Re-enable it. */ -pci_enable_device (dev); + rc =pci_enable_device (dev); +if (rc) +return rc;pciserial_resume_ports (priv); }
Signature · 1 line
Jean Delvare