ssb: Add "ssb_pci_set_power_state" function
PATCH 1/2 ssb: Add "ssb_pci_set_power_state" function
Add "ssb_pci_set_power_state" function. This allows set the power state=
of a=20
PCI device (for example b44 ethernet device).
diff -ruN linux-2.6.23/include/linux/ssb/ssb.h=20 linux-2.6.23.orig/include/linux/ssb/ssb.h
--- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.00000=
0000=20
+0200
+++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.000000000 =
+0200
@@ -402,6 +402,14 @@
{
pci_unregister_driver(driver);
}
+
+/* Set PCI device power state */
+static inline
+void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t state= )
+{
+ if(dev->bus->bustype =3D=3D SSB_BUSTYPE_PCI)
+ pci_set_power_state(dev->bus->host_pci, state);
+}
#endif /* CONFIG_SSB_PCIHOST */
=20
=20
--=20
Miguel Bot=F3n
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line · On Wednesday 24 October 2007 21:31:21 Miguel Bot=F3n wrote:
Add "
ssb_pci_set_power_state" function. This allows set the power sta=
te of a=20
Quoted 5 lines
PCI device (for example b44 ethernet device).
=20
diff -ruN linux-2.6.23/include/linux/ssb/ssb.h=20linux-2.6.23.orig/include/linux/ssb/ssb.h
---linux-2.6.23.orig/include/linux/ssb/ssb.h2007-10-24 19:02:33.000=
000000=20
Quoted 2 lines
+0200
+++linux-2.6.23/include/linux/ssb/ssb.h2007-10-24 19:49:37.00000000=
0 +0200
Review line 408
Quoted 8 lines
(quoted diff) +4
-0@@ -402,6 +402,14 @@ { pci_unregister_driver(driver); } + +/* Set PCI device power state */ +static inline +void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t sta=
te)
Review line 410
Quoted 2 lines
(quoted diff) +2
-0+{ + if(dev->bus->bustype =3D=3D SSB_BUSTYPE_PCI)
^
Coding style issue.
Quoted 4 lines
(quoted diff) +2
-0+ pci_set_power_state(dev->bus->host_pci, state); +} #endif /* CONFIG_SSB_PCIHOST */=20
The rest is acked.
--=20
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Miguel,
Along with the style point Michael suggested, I'll need you to repost both this one and the b44 patch with at least a Signed-off-by line.
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Also, please include the patches as plain text using a mailer that does not damage whitespace.
Thanks,
John
Quoted 1 line · On Wed, Oct 24, 2007 at 09:31:21PM +0200, Miguel Bot=F3n wrote:
Add "
ssb_pci_set_power_state" function. This allows set the power sta=
te of a=20
Quoted 5 lines
PCI device (for example b44 ethernet device).
=20
diff -ruN linux-2.6.23/include/linux/ssb/ssb.h=20linux-2.6.23.orig/include/linux/ssb/ssb.h
---linux-2.6.23.orig/include/linux/ssb/ssb.h2007-10-24 19:02:33.000=
000000=20
Quoted 2 lines
+0200
+++linux-2.6.23/include/linux/ssb/ssb.h2007-10-24 19:49:37.00000000=
0 +0200
Review line 408
Quoted 8 lines
(quoted diff) +4
-0@@ -402,6 +402,14 @@ { pci_unregister_driver(driver); } + +/* Set PCI device power state */ +static inline +void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t sta=
te)
Quoted 10 lines
(quoted diff) +4
-0+{ + if(dev->bus->bustype =3D=3D SSB_BUSTYPE_PCI) + pci_set_power_state(dev->bus->host_pci, state); +} #endif /* CONFIG_SSB_PCIHOST */=20
=20
=20
--=20
Miguel Bot=F3n
--=20
John W. Linville
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html