Skip to contentSkip to conversation

unexport tick_nohz_get_sleep_length

PATCH Applied Adrian Bunk 4 participants 5 messages Oct 24, 2007 – Oct 25, 2007 Nohz, dynticks support

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 unexport tick_nohz_get_sleep_length

This patch removes the unused
EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).

Signed-off-by Adrian Bunk <[email protected]>

---
f7c83dfe117f4fd072b2506ae090e4145abda362

kernel/time/tick-sched.c +0 -2
index 10a1347..5997456 100644
@@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
 	return ts->sleep_length;
 }
 
-EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
-
 /**
  * nohz_restart_sched_tick - restart the idle tick from the idle task
  *
#1 lore raw
Quoted 12 lines · Adrian Bunk

This patch removes the unused
EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).

Signed-off-by Adrian Bunk <[email protected]>

---
f7c83dfe117f4fd072b2506ae090e4145abda362

kernel/time/tick-sched.c +0 -0
index 10a1347..5997456 100644

kernel/time/tick-sched.c ktime_t tick_nohz_get_sleep_length(void) · line 324

Quoted 5 lines
kernel/time/tick-sched.c +0 -2
@@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
 	return ts->sleep_length;
 }
 
-EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
-

Hmm, this was added to allow the cpuidle governers modular build. Seems this was changed to compiled in only.

Len, Venki, is this the final decision ?

tglx

#2 lore raw
Quoted 25 lines

-----Original Message-----
From: Thomas Gleixner [mailto:[email protected]]
Sent: Thursday, October 25, 2007 2:28 AM
To: Adrian Bunk
Cc: Brown, Len; LKML; Pallipadi, Venkatesh
Subject: Re: [2.6 patch] unexport tick_nohz_get_sleep_length

Quoted 15 lines · Adrian Bunk

This patch removes the unused
EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).

Signed-off-by Adrian Bunk <[email protected]>

---
f7c83dfe117f4fd072b2506ae090e4145abda362

kernel/time/tick-sched.c +0 -0
index 10a1347..5997456 100644
@@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
 	return ts->sleep_length;
 }
Quoted 8 lines

kernel/time/tick-sched.c ktime_t tick_nohz_get_sleep_length(void) · line 324

Quoted 2 lines
kernel/time/tick-sched.c +0 -2
-EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
-

Hmm, this was added to allow the cpuidle governers modular build. Seems this was changed to compiled in only.

Len, Venki, is this the final decision ?

Yes. This was done recently for proper fallback to old ACPI policy in case CPUIDLE is not selected. With that being module, falling back to ACPI policy at run time makes things ugly.

Thanks,
Venki

#3 lore raw
Quoted 23 lines · Venkatesh
Quoted 23 lines · Adrian Bunk
Quoted 13 lines

This patch removes the unused
EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).

Signed-off-by Adrian Bunk <[email protected]>

---
f7c83dfe117f4fd072b2506ae090e4145abda362

kernel/time/tick-sched.c +0 -0
index 10a1347..5997456 100644

kernel/time/tick-sched.c ktime_t tick_nohz_get_sleep_length(void) · line 324

Quoted 5 lines
kernel/time/tick-sched.c +0 -2
@@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
 	return ts->sleep_length;
 }
 
-EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
-

Hmm, this was added to allow the cpuidle governers modular build. Seems this was changed to compiled in only.

Quoted 6 lines
Quoted 2 lines

Len, Venki, is this the final decision ?

Yes. This was done recently for proper fallback to old ACPI policy in case CPUIDLE is not selected. With that being module, falling back to ACPI policy at run time makes things ugly.

Makes sense. I go ahead and nuke the export.

Thanks,

tglx

Applied
#4 lore raw

Applied.

thanks,
-Len

Quoted 42 lines · Thomas Gleixner
Quoted 23 lines · Venkatesh
Quoted 23 lines · Adrian Bunk
Quoted 13 lines

This patch removes the unused
EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).

Signed-off-by Adrian Bunk <[email protected]>

---
f7c83dfe117f4fd072b2506ae090e4145abda362

kernel/time/tick-sched.c +0 -0
index 10a1347..5997456 100644

kernel/time/tick-sched.c ktime_t tick_nohz_get_sleep_length(void) · line 324

Quoted 5 lines
kernel/time/tick-sched.c +0 -2
@@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
 	return ts->sleep_length;
 }
 
-EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
-

Hmm, this was added to allow the cpuidle governers modular build. Seems this was changed to compiled in only.

Quoted 6 lines
Quoted 2 lines

Len, Venki, is this the final decision ?

Yes. This was done recently for proper fallback to old ACPI policy in case CPUIDLE is not selected. With that being module, falling back to ACPI policy at run time makes things ugly.

Makes sense. I go ahead and nuke the export.

Thanks,

tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/