Skip to contentSkip to conversation

raid6: generate raid6tables.c with proper style

PATCH In review Ingo Molnar 3 participants 4 messages Oct 26, 2007

lore
Share & tools
lore

Ingo Molnar

author
#0 lore raw

PATCH 1/1 raid6: generate raid6tables.c with proper style

Subject: raid6: generate raid6tables.c with proper style
From: Ingo Molnar <[email protected]>

nitpicking from the coding style police: generate a raid6tables.c that does not show up in my editor all red ;-)

this also improves the code quality metric of drivers/md/ by a factor of 10:

errors lines of code errors/KLOC

 drivers/md/  [old]            9349           45543         205.2
 drivers/md/  [new]            1062           45551          23.3

while humans are not likely to read that file, lets just do this to make life easier for automated quality checking ...

Signed-off-by Ingo Molnar <[email protected]>
---
 drivers/md/mktables.c |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
drivers/md/mktables.c +12 -4
Index: linux/drivers/md/mktables.c
===================================================================
@@ -69,7 +69,9 @@ int main(int argc, char *argv[])
     for ( j = 0 ; j < 256 ; j += 8 ) {
       printf("\t\t");
       for ( k = 0 ; k < 8 ; k++ ) {
-	printf("0x%02x, ", gfmul(i,j+k));
+        if (k)
+	  printf(" ");
+	printf("0x%02x,", gfmul(i,j+k));
       }
       printf("\n");
     }

@@ -86,7 +88,9 @@ int main(int argc, char *argv[])
     printf("\t");
     for ( j = 0 ; j < 8 ; j++ ) {
       exptbl[i+j] = v;
-      printf("0x%02x, ", v);
+      if (j)
+	      printf(" ");
+      printf("0x%02x,", v);
       v = gfmul(v,2);
       if ( v == 1 ) v = 0;	/* For entry 255, not a real entry */
     }

@@ -102,7 +106,9 @@ int main(int argc, char *argv[])
     printf("\t");
     for ( j = 0 ; j < 8 ; j++ ) {
       invtbl[i+j] = v = gfpow(i+j,254);
-      printf("0x%02x, ", v);
+      if (j)
+	      printf(" ");
+      printf("0x%02x,", v);
     }
     printf("\n");
   }

@@ -115,7 +121,9 @@ int main(int argc, char *argv[])
   for ( i = 0 ; i < 256 ; i += 8 ) {
     printf("\t");
     for ( j = 0 ; j < 8 ; j++ ) {
-      printf("0x%02x, ", invtbl[exptbl[i+j]^1]);
+      if (j)
+	      printf(" ");
+      printf("0x%02x,", invtbl[exptbl[i+j]^1]);
     }
     printf("\n");
   }
#1 lore raw

fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:

Quoted 2 lines

Subject: raid6: generate raid6tables.c with proper style
From: Ingo Molnar <[email protected]>

[snip]

drivers/md/mktables.c int main(int argc, char *argv[]) · line 74

Quoted 12 lines

Index: linux/drivers/md/mktables.c
===================================================================

drivers/md/mktables.c +3 -1
@@ -69,7 +69,9 @@ int main(int argc, char *argv[])
     for ( j = 0 ; j < 256 ; j += 8 ) {
       printf("\t\t");
       for ( k = 0 ; k < 8 ; k++ ) {
-	printf("0x%02x, ", gfmul(i,j+k));
+        if (k)
+	  printf(" ");
+	printf("0x%02x,", gfmul(i,j+k));

What happened with the coding style here?

Simon Holm Thøgersen

author
#2 lore raw
Quoted 6 lines · Simon Holm Thøgersen

fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:

Quoted 2 lines

Subject: raid6: generate raid6tables.c with proper style
From: Ingo Molnar <[email protected]>

[snip]

Quoted 14 lines

drivers/md/mktables.c int main(int argc, char *argv[]) · line 74

Quoted 12 lines

Index: linux/drivers/md/mktables.c
===================================================================

drivers/md/mktables.c +3 -1
@@ -69,7 +69,9 @@ int main(int argc, char *argv[])
     for ( j = 0 ; j < 256 ; j += 8 ) {
       printf("\t\t");
       for ( k = 0 ; k < 8 ; k++ ) {
-	printf("0x%02x, ", gfmul(i,j+k));
+        if (k)
+	  printf(" ");
+	printf("0x%02x,", gfmul(i,j+k));

What happened with the coding style here?

i adopted to the existing (broken) one. Yes, mktables.c could need a good cleanup too.

Ingo

#3 lore raw
Quoted 21 lines · Ingo Molnar
Quoted 5 lines · Simon Holm Thøgersen

fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:

Quoted 2 lines

Subject: raid6: generate raid6tables.c with proper style
From: Ingo Molnar <[email protected]>

[snip]

Quoted 13 lines

drivers/md/mktables.c int main(int argc, char *argv[]) · line 74

Quoted 12 lines

Index: linux/drivers/md/mktables.c
===================================================================

drivers/md/mktables.c +3 -1
@@ -69,7 +69,9 @@ int main(int argc, char *argv[])
     for ( j = 0 ; j < 256 ; j += 8 ) {
       printf("\t\t");
       for ( k = 0 ; k < 8 ; k++ ) {
-	printf("0x%02x, ", gfmul(i,j+k));
+        if (k)
+	  printf(" ");
+	printf("0x%02x,", gfmul(i,j+k));

What happened with the coding style here?

Quoted 2 lines

i adopted to the existing (broken) one. Yes, mktables.c could need a good cleanup too.

More so than the output, IMNSHO. I'll take care of it.

-hpa