Skip to contentSkip to conversation

fix USB_OHCI_HCD_SSB dependencies

PATCH In review Adrian Bunk 4 participants 5 messages Oct 27, 2007 – Oct 28, 2007 USB

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 fix USB_OHCI_HCD_SSB dependencies

This patch fixes a bug introduced by
commit b22817b3c81cdb18ffe3d2debfee968731a8b5f4.

Signed-off-by Adrian Bunk <[email protected]>

---
155ad66379582067ef2ce73d28e3cf6eedf21b14

drivers/usb/host/Kconfig +1 -1
index 177e78e..49a91c5 100644
@@ -156,7 +156,7 @@ config USB_OHCI_HCD_PCI
 
 config USB_OHCI_HCD_SSB
 	bool "OHCI support for Broadcom SSB OHCI core"
-	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
+	depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
 	default n
 	---help---
 	  Support for the Sonics Silicon Backplane (SSB) attached
#1 lore raw

drivers/usb/host/Kconfig config USB_OHCI_HCD_PCI · line 159

Quoted 2 lines · Adrian Bunk
drivers/usb/host/Kconfig +1 -1
-	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
+	depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL

oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn somewhere if it sees an erroneous CONFIG_ token?

Ingo

author
#2 lore raw
Quoted 8 lines · Ingo Molnar

drivers/usb/host/Kconfig config USB_OHCI_HCD_PCI · line 159

Quoted 2 lines · Adrian Bunk
drivers/usb/host/Kconfig +1 -1
-	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
+	depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL

oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn somewhere if it sees an erroneous CONFIG_ token?

No. IIRC Sam was working in getting warnings for such things, but currently kconfig simply can't know whether it's a bug or OK.

Quoted 1 line

Ingo

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 12 lines · Adrian Bunk
Quoted 9 lines · Ingo Molnar

drivers/usb/host/Kconfig config USB_OHCI_HCD_PCI · line 159

Quoted 3 lines · Adrian Bunk
drivers/usb/host/Kconfig +1 -1
-	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
+	depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL

oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn somewhere if it sees an erroneous CONFIG_ token?

Quoted 3 lines

No. IIRC Sam was working in getting warnings for such things, but currently kconfig simply can't know whether it's a bug or OK.

Are there any instances of CONFIG_CONFIG_X? Doesn't seem like a terribly sensible name...

J

#4 lore raw
Quoted 13 lines · Jeremy Fitzhardinge
Quoted 12 lines · Adrian Bunk
Quoted 9 lines · Ingo Molnar

drivers/usb/host/Kconfig config USB_OHCI_HCD_PCI · line 159

Quoted 3 lines · Adrian Bunk
drivers/usb/host/Kconfig +1 -1
-	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
+	depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL

oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn somewhere if it sees an erroneous CONFIG_ token?

Quoted 5 lines
Quoted 2 lines

No. IIRC Sam was working in getting warnings for such things, but currently kconfig simply can't know whether it's a bug or OK.

Are there any instances of CONFIG_CONFIG_X? Doesn't seem like a terribly sensible name...

there used to be:

http://lists.linuxcoding.com/kernel/2006-q1/msg18685.html

but that was just the one, and it's gone now.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================