Skip to contentSkip to conversation

git-sh-setup.sh: use "git rev-parse --show-cdup" to check for SUBDIRECTORY_OK

PATCH New Nguyễn Thái Ngọc Duy 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

Nguyễn Thái Ngọc Duy

author
#0 lore raw

PATCH 1/1 git-sh-setup.sh: use "git rev-parse --show-cdup" to check for SUBDIRECTORY_OK

"git rev-parse --git-dir" trick does not play well with worktree

Signed-off-by Nguyễn Thái Ngọc Duy <[email protected]>
---
 git-sh-setup.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
git-sh-setup.sh +1 -1
index 3c325fd..86d7d4c 100755
@@ -110,7 +110,7 @@ esac
 if [ -z "$SUBDIRECTORY_OK" ]
 then
 	: ${GIT_DIR=.git}
-	GIT_DIR=$(GIT_DIR="$GIT_DIR" git rev-parse --git-dir) || {
+	test -z "$(git rev-parse --show-cdup)" || {
 		exit=$?
 		echo >&2 "You need to run this command from the toplevel of the working tree."
 		exit $exit
Signature · 1 line
1.5.3.rc4.3.gab089