Skip to contentSkip to conversation

tle62x0 driver stops ignoring read errors

PATCH New David Brownell 1 participant 1 message Oct 28, 2007 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tle62x0 driver stops ignoring read errors

The tle62x0 driver was ignoring all read errors. This patch makes it pass such errors up the stack, instead of returning bogus data.

---
 drivers/spi/tle62x0.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/tle62x0.c +4 -1
@@ -107,8 +107,11 @@ static ssize_t tle62x0_status_show(struc
 
 	mutex_lock(&st->lock);
 	ret = tle62x0_read(st);
-
 	dev_dbg(dev, "tle62x0_read() returned %d\n", ret);
+	if (ret < 0) {
+		mutex_unlock(&st->lock);
+		return ret;
+	}
 
 	for (ptr = 0; ptr < (st->nr_gpio * 2)/8; ptr += 1) {
 		fault <<= 8;

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/