scsi/seagate.c: remove dead code
PATCH 1/1 scsi/seagate.c: remove dead code
This patch removes obviously dead code.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/scsi/seagate.c | 2 -- 1 file changed, 2 deletions(-)
c0807bbefb65ef679b7d2ec13d14c35f2e927404
drivers/scsi/seagate.c +0 -2
@@ -1437,17 +1437,15 @@ connect_loop:break ;#ifdef LINKED case LINKED_WRONG :WRITE_DATA (ABORT ); linked_connected =0 ; reselect =CAN_RECONNECT ; goto connect_loop; -DPRINTK (PHASE_MSGOUT |DEBUG_LINKED ,"scsi%d : sent ABORT message to cancel incorrect I_T_L nexus.\n" , hostno);#endif /* LINKED */ -DPRINTK (DEBUG_LINKED ,"correct\n" );default :WRITE_DATA (NOP );printk ("scsi%d : target %d requested MSGOUT, sent NOP message.\n" , hostno, target); }break ;case REQ_MSGIN :
drivers/scsi/seagate.c connect_loop: · line 1445
Quoted 10 lines · Adrian Bunk
This patch removes obviously dead code.
drivers/scsi/seagate.c +0
-2case LINKED_WRONG :WRITE_DATA (ABORT ); linked_connected =0 ; reselect =CAN_RECONNECT ; goto connect_loop; -DPRINTK (PHASE_MSGOUT |DEBUG_LINKED ,"scsi%d : sent ABORT message to cancel incorrect I_T_L nexus.\n" , hostno);#endif /* LINKED */ -DPRINTK (DEBUG_LINKED ,"correct\n" );default :
Surely the 'goto' should just be moved two lines down?
Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
Quoted 9 lines · Adrian Bunk
This patch removes obviously dead code.
Signed-off-by Adrian Bunk <[email protected]>---
drivers/scsi/seagate.c | 2 -- 1 file changed, 2 deletions(-)
Actually I have sent a patch to completely remove this driver.
http://www.spinics.net/lists/linux-scsi/msg20308.html
Does any one objects?
Boaz