inport.c & logibm.c should use KERN_WARNING instead of KERN_ERR

PATCH New Helge Deller 1 participant 1 message Oct 28, 2007

Subsystems (2)

HID Input drivers

lore

Share & tools

lore

Helge Deller

author

2007-10-28 18:58 UTC #0 lore raw

PATCH 1/1 inport.c & logibm.c should use KERN_WARNING instead of KERN_ERR

Many mouse drivers are often compiled (e.g. in Linux distributions) into the kernel at the same time just to make sure that at least one driver will suceed to find it's mouse device. Nevertheless, only the inport and logitech busmouse mouse drivers report with KERN_ERR log level if the mouse wasn't found.
I think they should use KERN_WARNING instead, because it's not an error if the mouse isn't attached at all.

Signed-off-by Helge Deller <[email protected]>

drivers/input/mouse/inport.c +1 -1

index 655a392..db3a80e 100644
@@ -144,7 +144,7 @@ static int __init inport_init(void)
 	b = inb(INPORT_SIGNATURE_PORT);
 	c = inb(INPORT_SIGNATURE_PORT);
 	if (a == b || a != c) {
-		printk(KERN_ERR "inport.c: Didn't find InPort mouse at %#x\n", INPORT_BASE);
+		printk(KERN_WARNING "inport.c: Didn't find InPort mouse at %#x\n", INPORT_BASE);
 		err = -ENODEV;
 		goto err_release_region;
 	}

drivers/input/mouse/logibm.c +1 -1

index b23a4f3..a53d1d8 100644
@@ -134,7 +134,7 @@ static int __init logibm_init(void)
 	udelay(100);
 
 	if (inb(LOGIBM_SIGNATURE_PORT) != LOGIBM_SIGNATURE_BYTE) {
-		printk(KERN_ERR "logibm.c: Didn't find Logitech busmouse at %#x\n", LOGIBM_BASE);
+		printk(KERN_WARNING "logibm.c: Didn't find Logitech busmouse at %#x\n", LOGIBM_BASE);
 		err = -ENODEV;
 		goto err_release_region;
 	}