Skip to contentSkip to conversation

PATCH: tcp rfc 2385 security/bugfix for sparc64

DISCUSSION Matthias Dellweg 2 participants 2 messages Oct 16, 2007 – Oct 30, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi David,
while reviewing the tcp_md5-related code further i came across with another two of these casts which you probably have missed. I don't actually think that they impose a problem by now, but as you said we should remove them. Matthias

net/ipv4/tcp_ipv4.c 2007-10-16 17:50:05.000000000 +0200 renamed from net/ipv4/tcp_ipv4.c 2007-10-16 17:25:05.000000000 +0200 +5 -5
@@ -857,16 +857,16 @@ int tcp_v4_md5_do_add(struct sock *sk, _
                      u8 *newkey, u8 newkeylen)
 {
        /* Add Key to the list */
-       struct tcp4_md5sig_key *key;
+       struct tcp_md5sig_key *key;
        struct tcp_sock *tp = tcp_sk(sk);
        struct tcp4_md5sig_key *keys;
 
-       key = (struct tcp4_md5sig_key *)tcp_v4_md5_do_lookup(sk, addr);
+       key = tcp_v4_md5_do_lookup(sk, addr);
        if (key) {
                /* Pre-existing entry - just update that one. */
-               kfree(key->base.key);
-               key->base.key = newkey;
-               key->base.keylen = newkeylen;
+               kfree(key->key);
+               key->key = newkey;
+               key->keylen = newkeylen;
        } else {
                struct tcp_md5sig_info *md5sig;
 
net/ipv6/tcp_ipv6.c 2007-10-16 17:49:25.000000000 +0200 renamed from net/ipv6/tcp_ipv6.c 2007-10-16 17:47:57.000000000 +0200 +5 -5
@@ -560,16 +560,16 @@ static int tcp_v6_md5_do_add(struct sock
                             char *newkey, u8 newkeylen)
 {
        /* Add key to the list */
-       struct tcp6_md5sig_key *key;
+       struct tcp_md5sig_key *key;
        struct tcp_sock *tp = tcp_sk(sk);
        struct tcp6_md5sig_key *keys;
 
-       key = (struct tcp6_md5sig_key*) tcp_v6_md5_do_lookup(sk, peer);
+       key = tcp_v6_md5_do_lookup(sk, peer);
        if (key) {
                /* modify existing entry - just update that one */
-               kfree(key->base.key);
-               key->base.key = newkey;
-               key->base.keylen = newkeylen;
+               kfree(key->key);
+               key->key = newkey;
+               key->keylen = newkeylen;
        } else {
                /* reallocate new list if current one is full. */
                if (!tp->md5sig_info) {
maintainer
#1 lore raw

From: Matthias Dellweg <[email protected]>
Date: Tue, 16 Oct 2007 18:47:56 +0200

Quoted 3 lines

while reviewing the tcp_md5-related code further i came across with another two of these casts which you probably have missed. I don't actually think that they impose a problem by now, but as you said we should remove them.

I'll apply this patch, thanks Matthias.