pciserial_resume_one ignored return value of pci_enable_device
PATCH 1/1 pciserial_resume_one ignored return value of pci_enable_device
[PATCH] pciserial_resume_one ignored return value of pci_enable_device
Signed-off-by Dirk Hohndel <[email protected]>
--- drivers/serial/8250_pci.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/serial/8250_pci.c +4 -1
@@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)static int pciserial_resume_one (struct pci_dev *dev) { +int err;struct serial_private *priv =pci_get_drvdata (dev);pci_set_power_state (dev,PCI_D0 );
@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)/* * The device may have been disabled. Re-enable it. */ -pci_enable_device (dev); + err =pci_enable_device (dev); +if (err) +return err;pciserial_resume_ports (priv); }
Signature · 1 line
gitgui.0.8.4.g8d863
Quoted 3 lines · On Mon, 29 Oct 2007 06:28:17 -0700 Dirk Hohndel <[email protected]> wrote:
[PATCH]
pciserial_resume_oneignored return value ofpci_enable_deviceSigned-off-by Dirk Hohndel <[email protected]>
Acked-by Alan Cox <[email protected]>
Not sure its worth the hassle but I guess someone could pull a hotplug PCI serial card and then resume.
Quoted 21 lines · Dirk Hohndel
[PATCH]
pciserial_resume_oneignored return value ofpci_enable_deviceSigned-off-by Dirk Hohndel <[email protected]>--- drivers/serial/8250_pci.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)drivers/serial/8250_pci.c +1
-0@@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)static int pciserial_resume_one (struct pci_dev *dev) { +int err;struct serial_private *priv =pci_get_drvdata (dev);pci_set_power_state (dev,PCI_D0 );
drivers/serial/8250_pci.c static int pciserial_resume_one(struct pci_dev *dev) · line 2001
Quoted 7 lines
drivers/serial/8250_pci.c +3
-1@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)/* * The device may have been disabled. Re-enable it. */ -pci_enable_device (dev); + err =pci_enable_device (dev); +if (err) +return err;
ACK