Skip to contentSkip to conversation

Update libfdt to 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from dtc

PATCH New Kumar Gala 3 participants 5 messages Oct 29, 2007 – Oct 30, 2007

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 Update libfdt to 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from dtc

Patch imports libfdt from dtc as of commit
7b3fb789d2cd5fed818f439d0c7aed44b9860fab

This is a large patch thus located at the following locations:

http://gate.crashing.org/~galak/0001-Update-libfdt-
to-7b3fb789d2cd5fed818f439d0c7aed44b98.patch

git.kernel.org:/pub/scm/boot/u-boot/galak/u-boot.git libfdt

---
  board/cm5200/cm5200.c             |    2 +-
  board/freescale/mpc832xemds/pci.c |    2 +-
  board/freescale/mpc8349emds/pci.c |    4 +-
  board/freescale/mpc8349itx/pci.c  |    4 +-
  board/freescale/mpc8360emds/pci.c |    2 +-
  common/cmd_fdt.c                  |   22 +-
  common/fdt_support.c              |   30 +--
  cpu/mpc83xx/cpu.c                 |    4 +-
  cpu/mpc83xx/pci.c                 |    4 +-
  include/fdt.h                     |   51 +---
  include/libfdt.h                  |  386 +++++++++++++++++++++---
  libfdt/fdt.c                      |   97 +++++-
  libfdt/fdt_ro.c                   |  609 ++++++++++++++++++++++ 
+--------------
  libfdt/fdt_rw.c                   |  129 +++++++--
  libfdt/fdt_strerror.c             |   54 +++-
  libfdt/fdt_sw.c                   |   92 ++++--
  libfdt/fdt_wip.c                  |   89 +++---
  libfdt/libfdt_internal.h          |   81 ++++-
  18 files changed, 1173 insertions(+), 489 deletions(-)
#1 lore raw

PATCH 1/1 Update libfdt to 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from dtc

Quoted 2 lines · In message <[email protected]> you wrote:

Patch imports libfdt from dtc as of commit
7b3fb789d2cd5fed818f439d0c7aed44b9860fab

Urmm... Sorry, but I cannot make heads nor tails from this commit log. Can you please explain what it's supposed to mean?

And then eventually resubmit a patch which contains such a description that can be understood by a mere mortal?

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Each honest calling, each walk of life, has its own  elite,  its  own
aristocracy based on excellence of performance. - James Bryant Conant
author
#2 lore raw

PATCH 1/1 Update libfdt to 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from dtc

Quoted 10 lines · Wolfgang Denk

In message <F812D664-

Quoted 2 lines · EDEF-4307-9946-89EDF9B97126 at kernel.crashing.org> you wrote:

Patch imports libfdt from dtc as of commit
7b3fb789d2cd5fed818f439d0c7aed44b9860fab

Urmm... Sorry, but I cannot make heads nor tails from this commit log. Can you please explain what it's supposed to mean?

And then eventually resubmit a patch which contains such a description that can be understood by a mere mortal?

Sure, this was more of an RFC post.

It was updating the libfdt sources in u-boot to commit 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from the device tree compiler (dtc). dtc contains the reference source for libfdt.

(is that any less confusing?)

- k

#3 lore raw

PATCH 1/1 Update libfdt to 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from dtc

Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Urmm... Sorry, but I cannot make heads nor tails from this commit log. Can you please explain what it's supposed to mean?

...

Quoted 3 lines

It was updating the libfdt sources in u-boot to commit 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from the device tree compiler (dtc). dtc contains the reference source for libfdt.

How about: "...to commit 7b3fb789 from the device tree compiler (dtc) project. ..."

Just to make clear that this is a commit ID from a completely different source tree.

Quoted 1 line

(is that any less confusing?)

Yes. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Four thousand throats may be cut in one night by a running man.
	-- Klingon Soldier, "Day of the Dove", stardate unknown
#4 lore raw

PATCH 1/1 Update libfdt to 7b3fb789d2cd5fed818f439d0c7aed44b9860fab from dtc

In reply to Kumar Gala
Quoted 24 lines · Kumar Gala

Patch imports libfdt from dtc as of commit
7b3fb789d2cd5fed818f439d0c7aed44b9860fab

This is a large patch thus located at the following locations:

http://gate.crashing.org/~galak/0001-Update-libfdt-to-7b3fb789d2cd5fed818f439d0c7aed44b98.patch

git.kernel.org:/pub/scm/boot/u-boot/galak/u-boot.git libfdt

---
 board/cm5200/cm5200.c             |    2 +-
 board/freescale/mpc832xemds/pci.c |    2 +-
 board/freescale/mpc8349emds/pci.c |    4 +-
 board/freescale/mpc8349itx/pci.c  |    4 +-
 board/freescale/mpc8360emds/pci.c |    2 +-
 common/cmd_fdt.c                  |   22 +-
 common/fdt_support.c              |   30 +--
 cpu/mpc83xx/cpu.c                 |    4 +-
 cpu/mpc83xx/pci.c                 |    4 +-
 include/fdt.h                     |   51 +---
 include/libfdt.h                  |  386 +++++++++++++++++++++---
 libfdt/fdt.c                      |   97 +++++-
Quoted 8 lines
 libfdt/fdt_ro.c                   |  609 
+++++++++++++++++++++++--------------
 libfdt/fdt_rw.c                   |  129 +++++++--
 libfdt/fdt_strerror.c             |   54 +++-
 libfdt/fdt_sw.c                   |   92 ++++--
 libfdt/fdt_wip.c                  |   89 +++---
 libfdt/libfdt_internal.h          |   81 ++++-
 18 files changed, 1173 insertions(+), 489 deletions(-)

Hi Kumar,

Thanks for working on this. I cleaned up my u-boot-fdt subrepo in preparation for the next round of improvements, of which this will be the base.

I've been thinking about how best to do the unfork libfdt and how best to stay in sync down the road, but I don't have any good ideas other than to just do it. Down the road, we could try to cherrypick just the libfdt changes (assuming David and Jon keep libfdt changes distinct from dtc changes in their patches), or we can have an Project Orion approach:
lots of big bangs.
<http://en.wikipedia.org/wiki/Project_Orion_%28nuclear_propulsion%29>

FWIIW, I thought about doing our unfork via applying libfdt patches from the dtc repository - according to my README, I started from commit
857f54e79f74429af20c2b5ecc00ee98af6a3b8b
which is in there. Hmmmmm, something to think about. That would help with the size of the patch (one Project Orion patch or a bunch of smaller ones), it would be nice for tracking who changed what and why, but it will be a fair amount of work (and some scripting) to identify the applicable libfdt patches.

gvb