Skip to contentSkip to conversation

CRIS architecture: Correct compile errors

PATCH In review Jesper Nilsson 2 participants 5 messages Oct 30, 2007 – Nov 6, 2007 Memory technology devices (MTD)

lore
Share & tools
lore

Jesper Nilsson

author
#0 lore raw

PATCH 11/16 CRIS architecture: Correct compile errors

Add include file with prototype for mtdram_init_device from drivers/mtd/devices/mtdram.c.
Used by axisflashmap.c to boot from ram.

Signed-off-by Jesper Nilsson <[email protected]>
---
 mtdram.h |   10 ++++++++++
 1 file changed, 10 insertions(+)
include/linux/mtd/mtdram.h new file +10 -0
@@ -0,0 +1,10 @@
+#ifndef __MTD_MTDRAM_H__
+#define __MTD_MTDRAM_H__
+
+#ifdef __KERNEL__
+#include <linux/mtd/mtd.h>
+int mtdram_init_device(struct mtd_info *mtd, void *mapped_address, 
+                       unsigned long size, char *name);
+
+#endif /* __KERNEL__ */
+#endif /* __MTD_MTDRAM_H__ */

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

author
#2 lore raw
Quoted 6 lines · David Woodhouse
Quoted 4 lines · Jesper Nilsson

Add include file with prototype for mtdram_init_device from drivers/mtd/devices/mtdram.c.
Used by axisflashmap.c to boot from ram.

Quoted 6 lines
Quoted 1 line
Signed-off-by Jesper Nilsson <[email protected]>
Reviewed-by David Woodhouse <[email protected]>

You want this to go via the mtd git tree, or with the rest of your patches?

Whatever is best and/or easiest for you, is probably the answer.

Since this makes the arch compile, it would be good to get it in soonish, but if you prefer we could go via mtd, which I gather is the more official route.

Quoted 1 line

dwmw2

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

#3 lore raw
In reply to Jesper Nilsson
Quoted 13 lines · Jesper Nilsson

Add include file with prototype for mtdram_init_device from drivers/mtd/devices/mtdram.c.
Used by axisflashmap.c to boot from ram.

Signed-off-by Jesper Nilsson <[email protected]>
---
 mtdram.h |   10 ++++++++++
 1 file changed, 10 insertions(+)

include/linux/mtd/mtdram.h line 10

Quoted 10 lines
include/linux/mtd/mtdram.h new file +10 -0
@@ -0,0 +1,10 @@
+#ifndef __MTD_MTDRAM_H__
+#define __MTD_MTDRAM_H__
+
+#ifdef __KERNEL__
+#include <linux/mtd/mtd.h>
+int mtdram_init_device(struct mtd_info *mtd, void *mapped_address, 
+                       unsigned long size, char *name);
+
+#endif /* __KERNEL__ */
+#endif /* __MTD_MTDRAM_H__ */

You don't need #ifdef __KERNEL__ on a file which isn't exported to userspace. Having removed that, I've applied it to my tree.

Signature · 1 line
dwmw2
author
#4 lore raw
Quoted 2 lines · David Woodhouse

You don't need #ifdef __KERNEL__ on a file which isn't exported to userspace. Having removed that, I've applied it to my tree.

Ok, thanks, I'll do the same change in our internal CVS.

Quoted 1 line

dwmw2

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]