Skip to contentSkip to conversation

acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.

PATCH In review Richard Knutsson 2 participants 2 messages Oct 30, 2007 – Oct 31, 2007

Subsystems (2)
ACPI ACPI component architecture (acpica)
lore
Share & tools
lore

Richard Knutsson

author
#0 lore raw

PATCH 1/1 acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.

'acpi_gbl_system_awake_and_running' is no longer used, only assigned.

Signed-off-by Richard Knutsson <[email protected]>

---
Diffed against linus-git
Checked with script/checkpatch.pl

 drivers/acpi/hardware/hwsleep.c   |    5 -----
 drivers/acpi/utilities/utglobal.c |    1 -
 include/acpi/acglobal.h           |    1 -
 3 files changed, 7 deletions(-)
drivers/acpi/hardware/hwsleep.c +0 -5
index 81b2484..e020e50 100644
@@ -300,8 +300,6 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
 		return_ACPI_STATUS(status);
 	}
 
-	acpi_gbl_system_awake_and_running = FALSE;
-
 	status = acpi_hw_enable_all_wakeup_gpes();
 	if (ACPI_FAILURE(status)) {
 		return_ACPI_STATUS(status);

@@ -446,7 +444,6 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
 	if (ACPI_FAILURE(status)) {
 		return_ACPI_STATUS(status);
 	}
-	acpi_gbl_system_awake_and_running = FALSE;
 
 	status = acpi_hw_enable_all_wakeup_gpes();
 	if (ACPI_FAILURE(status)) {

@@ -587,8 +584,6 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state)
 	}
 	/* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
 
-	acpi_gbl_system_awake_and_running = TRUE;
-
 	/* Enable power button */
 
 	(void)
drivers/acpi/utilities/utglobal.c +0 -1
index 93ea829..f2ba315 100644
@@ -709,7 +709,6 @@ void acpi_ut_init_globals(void)
 	/* Hardware oriented */
 
 	acpi_gbl_events_initialized = FALSE;
-	acpi_gbl_system_awake_and_running = TRUE;
 
 	/* Namespace */
include/acpi/acglobal.h +0 -1
index 347a911..ae0fc0a 100644
@@ -236,7 +236,6 @@ ACPI_EXTERN u8 acpi_gbl_step_to_next_call;
 ACPI_EXTERN u8 acpi_gbl_acpi_hardware_present;
 ACPI_EXTERN u8 acpi_gbl_global_lock_present;
 ACPI_EXTERN u8 acpi_gbl_events_initialized;
-ACPI_EXTERN u8 acpi_gbl_system_awake_and_running;
 
 extern u8 acpi_gbl_shutdown;
 extern u32 acpi_gbl_startup_flags;
reviewer
#1 lore raw

Bob reports that this is used in a pending version of ACPICA, so we'll leave the code alone.

thanks,
-Len

Quoted 73 lines · Richard Knutsson

'acpi_gbl_system_awake_and_running' is no longer used, only assigned.

Signed-off-by Richard Knutsson <[email protected]>

---
Diffed against linus-git
Checked with script/checkpatch.pl

 drivers/acpi/hardware/hwsleep.c   |    5 -----
 drivers/acpi/utilities/utglobal.c |    1 -
 include/acpi/acglobal.h           |    1 -
 3 files changed, 7 deletions(-)
drivers/acpi/hardware/hwsleep.c +0 -5
index 81b2484..e020e50 100644
@@ -300,8 +300,6 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
 		return_ACPI_STATUS(status);
 	}
 
-	acpi_gbl_system_awake_and_running = FALSE;
-
 	status = acpi_hw_enable_all_wakeup_gpes();
 	if (ACPI_FAILURE(status)) {
 		return_ACPI_STATUS(status);

@@ -446,7 +444,6 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
 	if (ACPI_FAILURE(status)) {
 		return_ACPI_STATUS(status);
 	}
-	acpi_gbl_system_awake_and_running = FALSE;
 
 	status = acpi_hw_enable_all_wakeup_gpes();
 	if (ACPI_FAILURE(status)) {

@@ -587,8 +584,6 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state)
 	}
 	/* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
 
-	acpi_gbl_system_awake_and_running = TRUE;
-
 	/* Enable power button */
 
 	(void)
drivers/acpi/utilities/utglobal.c +0 -1
index 93ea829..f2ba315 100644
@@ -709,7 +709,6 @@ void acpi_ut_init_globals(void)
 	/* Hardware oriented */
 
 	acpi_gbl_events_initialized = FALSE;
-	acpi_gbl_system_awake_and_running = TRUE;
 
 	/* Namespace */
include/acpi/acglobal.h +0 -2
index 347a911..ae0fc0a 100644
@@ -236,7 +236,6 @@ ACPI_EXTERN u8 acpi_gbl_step_to_next_call;
 ACPI_EXTERN u8 acpi_gbl_acpi_hardware_present;
 ACPI_EXTERN u8 acpi_gbl_global_lock_present;
 ACPI_EXTERN u8 acpi_gbl_events_initialized;
-ACPI_EXTERN u8 acpi_gbl_system_awake_and_running;
 
 extern u8 acpi_gbl_shutdown;
 extern u32 acpi_gbl_startup_flags;
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/