: exit_ivtv_i2c() cannot be __devexit
PATCH 1/1 : exit_ivtv_i2c() cannot be __devexit
Please apply, thanks!
[MEDIA] IVTV: exit_ivtv_i2c() cannot be __devexit
It is referenced both from __devinit code (ivtv_probe) and normal .text (ivtv_process_eeprom), and therefore cannot be discarded via __devexit.
Signed-off-by David S. Miller <[email protected]>
--- drivers/media/video/ivtv/ivtv-i2c.c | 2 +- drivers/media/video/ivtv/ivtv-i2c.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/media/video/ivtv/ivtv-i2c.c +1 -1
@@ -741,7 +741,7 @@ int __devinit init_ivtv_i2c(struct ivtv *itv)return i2c_bit_add_bus (&itv->i2c_adap); } -void __devexit exit_ivtv_i2c(struct ivtv *itv) +void exit_ivtv_i2c (struct ivtv *itv) {IVTV_DEBUG_I2C ("i2c exit\n" );
drivers/media/video/ivtv/ivtv-i2c.h +1 -1
@@ -36,6 +36,6 @@ void ivtv_call_i2c_clients(struct ivtv *itv, unsigned int cmd, void *arg);/* init + register i2c algo-bit adapter */ int __devinit init_ivtv_i2c (struct ivtv *itv); -void __devexit exit_ivtv_i2c(struct ivtv *itv); +void exit_ivtv_i2c (struct ivtv *itv);#endif
Quoted 7 lines · David Miller
Please apply, thanks!
[MEDIA] IVTV:
exit_ivtv_i2c()cannot be__devexitIt is referenced both from
__devinitcode (ivtv_probe) and normal .text (ivtv_process_eeprom), and therefore cannot be discarded via__devexit.
Good catch!
Signed-off-by Hans Verkuil <[email protected]>
Thanks,
Hans
Quoted 33 lines
Signed-off-by David S. Miller <[email protected]>--- drivers/media/video/ivtv/ivtv-i2c.c | 2 +- drivers/media/video/ivtv/ivtv-i2c.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/media/video/ivtv/ivtv-i2c.cindex 285fca6..623eea2 100644drivers/media/video/ivtv/ivtv-i2c.c +1
-1@@ -741,7 +741,7 @@ int __devinit init_ivtv_i2c(struct ivtv *itv)return i2c_bit_add_bus (&itv->i2c_adap); } -void __devexit exit_ivtv_i2c(struct ivtv *itv) +void exit_ivtv_i2c (struct ivtv *itv) {IVTV_DEBUG_I2C ("i2c exit\n" );(quoted diff) +0
-0
b/drivers/media/video/ivtv/ivtv-i2c.hindex 677c329..de6a074 100644drivers/media/video/ivtv/ivtv-i2c.h +1
-1@@ -36,6 +36,6 @@ void ivtv_call_i2c_clients(struct ivtv *itv, unsigned int cmd, void *arg);/* init + register i2c algo-bit adapter */ int __devinit init_ivtv_i2c (struct ivtv *itv); -void __devexit exit_ivtv_i2c(struct ivtv *itv); +void exit_ivtv_i2c (struct ivtv *itv);#endif