OMAP FB drivers muck up the FB menu?

Please see below answer from Randy. Seems that it didn't find its way to the list because Randy isn't subscribed.

Randy: Thanks for explanation, investigation and patch!

Dirk

-------- Original Message --------
Subject: Re: OMAP FB drivers muck up the FB menu?
Date: Sun, 21 Oct 2007 21:55:06 -0700
From: Randy Dunlap <[email protected]>
Organization: YPO4
To: [email protected]
CC: [email protected]

[I'm having problems sending email thru oracle.com, so I'm replying from my personal account instead...]

All of the frame buffer drivers should be listed (indented) under the menu heading "Support for frame buffer devices". If I TI_OMAP board type and then view the Graphics Support menu, it looks like this:

x x [ ] Backlight & LCD device support --->
x x
x x Display device support --->
x x
x x <M> Lowlevel video output switch controls
x x
x x <*> Support for frame buffer devices
x x
x x [ ] Enable firmware EDID (NEW)
x x
x x [ ] Enable Video Mode Handling Helpers (NEW)
x x
x x [ ] Enable Tile Blitting Support (NEW)
x x
x x --- Frame buffer hardware drivers
x x
x x < > Epson S1D13XXX framebuffer support (NEW)
x x
x x < > OMAP frame buffer support (EXPERIMENTAL) (NEW)
x x
x x < > Virtual Frame Buffer support (ONLY FOR TESTING!) (NEW)
x x
x x Console display driver support --->
x x
x x [ ] Bootup logo (NEW) --->

This is usually caused by some missing config symbol(s) on the "depends on" line, but I was not able to determine the exact cause of it in this case.

Notice how OMAP is not indented like the fb drivers above it. Neither is the Virtual FB, but that's expected once a config symbol above causes a problem.

In this menu, there were also problems with PMAGB_B and with IBM_GXT4500. After those were fixed, all FB drivers except for OMAP are indented as expected. If anyone has ideas or suggestions for how to make the OMAP FB entry better, please send it.

[/me does more investigation and testing ...]

OK, I know what's happening. In drivers/video/Kconfig, these lines:

if ARCH_OMAP
source "drivers/video/omap/Kconfig"
endif

introduce a dependency on ARCH_OMAP for all config symbols in the drivers/video/omap/Kconfig file. NOTE: The construct above does NOT prevent kconfig from reading that file for all non-ARCH_OMAP architectures or platforms. It justs add a dependency. In this case that added dependency mucks up the FB menu (in not-so-technical terms).

This is easy enough to fix. Patch is attached. I'll submit it to the [email protected] list now.

[Comment from Dirk: Attachment renamed to .txt to get it properly through my mailer and into list archive]

Yes, as quoted above.

Thanks,
---
~Randy

From: Randy Dunlap <[email protected]>

Fix FB_OMAP dependencies so that the OMAP FB driver options are presented correctly.

---
 drivers/video/Kconfig      |    4 +---
 drivers/video/omap/Kconfig |    2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

@@ -1892,9 +1892,7 @@ config FB_VIRTUAL
 
 	  If unsure, say N.
 
-if ARCH_OMAP
-	source "drivers/video/omap/Kconfig"
-endif
+source "drivers/video/omap/Kconfig"
 
 source "drivers/video/backlight/Kconfig"
 source "drivers/video/display/Kconfig"

@@ -1,6 +1,6 @@
 config FB_OMAP
 	tristate "OMAP frame buffer support (EXPERIMENTAL)"
-	depends on FB
+	depends on FB && ARCH_OMAP
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT

Great, looks like this is alreay applied today in Linus' tree.

Regards,

Tony