FEC_MPC52xx_MDIO oddness.
The Kconfig for this reads..
+config FEC_MPC52xx_MDIO
+ bool "MPC52xx FEC MDIO bus driver" + depends on FEC_MPC52xx + default y + ---help--- + The MPC5200's FEC can connect to the Ethernet either with + an external MII PHY chip or 10 Mbps 7-wire interface + (Motorola? industry standard). + If your board uses an external PHY connected to FEC, enable this. + If not sure, enable. + If compiled as module, it will be called 'fec_mpc52xx_phy.ko'.
Because this is bool, it'll never be compiled as a module. Given that fec_mpc52xx_phy.c has a MODULE_LICENSE() Should this be a tristate perhaps ?
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 14 lines · Dave Jones
The
Kconfigfor this reads..(quoted diff) +11
-0+config FEC_MPC52xx_MDIO + bool "MPC52xx FEC MDIO bus driver" + depends on FEC_MPC52xx + default y + ---help--- + The MPC5200's FEC can connect to the Ethernet either with + an external MII PHY chip or 10 Mbps 7-wire interface + (Motorola? industry standard). + If your board uses an external PHY connected to FEC, enable this. + If not sure, enable. + If compiled as module, it will be called 'fec_mpc52xx_phy.ko'.
Quoted 3 lines
Because this is bool, it'll never be compiled as a module. Given that
fec_mpc52xx_phy.chas aMODULE_LICENSE()Should this be a tristate perhaps ?
It's ok, it will be compiled as module if fec driver is compiled as module, and built-in if fec is built-in.
from Makefile:
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o
endif
Yes, a bit weird, but it's best I could come up with. (fec_mdio=m and fec=y is an invalid case, that I wanted to avoid).
Domen
Quoted 5 lines
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Signature · 5 lines
Domen Puncer | Research & Development ............................................................................................. Telargo d.o.o. | Zagrebška cesta 20 | 2000 Maribor | Slovenia ............................................................................................. www.telargo.com
Quoted 22 lines · Domen Puncer
Quoted 14 lines · Dave Jones
The
Kconfigfor this reads..(quoted diff) +11
-0+config FEC_MPC52xx_MDIO + bool "MPC52xx FEC MDIO bus driver" + depends on FEC_MPC52xx + default y + ---help--- + The MPC5200's FEC can connect to the Ethernet either with + an external MII PHY chip or 10 Mbps 7-wire interface + (Motorola? industry standard). + If your board uses an external PHY connected to FEC, enable this. + If not sure, enable. + If compiled as module, it will be called 'fec_mpc52xx_phy.ko'.Quoted 3 lines
Because this is bool, it'll never be compiled as a module. Given that
fec_mpc52xx_phy.chas aMODULE_LICENSE()Should this be a tristate perhaps ?It's ok, it will be compiled as module if fec driver is compiled as module, and built-in if fec is built-in.
Quoted 8 lines
from
Makefile:
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.oendif
Yes, a bit weird, but it's best I could come up with. (fec_mdio=m and fec=y is an invalid case, that I wanted to avoid).
Could you please fix this warnings as well ?
http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/13c9d93a7afa60e2
Regards,
Gabriel
Quoted 29 lines · Gabriel C
Quoted 28 lines · Domen Puncer
Quoted 14 lines · Dave Jones
The
Kconfigfor this reads..(quoted diff) +11
-0+config FEC_MPC52xx_MDIO + bool "MPC52xx FEC MDIO bus driver" + depends on FEC_MPC52xx + default y + ---help--- + The MPC5200's FEC can connect to the Ethernet either with + an external MII PHY chip or 10 Mbps 7-wire interface + (Motorola? industry standard). + If your board uses an external PHY connected to FEC, enable this. + If not sure, enable. + If compiled as module, it will be called 'fec_mpc52xx_phy.ko'.Quoted 3 lines
Because this is bool, it'll never be compiled as a module. Given that
fec_mpc52xx_phy.chas aMODULE_LICENSE()Should this be a tristate perhaps ?It's ok, it will be compiled as module if fec driver is compiled as module, and built-in if fec is built-in.
from
Makefile:
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.oendif
Quoted 7 lines
Quoted 2 lines
Yes, a bit weird, but it's best I could come up with. (fec_mdio=m and fec=y is an invalid case, that I wanted to avoid).
Could you please fix this warnings as well ?
http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/13c9d93a7afa60e2
I saw the bug reports, but unfortunately don't have a smart idea for the solution (moving the driver into a separate Kconfig might do it), so I'm waiting for Sam's input on this.
Quoted 4 lines
Regards,
Gabriel
Signature · 5 lines
Domen Puncer | Research & Development ............................................................................................. Telargo d.o.o. | Zagrebška cesta 20 | 2000 Maribor | Slovenia ............................................................................................. www.telargo.com
Quoted 33 lines · On Wed, 31 Oct 2007 17:42:32 +0100 Domen Puncer wrote:
Quoted 32 lines · Gabriel C
Quoted 30 lines · Domen Puncer
Quoted 14 lines · Dave Jones
The
Kconfigfor this reads..(quoted diff) +11
-0+config FEC_MPC52xx_MDIO + bool "MPC52xx FEC MDIO bus driver" + depends on FEC_MPC52xx + default y + ---help--- + The MPC5200's FEC can connect to the Ethernet either with + an external MII PHY chip or 10 Mbps 7-wire interface + (Motorola? industry standard). + If your board uses an external PHY connected to FEC, enable this. + If not sure, enable. + If compiled as module, it will be called 'fec_mpc52xx_phy.ko'.Quoted 3 lines
Because this is bool, it'll never be compiled as a module. Given that
fec_mpc52xx_phy.chas aMODULE_LICENSE()Should this be a tristate perhaps ?It's ok, it will be compiled as module if fec driver is compiled as module, and built-in if fec is built-in.
from
Makefile:
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.oendif
Yes, a bit weird, but it's best I could come up with. (fec_mdio=m and fec=y is an invalid case, that I wanted to avoid).
Quoted 8 lines
Quoted 4 lines
Could you please fix this warnings as well ?
http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/13c9d93a7afa60e2
I saw the bug reports, but unfortunately don't have a smart idea for the solution (moving the driver into a separate
Kconfigmight do it), so I'm waiting for Sam's input on this.
Hi Domen,
I'd like to see what Sam says also.
Using a separate Kconfig probably won't help much since this construct:
if PPC_52xx
source "Kconfig.fec"
endif
will still be read/parsed by kconfig software. I.e., the "if" line just adds a dependency to the config symbols in Kconfig.fec. It does not keep the file from being read/parsed.
---
~Randy
Quoted 31 lines · Domen Puncer
Quoted 30 lines · Gabriel C
Quoted 29 lines · Domen Puncer
Quoted 14 lines · Dave Jones
The
Kconfigfor this reads..(quoted diff) +11
-0+config FEC_MPC52xx_MDIO + bool "MPC52xx FEC MDIO bus driver" + depends on FEC_MPC52xx + default y + ---help--- + The MPC5200's FEC can connect to the Ethernet either with + an external MII PHY chip or 10 Mbps 7-wire interface + (Motorola? industry standard). + If your board uses an external PHY connected to FEC, enable this. + If not sure, enable. + If compiled as module, it will be called 'fec_mpc52xx_phy.ko'.Quoted 3 lines
Because this is bool, it'll never be compiled as a module. Given that
fec_mpc52xx_phy.chas aMODULE_LICENSE()Should this be a tristate perhaps ?It's ok, it will be compiled as module if fec driver is compiled as module, and built-in if fec is built-in.
from
Makefile:
obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.oendif
Yes, a bit weird, but it's best I could come up with. (fec_mdio=m and fec=y is an invalid case, that I wanted to avoid).
Quoted 8 lines
Quoted 4 lines
Could you please fix this warnings as well ?
http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/13c9d93a7afa60e2
I saw the bug reports, but unfortunately don't have a smart idea for the solution (moving the driver into a separate
Kconfigmight do it), so I'm waiting for Sam's input on this.
Added Sam and Adrian to CC , maybe Adrian knows some trick for this select stuff as well.