Skip to contentSkip to conversation

Adjustments of the ccid-4 copyright and kernel module authors

PATCH In review Leandro 5 participants 7 messages Oct 31, 2007 – Nov 8, 2007

lore
Share & tools
lore

Leandro

author
#0 lore raw

PATCH 3/25 Adjustments of the ccid-4 copyright and kernel module authors

[CCID-4] Adjustments of the ccid-4 copyright and kernel module authors

Signed-off-by Leandro Melo de Sales <[email protected]>
Signed-off-by Tommi Saviranta <[email protected]>

Index: leandro.new/net/dccp/ccids/ccid4.c =================================--- leandro.new.orig/net/dccp/ccids/ccid4.c +++ leandro.new/net/dccp/ccids/ccid4.c
@@ -1,14 +1,26 @@
/*
* net/dccp/ccids/ccid4.c
*

+ *  Copyright (c) 2007   Federal University of Campina Grande, Paraiba, BR.
+ *  Copyright (c) 2007   University of Helsinki, Finland.
  *  Copyright (c) 2007   The University of Aberdeen, Scotland, UK
  *  Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.
- *  Copyright (c) 2005-7 Ian McDonald <[email protected]>

*
* An implementation of the DCCP protocol
*
- * This code has been developed by the University of Waikato WAND
+ * Copyrithg (c) 2007 Leandro Sales, Tommi Saviranta
+ *

+ *  This code has been developed by the Federal University of Campina Grande
+ *  Embedded Systems and Pervasive Computing Lab and the Department of Computer
+ *  Science at the University of Helsinki. For further information please see
+ *  http://embedded.ufcg.edu.br/ <[email protected]>
+ *  http://www.iki.fi/ <[email protected]>
+ *
+ *  Copyrithg (c) 2005-7 Ian McDonald
+ *
+ *  This code is based on code developed by the University of Waikato WAND
  *  research group. For further information please see http://www.wand.net.nz/
+ *  or e-mail Ian McDonald - [email protected]

*
* This code also uses code from Lulea University, rereleased as GPL by its
* authors:
@@ -960,8 +972,8 @@ static __exit void ccid4_module_exit(voi
}
module_exit(ccid4_module_exit);

-MODULE_AUTHOR("Ian McDonald <[email protected]>, "
- "Arnaldo Carvalho de Melo <[email protected]>");
+MODULE_AUTHOR("Leandro Melo de Sales <[email protected]>, "
+ "Tommi Saviranta <[email protected]>");
MODULE_DESCRIPTION("DCCP TFRC CCID4 CCID"); MODULE_LICENSE("GPL");
MODULE_ALIAS("net-dccp-ccid-4");
Index: leandro.new/net/dccp/ccids/ccid4.h =================================--- leandro.new.orig/net/dccp/ccids/ccid4.h +++ leandro.new/net/dccp/ccids/ccid4.h
@@ -1,14 +1,26 @@
#ifndef _DCCP_CCID4_H_
#define _DCCP_CCID4_H_
/*
- * net/dccp/ccids/ccid4.h
+ * net/dccp/ccids/ccid4.c
*

+ *  Copyright (c) 2007   Federal University of Campina Grande, Paraiba, BR.
+ *  Copyright (c) 2007   University of Helsinki, Finland.
  *  Copyright (c) 2007   The University of Aberdeen, Scotland, UK
  *  Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.

*
* An implementation of the DCCP protocol
*
- * This code has been developed by the University of Waikato WAND
+ * Copyrithg (c) 2007 Leandro Sales, Tommi Saviranta
+ *

+ *  This code has been developed by the Federal University of Campina Grande
+ *  Embedded Systems and Pervasive Computing Lab and the Department of Computer
+ *  Science at the University of Helsinki. For further information please see
+ *  http://embedded.ufcg.edu.br/ <[email protected]>
+ *  http://www.iki.fi/ <[email protected]>
+ *
+ *  Copyrithg (c) 2005-7 Ian McDonald
+ *
+ *  This code is based on code developed by the University of Waikato WAND
  *  research group. For further information please see http://www.wand.net.nz/
  *  or e-mail Ian McDonald - [email protected]

*

#1 lore raw

Re: [PATCH 3/25] Adjustments of the ccid-4 copyright and kernel

Quoted 9 lines · Leandro

[CCID-4] Adjustments of the ccid-4 copyright and kernel module authors

Signed-off-by Leandro Melo de Sales <[email protected]>
Signed-off-by Tommi Saviranta <[email protected]>

Index: leandro.new/net/dccp/ccids/ccid4.h =================================> --- leandro.new.orig/net/dccp/ccids/ccid4.h +++ leandro.new/net/dccp/ccids/ccid4.h

Review line 4

Quoted 5 lines
(quoted diff) +1 -1
@@ -1,14 +1,26 @@
 #ifndef _DCCP_CCID4_H_
 #define _DCCP_CCID4_H_
 /*
- *  net/dccp/ccids/ccid4.h
+ *  net/dccp/ccids/ccid4.c

Is this intentional? ccid2.h and ccid3.h both have ccidX.h.

#2 lore raw

Re: [PATCH 3/25] Adjustments of the ccid-4 copyright and kernel

In reply to Leandro

Em Thu, Nov 01, 2007 at 02:22:49PM +0200, Tommi Saviranta escreveu:

Quoted 6 lines · Leandro
Quoted 5 lines

[CCID-4] Adjustments of the ccid-4 copyright and kernel module authors

Signed-off-by Leandro Melo de Sales <[email protected]>
Signed-off-by Tommi Saviranta <[email protected]>
Quoted 11 lines

Review line 4

Quoted 9 lines

Index: leandro.new/net/dccp/ccids/ccid4.h =================================> > --- leandro.new.orig/net/dccp/ccids/ccid4.h +++ leandro.new/net/dccp/ccids/ccid4.h

(quoted diff) +1 -1
@@ -1,14 +1,26 @@
 #ifndef _DCCP_CCID4_H_
 #define _DCCP_CCID4_H_
 /*
- *  net/dccp/ccids/ccid4.h
+ *  net/dccp/ccids/ccid4.c

Is this intentional? ccid2.h and ccid3.h both have ccidX.h.

I suggest just removing the file name altogether. Dave Jones has been doing this and I agree with him that the names in these files are not useful.

- Arnaldo

#3 lore raw

Re: [PATCH 3/25] Adjustments of the ccid-4 copyright and kernel

In reply to Leandro
Quoted 10 lines · Arnaldo Carvalho de Melo

Em Thu, Nov 01, 2007 at 02:22:49PM +0200, Tommi Saviranta escreveu:

Quoted 5 lines · Leandro
Quoted 2 lines

- * net/dccp/ccids/ccid4.h
+ * net/dccp/ccids/ccid4.c

Is this intentional? ccid2.h and ccid3.h both have ccidX.h.

I suggest just removing the file name altogether. Dave Jones has been doing this and I agree with him that the names in these files are not useful.

Agreed.

author
#4 lore raw
In reply to Leandro

2007/11/1, Tommi Saviranta <[email protected]>:

Quoted 6 lines · Arnaldo Carvalho de Melo
Quoted 5 lines

Em Thu, Nov 01, 2007 at 02:22:49PM +0200, Tommi Saviranta escreveu:

Quoted 4 lines · Leandro
Quoted 2 lines

- * net/dccp/ccids/ccid4.h
+ * net/dccp/ccids/ccid4.c

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Is this intentional? ccid2.h and ccid3.h both have ccidX.h.

I suggest just removing the file name altogether. Dave Jones has been doing this and I agree with him that the names in these files are not useful.

Agreed.

It was not intentional, it was a wrong copy & paste operation, and I already notice this, but I didn't want to release a patch just to fix this, then I fix and when I provide new changes, I would include this one, but since Arnaldo mentioned that this can be removed, and you agreed, I will remove it in the next patch set.

[]s
Leandro.

#5 lore raw
In reply to Leandro
Quoted 1 line · Leandro

+ * Copyrithg (c) 2007 Leandro Sales, Tommi Saviranta

Misspelling of copyright - this has been done several times in this patch.

Signature · 3 lines
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz
#6 lore raw
In reply to Leandro

Quoting Ian McDonald:

| > + *  Copyrithg (c) 2007 Leandro Sales, Tommi Saviranta
| 
| Misspelling of copyright - this has been done several times in this patch.

I have done s/Copyrithg/Copyright/g here.

If you want to take out the filenames in the comments as well, as suggested by Arnaldo/Tommi, email me. Otherwise, I'll just wait for new patches.

Gerrit