the scheduled I2C RTC driver removal
PATCH 1/1 the scheduled I2C RTC driver removal
This patch contains the scheduled removal of legacy I2C RTC drivers with replacement drivers.
---
Documentation/feature-removal-schedule.txt | 7 arch/powerpc/platforms/83xx/mpc832x_mds.c | 24 - arch/powerpc/platforms/83xx/mpc834x_mds.c | 24 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 24 - arch/ppc/platforms/83xx/mpc834x_sys.c | 20 - arch/ppc/platforms/85xx/tqm85xx.c | 21 - arch/ppc/platforms/katana.c | 21 - drivers/i2c/chips/Kconfig | 38 - drivers/i2c/chips/Makefile | 3 drivers/i2c/chips/ds1337.c | 410 -------------------- drivers/i2c/chips/ds1374.c | 267 ------------- drivers/i2c/chips/m41t00.c | 413 --------------------- include/linux/m41t00.h | 50 -- 13 files changed, 1322 deletions(-)
bf858b44b3071082be3aaf71e2d46ddb26415247
Documentation/feature-removal-schedule.txt +0 -7
@@ -275,13 +275,6 @@ Who: Tejun Heo <[email protected]> --------------------------- -What: Legacy RTC drivers (under drivers/i2c/chips) -When: November 2007 -Why: Obsolete. We have a RTC subsystem with better drivers. -Who: Jean Delvare <[email protected]> - ---------------------------- - What: iptables SAME target When: 1.1. 2008 Files: net/ipv4/netfilter/ipt_SAME.c, include/linux/netfilter_ipv4/ipt_SAME.h
arch/powerpc/platforms/83xx/mpc832x_mds.c +0 -24
@@ -145,30 +145,6 @@ static void __init mpc832x_sys_init_IRQ(void)#endif /* CONFIG_QUICC_ENGINE */ } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init mpc832x_rtc_hookup (void ) -{ -struct timespec tv; - -if (!machine_is (mpc832x_mds)) -return 0 ; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time) (); -do_settimeofday (&tv); - -return 0 ; -} - -late_initcall (mpc832x_rtc_hookup); -#endif -/* * Called very early, MMU is off, device-tree isn't unflattened */
arch/powerpc/platforms/83xx/mpc834x_mds.c +0 -24
@@ -106,30 +106,6 @@ static void __init mpc834x_mds_init_IRQ(void)ipic_set_default_priority (); } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init mpc834x_rtc_hookup (void ) -{ -struct timespec tv; - -if (!machine_is (mpc834x_mds)) -return 0 ; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time) (); -do_settimeofday (&tv); - -return 0 ; -} - -late_initcall (mpc834x_rtc_hookup); -#endif -/* * Called very early, MMU is off, device-tree isn't unflattened */
arch/powerpc/platforms/83xx/mpc836x_mds.c +0 -24
@@ -152,30 +152,6 @@ static void __init mpc836x_mds_init_IRQ(void)#endif /* CONFIG_QUICC_ENGINE */ } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init mpc8360_rtc_hookup (void ) -{ -struct timespec tv; - -if (!machine_is (mpc836x_mds)) -return 0 ; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time) (); -do_settimeofday (&tv); - -return 0 ; -} - -late_initcall (mpc8360_rtc_hookup); -#endif -/* * Called very early, MMU is off, device-tree isn't unflattened */
arch/ppc/platforms/83xx/mpc834x_sys.c +0 -20
@@ -224,26 +224,6 @@ mpc834x_sys_init_IRQ(void)ipic_set_default_priority (); } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init -mpc834x_rtc_hookup (void ) -{ -struct timespec tv; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time)(); -do_settimeofday (&tv); - -return 0 ; -} -late_initcall (mpc834x_rtc_hookup); -#endif static __inline__void mpc834x_sys_set_bat (void ) {
arch/ppc/platforms/85xx/tqm85xx.c +0 -21
@@ -258,27 +258,6 @@ int tqm85xx_show_cpuinfo(struct seq_file *m)return 0 ; } -#if defined(CONFIG_I2C ) && defined(CONFIG_SENSORS_DS1337 ) -extern ulong ds1337_get_rtc_time (void ); -extern int ds1337_set_rtc_time (unsigned long nowtime); - -static int __init -tqm85xx_rtc_hookup (void ) -{ -struct timespec tv; - - ppc_md.set_rtc_time = ds1337_set_rtc_time; - ppc_md.get_rtc_time = ds1337_get_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time)(); -do_settimeofday (&tv); - -return 0 ; -} -late_initcall (tqm85xx_rtc_hookup); -#endif -#ifdef CONFIG_PCI /* * interrupt routing
arch/ppc/platforms/katana.c +0 -21
@@ -838,27 +838,6 @@ katana_find_end_of_memory(void)return bdp->bi_memsize; } -#if defined(CONFIG_I2C_MV64XXX ) && defined(CONFIG_SENSORS_M41T00 ) -extern ulong m41t00_get_rtc_time (void ); -extern int m41t00_set_rtc_time (ulong ); - -static int __init -katana_rtc_hookup (void ) -{ -struct timespec tv; - - ppc_md.get_rtc_time = m41t00_get_rtc_time; - ppc_md.set_rtc_time = m41t00_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time)(); -do_settimeofday (&tv); - -return 0 ; -} -late_initcall (katana_rtc_hookup); -#endif -#if defined(CONFIG_SERIAL_TEXT_DEBUG ) && defined(CONFIG_SERIAL_MPSC_CONSOLE )static void __init katana_map_io (void )
drivers/i2c/chips/Kconfig +0 -38
@@ -4,32 +4,6 @@ menu "Miscellaneous I2C Chip support" -config SENSORS_DS1337 - tristate "Dallas DS1337 and DS1339 Real Time Clock (DEPRECATED)" - depends on EXPERIMENTAL - help - If you say yes here you get support for Dallas Semiconductor - DS1337 and DS1339 real-time clock chips. - - This driver can also be built as a module. If so, the module - will be called ds1337. - - This driver is deprecated and will be dropped soon. Use - rtc-ds1307 instead. - -config SENSORS_DS1374 - tristate "Dallas DS1374 Real Time Clock (DEPRECATED)" - depends on EXPERIMENTAL - help - If you say yes here you get support for Dallas Semiconductor - DS1374 real-time clock chips. - - This driver can also be built as a module. If so, the module - will be called ds1374. - - This driver is deprecated and will be dropped soon. Use - rtc-ds1374 instead. - config DS1682 tristate "Dallas DS1682 Total Elapsed Time Recorder with Alarm" depends on EXPERIMENTAL
@@ -116,18 +90,6 @@ config TPS65010 This driver can also be built as a module. If so, the module will be called tps65010. -config SENSORS_M41T00 - tristate "ST M41T00 RTC chip (DEPRECATED)" - depends on PPC32 - help - If you say yes here you get support for the ST M41T00 RTC chip. - - This driver can also be built as a module. If so, the module - will be called m41t00. - - This driver is deprecated and will be dropped soon. Use - rtc-ds1307 or rtc-m41t80 instead. - config SENSORS_MAX6875 tristate "Maxim MAX6875 Power supply supervisor" depends on EXPERIMENTAL
drivers/i2c/chips/Makefile +0 -3
@@ -2,12 +2,9 @@ # Makefile for miscellaneous I2C chip drivers. # -obj-$(CONFIG_SENSORS_DS1337) += ds1337.o -obj-$(CONFIG_SENSORS_DS1374) += ds1374.o obj-$(CONFIG_DS1682) += ds1682.o obj-$(CONFIG_SENSORS_EEPROM) += eeprom.o obj-$(CONFIG_SENSORS_MAX6875) += max6875.o -obj-$(CONFIG_SENSORS_M41T00) += m41t00.o obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
drivers/i2c/chips/ds1337.c deleted +0 -410
410 lines not on this page · raw message
drivers/i2c/chips/ds1374.c deleted +0 -267
267 lines not on this page · raw message
drivers/i2c/chips/m41t00.c deleted +0 -413
413 lines not on this page · raw message
include/linux/m41t00.h deleted +0 -50
50 lines not on this page · raw message
Hi Adrian,
Quoted 2 lines · Adrian Bunk
This patch contains the scheduled removal of legacy I2C RTC drivers with replacement drivers.
I'm adding the rtc list in Cc.
Quoted 5 lines
Signed-off-by Adrian Bunk <[email protected]>---
Quoted 14 lines
Documentation/feature-removal-schedule.txt | 7 arch/powerpc/platforms/83xx/mpc832x_mds.c | 24 - arch/powerpc/platforms/83xx/mpc834x_mds.c | 24 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 24 - arch/ppc/platforms/83xx/mpc834x_sys.c | 20 - arch/ppc/platforms/85xx/tqm85xx.c | 21 - arch/ppc/platforms/katana.c | 21 - drivers/i2c/chips/Kconfig | 38 - drivers/i2c/chips/Makefile | 3 drivers/i2c/chips/ds1337.c | 410 -------------------- drivers/i2c/chips/ds1374.c | 267 ------------- drivers/i2c/chips/m41t00.c | 413 --------------------- include/linux/m41t00.h | 50 -- 13 files changed, 1322 deletions(-)
Obviously we're not yet ready to remove the drivers, as some platforms still use them! The remaining platforms need to be updated to use the new RTC drivers first. The mapping is as follows:
chip | old driver | new driver |
-----------+------------+--------------+
DS1337 | ds1337 | rtc-ds1307 | DS1339 | ds1337 | rtc-ds1307 | DS1374 | ds1374 | rtc-ds1374 | M41T00 | m41t00 | rtc-ds1307 | M41T81 | m41t00 | rtc-m41t80 | M41ST85 | m41t00 | rtc-m41t80 |
So, PPC people, please update your platform code to make use of the new drivers now, and let me know when you're done. As soon as all platforms are converted, I'll apply Adrian's patch.
Thanks.
Quoted 294 lines
bf858b44b3071082be3aaf71e2d46ddb26415247Documentation/feature-removal-schedule.txt +0
-7@@ -275,13 +275,6 @@ Who: Tejun Heo <[email protected]> --------------------------- -What: Legacy RTC drivers (under drivers/i2c/chips) -When: November 2007 -Why: Obsolete. We have a RTC subsystem with better drivers. -Who: Jean Delvare <[email protected]> - ---------------------------- - What: iptables SAME target When: 1.1. 2008 Files: net/ipv4/netfilter/ipt_SAME.c, include/linux/netfilter_ipv4/ipt_SAME.harch/powerpc/platforms/83xx/mpc832x_mds.c +0
-24@@ -145,30 +145,6 @@ static void __init mpc832x_sys_init_IRQ(void)#endif /* CONFIG_QUICC_ENGINE */ } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init mpc832x_rtc_hookup (void ) -{ -struct timespec tv; - -if (!machine_is (mpc832x_mds)) -return 0 ; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time) (); -do_settimeofday (&tv); - -return 0 ; -} - -late_initcall (mpc832x_rtc_hookup); -#endif -/* * Called very early, MMU is off, device-tree isn't unflattened */ arch/powerpc/platforms/83xx/mpc834x_mds.c +0
-24@@ -106,30 +106,6 @@ static void __init mpc834x_mds_init_IRQ(void)ipic_set_default_priority (); } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init mpc834x_rtc_hookup (void ) -{ -struct timespec tv; - -if (!machine_is (mpc834x_mds)) -return 0 ; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time) (); -do_settimeofday (&tv); - -return 0 ; -} - -late_initcall (mpc834x_rtc_hookup); -#endif -/* * Called very early, MMU is off, device-tree isn't unflattened */ arch/powerpc/platforms/83xx/mpc836x_mds.c +0
-24@@ -152,30 +152,6 @@ static void __init mpc836x_mds_init_IRQ(void)#endif /* CONFIG_QUICC_ENGINE */ } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init mpc8360_rtc_hookup (void ) -{ -struct timespec tv; - -if (!machine_is (mpc836x_mds)) -return 0 ; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time) (); -do_settimeofday (&tv); - -return 0 ; -} - -late_initcall (mpc8360_rtc_hookup); -#endif -/* * Called very early, MMU is off, device-tree isn't unflattened */ arch/ppc/platforms/83xx/mpc834x_sys.c +0
-20@@ -224,26 +224,6 @@ mpc834x_sys_init_IRQ(void)ipic_set_default_priority (); } -#if defined(CONFIG_I2C_MPC ) && defined(CONFIG_SENSORS_DS1374 ) -extern ulong ds1374_get_rtc_time (void ); -extern int ds1374_set_rtc_time (ulong ); - -static int __init -mpc834x_rtc_hookup (void ) -{ -struct timespec tv; - - ppc_md.get_rtc_time = ds1374_get_rtc_time; - ppc_md.set_rtc_time = ds1374_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time)(); -do_settimeofday (&tv); - -return 0 ; -} -late_initcall (mpc834x_rtc_hookup); -#endif static __inline__void mpc834x_sys_set_bat (void ) {arch/ppc/platforms/85xx/tqm85xx.c +0
-21@@ -258,27 +258,6 @@ int tqm85xx_show_cpuinfo(struct seq_file *m)return 0 ; } -#if defined(CONFIG_I2C ) && defined(CONFIG_SENSORS_DS1337 ) -extern ulong ds1337_get_rtc_time (void ); -extern int ds1337_set_rtc_time (unsigned long nowtime); - -static int __init -tqm85xx_rtc_hookup (void ) -{ -struct timespec tv; - - ppc_md.set_rtc_time = ds1337_set_rtc_time; - ppc_md.get_rtc_time = ds1337_get_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time)(); -do_settimeofday (&tv); - -return 0 ; -} -late_initcall (tqm85xx_rtc_hookup); -#endif -#ifdef CONFIG_PCI /* * interrupt routing arch/ppc/platforms/katana.c +0
-21@@ -838,27 +838,6 @@ katana_find_end_of_memory(void)return bdp->bi_memsize; } -#if defined(CONFIG_I2C_MV64XXX ) && defined(CONFIG_SENSORS_M41T00 ) -extern ulong m41t00_get_rtc_time (void ); -extern int m41t00_set_rtc_time (ulong ); - -static int __init -katana_rtc_hookup (void ) -{ -struct timespec tv; - - ppc_md.get_rtc_time = m41t00_get_rtc_time; - ppc_md.set_rtc_time = m41t00_set_rtc_time; - - tv.tv_nsec =0 ; - tv.tv_sec = (ppc_md.get_rtc_time)(); -do_settimeofday (&tv); - -return 0 ; -} -late_initcall (katana_rtc_hookup); -#endif -#if defined(CONFIG_SERIAL_TEXT_DEBUG ) && defined(CONFIG_SERIAL_MPSC_CONSOLE )static void __init katana_map_io (void )drivers/i2c/chips/Kconfig +0
-38@@ -4,32 +4,6 @@ menu "Miscellaneous I2C Chip support" -config SENSORS_DS1337 - tristate "Dallas DS1337 and DS1339 Real Time Clock (DEPRECATED)" - depends on EXPERIMENTAL - help - If you say yes here you get support for Dallas Semiconductor - DS1337 and DS1339 real-time clock chips. - - This driver can also be built as a module. If so, the module - will be called ds1337. - - This driver is deprecated and will be dropped soon. Use - rtc-ds1307 instead. - -config SENSORS_DS1374 - tristate "Dallas DS1374 Real Time Clock (DEPRECATED)" - depends on EXPERIMENTAL - help - If you say yes here you get support for Dallas Semiconductor - DS1374 real-time clock chips. - - This driver can also be built as a module. If so, the module - will be called ds1374. - - This driver is deprecated and will be dropped soon. Use - rtc-ds1374 instead. - config DS1682 tristate "Dallas DS1682 Total Elapsed Time Recorder with Alarm" depends on EXPERIMENTAL@@ -116,18 +90,6 @@ config TPS65010 This driver can also be built as a module. If so, the module will be called tps65010. -config SENSORS_M41T00 - tristate "ST M41T00 RTC chip (DEPRECATED)" - depends on PPC32 - help - If you say yes here you get support for the ST M41T00 RTC chip. - - This driver can also be built as a module. If so, the module - will be called m41t00. - - This driver is deprecated and will be dropped soon. Use - rtc-ds1307 or rtc-m41t80 instead. - config SENSORS_MAX6875 tristate "Maxim MAX6875 Power supply supervisor" depends on EXPERIMENTALdrivers/i2c/chips/Makefile +0
-3@@ -2,12 +2,9 @@ # Makefile for miscellaneous I2C chip drivers. # -obj-$(CONFIG_SENSORS_DS1337) += ds1337.o -obj-$(CONFIG_SENSORS_DS1374) += ds1374.o obj-$(CONFIG_DS1682) += ds1682.o obj-$(CONFIG_SENSORS_EEPROM) += eeprom.o obj-$(CONFIG_SENSORS_MAX6875) += max6875.o -obj-$(CONFIG_SENSORS_M41T00) += m41t00.o obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
Signature · 1 line
Jean Delvare
Quoted 34 lines · Jean Delvare
Hi Adrian,
Quoted 17 lines · Adrian Bunk
This patch contains the scheduled removal of legacy I2C RTC drivers with replacement drivers.
(...)Documentation/feature-removal-schedule.txt | 7 arch/powerpc/platforms/83xx/mpc832x_mds.c | 24 - arch/powerpc/platforms/83xx/mpc834x_mds.c | 24 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 24 - arch/ppc/platforms/83xx/mpc834x_sys.c | 20 - arch/ppc/platforms/85xx/tqm85xx.c | 21 - arch/ppc/platforms/katana.c | 21 - drivers/i2c/chips/Kconfig | 38 - drivers/i2c/chips/Makefile | 3 drivers/i2c/chips/ds1337.c | 410 -------------------- drivers/i2c/chips/ds1374.c | 267 ------------- drivers/i2c/chips/m41t00.c | 413 --------------------- include/linux/m41t00.h | 50 -- 13 files changed, 1322 deletions(-)Obviously we're not yet ready to remove the drivers, as some platforms still use them! The remaining platforms need to be updated to use the new RTC drivers first. The mapping is as follows:
chip | old driver | new driver |
-----------+------------+--------------+DS1337 | ds1337 | rtc-ds1307 | DS1339 | ds1337 | rtc-ds1307 | DS1374 | ds1374 | rtc-ds1374 | M41T00 | m41t00 | rtc-ds1307 | M41T81 | m41t00 | rtc-m41t80 | M41ST85 | m41t00 | rtc-m41t80 |
Quoted 3 lines
So, PPC people, please update your platform code to make use of the new drivers now, and let me know when you're done. As soon as all platforms are converted, I'll apply Adrian's patch.
As of 2.6.24-rc3-git2, I see that the references to the obsolete drivers have been removed from arch/powerpc/*. Great, I'll update Adrian's patch. This leaves only 3 platforms under arch/ppc (83xx, 85xx and katana) that still need updating. Kumar, Paul, what's the status?
Thanks,
Signature · 1 line
Jean Delvare