NFSD: Use unsigned length argument for decode_filename
Subsystems (2)
PATCH 3/8 NFSD: Use unsigned length argument for decode_filename
Clean up: file name lengths are unsigned on the wire, negative lengths are not meaningful natively either.
Signed-off-by Chuck Lever <[email protected]>
---
fs/nfsd/nfs3xdr.c | 4 ++-- fs/nfsd/nfsxdr.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
fs/nfsd/nfs3xdr.c +2 -2
@@ -88,10 +88,10 @@ encode_fh(__be32 *p, struct svc_fh *fhp)* no slashes or null bytes. */ static __be32 * -decode_filename (__be32 *p,char **namp,int *lenp) +decode_filename (__be32 *p,char **namp,unsigned int *lenp) {char *name; -int i; +unsigned int i;if ((p =xdr_decode_string_inplace (p, namp, lenp,NFS3_MAXNAMLEN )) !=NULL ) {for (i =0 , name = *namp; i < *lenp; i++, name++) {
fs/nfsd/nfsxdr.c +2 -2
@@ -62,10 +62,10 @@ encode_fh(__be32 *p, struct svc_fh *fhp)* no slashes or null bytes. */ static __be32 * -decode_filename (__be32 *p,char **namp,int *lenp) +decode_filename (__be32 *p,char **namp,unsigned int *lenp) {char *name; -int i; +unsigned int i;if ((p =xdr_decode_string_inplace (p, namp, lenp,NFS_MAXNAMLEN )) !=NULL ) {for (i =0 , name = *namp; i < *lenp; i++, name++) {
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs