Skip to contentSkip to conversation

proper prototype for kernel/sched.c:migration_init()

PATCH New Adrian Bunk 1 participant 1 message Nov 2, 2007 Scheduler

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 proper prototype for kernel/sched.c:migration_init()

This patch adds a proper prototype for migration_init() in include/linux/sched.h

Since there's no point in always returning 0 to a caller that doesn't check the return value it also changes the function to return void.

Signed-off-by Adrian Bunk <[email protected]>

---

 include/linux/sched.h |    8 ++++++++
 init/main.c           |    4 +---
 kernel/sched.c        |    4 +---
 3 files changed, 10 insertions(+), 6 deletions(-)

78199d6267bc667b7508606b1ba9c1dc2a694239

include/linux/sched.h +8 -0
index 155d743..9bdc784 100644
@@ -1983,6 +1983,14 @@ static inline void inc_syscw(struct task_struct *tsk)
 }
 #endif
 
+#ifdef CONFIG_SMP
+void migration_init(void);
+#else
+static inline void migration_init(void)
+{
+}
+#endif
+
 #endif /* __KERNEL__ */
 
 #endif
init/main.c +1 -3
index f605a96..80b04b6 100644
@@ -56,6 +56,7 @@
 #include <linux/pid_namespace.h>
 #include <linux/device.h>
 #include <linux/kthread.h>
+#include <linux/sched.h>
 
 #include <asm/io.h>
 #include <asm/bugs.h>

@@ -747,11 +748,8 @@ __setup("nosoftlockup", nosoftlockup_setup);
 static void __init do_pre_smp_initcalls(void)
 {
 	extern int spawn_ksoftirqd(void);
-#ifdef CONFIG_SMP
-	extern int migration_init(void);
 
 	migration_init();
-#endif
 	spawn_ksoftirqd();
 	if (!nosoftlockup)
 		spawn_softlockup_task();
kernel/sched.c +1 -3
index 3f6bd11..2f8b4e7 100644
@@ -5621,7 +5621,7 @@ static struct notifier_block __cpuinitdata migration_notifier = {
 	.priority = 10
 };
 
-int __init migration_init(void)
+void __init migration_init(void)
 {
 	void *cpu = (void *)(long)smp_processor_id();
 	int err;

@@ -5631,8 +5631,6 @@ int __init migration_init(void)
 	BUG_ON(err == NOTIFY_BAD);
 	migration_call(&migration_notifier, CPU_ONLINE, cpu);
 	register_cpu_notifier(&migration_notifier);
-
-	return 0;
 }
 #endif