minor clean-ups for ondemand governor

PATCH New Mark Langsdorf 1 participant 1 message Nov 2, 2007 CPU frequency scaling framework

Share & tools

Mark Langsdorf

author

2007-11-02 21:28 UTC #0 lore raw

PATCH 1/1 minor clean-ups for ondemand governor

The cpufreq ondemand governor patch for Xen included some out of order code and some test code; re-order the code to assign a variable before passing it to a function and remove the test code.

Signed-off-by Mark Langsdorf <[email protected]>

drivers/cpufreq/cpufreq_ondemand.c +5 -3

diff -r d827dfc6593e drivers/cpufreq/cpufreq_ondemand.c
@@ -96,6 +96,7 @@ static inline cputime64_t get_cpu_idle_t
 	return retval;
 }
 
+
 /************************** sysfs interface ************************/
 static ssize_t show_sampling_rate_max(struct cpufreq_policy *policy, char *buf)
 {

@@ -281,15 +282,16 @@ static int dbs_calc_load(struct cpu_dbs_
 	unsigned int j;
 	cpumask_t cpumap;
 
+	policy = this_dbs_info->cur_policy;
+	cpumap = policy->cpus;
+
 	op.cmd = XENPF_getidletime;
 	set_xen_guest_handle(op.u.getidletime.cpumap_bitmap, (uint8_t *) cpus_addr(cpumap));
-	op.u.getidletime.cpumap_nr_cpus = NR_CPUS;// num_online_cpus();
+	op.u.getidletime.cpumap_nr_cpus = NR_CPUS;
 	set_xen_guest_handle(op.u.getidletime.idletime, idletime);
 	if (HYPERVISOR_platform_op(&op))
 		return 200;
 
-	policy = this_dbs_info->cur_policy;
-	cpumap = policy->cpus;
 	for_each_cpu_mask(j, cpumap) {
 		cputime64_t total_idle_nsecs, tmp_idle_nsecs;
 		cputime64_t total_wall_nsecs, tmp_wall_nsecs;