Skip to contentSkip to conversation

9p: basic sysfs support

PATCH In review Latchesar Ionkov 2 participants 4 messages Nov 2, 2007 – Nov 3, 2007

Subsystems (3)
lore
Share & tools
lore

Latchesar Ionkov

author maintainer
#0 lore raw

PATCH 1/1 9p: basic sysfs support

This patch implements the basic sysfs support for 9p. If CONFIG_NET_9P_DEBUG is defined, allows reading and modifying the debug level via /sysfs/fs/9p/debuglevel.

---
 include/net/9p/9p.h |    1 +
 net/9p/mod.c        |   45 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 0 deletions(-)
include/net/9p/9p.h +1 -0
index 686425a..9ace484 100644
@@ -377,6 +377,7 @@ struct p9_fcall {
 };
 
 struct p9_idpool;
+extern struct kset p9_subsys;
 
 int p9_deserialize_stat(void *buf, u32 buflen, struct p9_stat *stat,
 	int dotu);
net/9p/mod.c +45 -0

77 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · Latchesar Ionkov

This patch implements the basic sysfs support for 9p. If CONFIG_NET_9P_DEBUG is defined, allows reading and modifying the debug level via /sysfs/fs/9p/debuglevel.

Since this is a debug-only type file, why not just put it in debugfs instead?

And I have a huge patch-series pending that will make adding files like this to sysfs much easier in the future. But nice job, it looks like you got it all correct, which is pretty hard to do first time these days due to the complexity of the current interface :)

thanks,

greg k-h

author maintainer
#2 lore raw

This patch adds only the basic 9p functionality, we use the sysfs interface extensively for configuring the 9p in-kernel servers (patch 7 in the series). The v9fs filesyste will probably add some more subdirectories for authenticating users and mapping user names to uids...

Thanks,
Lucho

Quoted 17 lines · Greg KH
Quoted 3 lines · Latchesar Ionkov

This patch implements the basic sysfs support for 9p. If CONFIG_NET_9P_DEBUG is defined, allows reading and modifying the debug level via /sysfs/fs/9p/debuglevel.

Since this is a debug-only type file, why not just put it in debugfs instead?

And I have a huge patch-series pending that will make adding files like this to sysfs much easier in the future. But nice job, it looks like you got it all correct, which is pretty hard to do first time these days due to the complexity of the current interface :)

thanks,

greg k-h

#3 lore raw
Quoted 5 lines · Latchesar Ionkov

This patch adds only the basic 9p functionality, we use the sysfs interface extensively for configuring the 9p in-kernel servers (patch 7 in the series). The v9fs filesyste will probably add some more subdirectories for authenticating users and mapping user names to uids...

Ah, ok. I don't know your projected time frame for this patch series, but if it's for 2.6.25, you might want to look at the set of patches I just sent to lkml to help make files like this easier to create thanks to the great work from Kay Sievers.

thanks,

greg k-h