Skip to contentSkip to conversation

2.4.24-rc1-git: crash on shutdown/unmount?

DISCUSSION Alistair John Strachan 3 participants 6 messages Oct 31, 2007 – Nov 3, 2007 1 message not in the archive Block layer

lore
Share & tools
lore
#0 lore raw

Hi Jens,

I guessed from the oops that you might have an idea what's causing this oops on shutdown/unmount. The git version (describe), a screenshot showing the oops, a config, and dmesg for a booted kernel are available from:

http://devzero.co.uk/~alistair/oops-20071031/

I went back to -rc1 and it still happens there too. If you need any more information or want me to bisect it, please let me know.

Signature · 4 lines
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.
#1 lore raw
Quoted 10 lines · Alistair John Strachan

Hi Jens,

I guessed from the oops that you might have an idea what's causing this oops on shutdown/unmount. The git version (describe), a screenshot showing the oops, a config, and dmesg for a booted kernel are available from:

http://devzero.co.uk/~alistair/oops-20071031/

I went back to -rc1 and it still happens there too. If you need any more information or want me to bisect it, please let me know.

I do, I'll post a patch shortly. Just need to test it first.

Signature · 1 line
Jens Axboe
#2 lore raw
In reply to Alistair John Strachan
Quoted 10 lines · Alistair John Strachan

Hi Jens,

I guessed from the oops that you might have an idea what's causing this oops on shutdown/unmount. The git version (describe), a screenshot showing the oops, a config, and dmesg for a booted kernel are available from:

http://devzero.co.uk/~alistair/oops-20071031/

I went back to -rc1 and it still happens there too. If you need any more information or want me to bisect it, please let me know.

Does this work for you?

block/ll_rw_blk.c +6 -1
index 54fd385..75c98d5 100644
@@ -3221,6 +3221,7 @@ static inline void __generic_make_request(struct bio *bio)
 	sector_t old_sector;
 	int ret, nr_sectors = bio_sectors(bio);
 	dev_t old_dev;
+	int err = -EIO;
 
 	might_sleep();
 
@@ -3248,7 +3249,7 @@ static inline void __generic_make_request(struct bio *bio)
 				bdevname(bio->bi_bdev, b),
 				(long long) bio->bi_sector);
 end_io:
-			bio_endio(bio, -EIO);
+			bio_endio(bio, err);
 			break;
 		}
 
@@ -3283,6 +3284,10 @@ end_io:
 
 		if (bio_check_eod(bio, nr_sectors))
 			goto end_io;
+		if (bio_empty_barrier(bio) && !q->prepare_flush_fn) {
+			err = -EOPNOTSUPP;
+			goto end_io;
+		}
 
 		ret = q->make_request_fn(q, bio);
 	} while (ret);
Signature · 1 line
Jens Axboe

A message that is not in the archive (sent off-list or not yet received): [email protected]

author Tested-by
#4 lore raw
Quoted 11 lines · On Thursday 01 November 2007 11:51:08 Sebastian Siewior wrote:
Quoted 10 lines · * Jens Axboe | 2007-11-01 11:51:09 [+0100]:
Quoted 9 lines · Alistair John Strachan

Hi Jens,

I guessed from the oops that you might have an idea what's causing this oops on shutdown/unmount. The git version (describe), a screenshot showing the oops, a config, and dmesg for a booted kernel are available from:

http://devzero.co.uk/~alistair/oops-20071031/

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

I went back to -rc1 and it still happens there too. If you need any more information or want me to bisect it, please let me know.

Does this work for you?

Yes it does.

Acked-by Sebastian Siewior <[email protected]>

Yep, thanks Jens. Working fine here.

Signature · 4 lines
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.
#5 lore raw
In reply to Jens Axboe
Quoted 7 lines · * Jens Axboe | 2007-11-01 11:51:09 [+0100]:
Quoted 6 lines · Alistair John Strachan

Hi Jens,

I guessed from the oops that you might have an idea what's causing this oops on shutdown/unmount. The git version (describe), a screenshot showing the oops, a config, and dmesg for a booted kernel are available from:

Quoted 6 lines
Quoted 4 lines

http://devzero.co.uk/~alistair/oops-20071031/

I went back to -rc1 and it still happens there too. If you need any more information or want me to bisect it, please let me know.

Does this work for you?

Yes, it does. Thanks for working on that. Sorry for the late reply but I run -ENOINET.

#6 lore raw
Quoted 11 lines · Sebastian Siewior
Quoted 9 lines · * Jens Axboe | 2007-11-01 11:51:09 [+0100]:
Quoted 8 lines · Alistair John Strachan

Hi Jens,

I guessed from the oops that you might have an idea what's causing this oops on shutdown/unmount. The git version (describe), a screenshot showing the oops, a config, and dmesg for a booted kernel are available from:

http://devzero.co.uk/~alistair/oops-20071031/

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

I went back to -rc1 and it still happens there too. If you need any more information or want me to bisect it, please let me know.

Does this work for you?

Yes, it does. Thanks for working on that. Sorry for the late reply but I run -ENOINET.

Great, thanks to both of you for testing. When Linus pulls the stuff I asked him to, this fix will go upstream.

Signature · 1 line
Jens Axboe