82596: free nonexistent resource fix

PATCH New Evgeniy Dushistov 1 participant 1 message Nov 4, 2007 Network drivers

lore

Share & tools

lore

Evgeniy Dushistov

author

2007-11-04 21:45 UTC #0 lore raw

PATCH 1/1 82596: free nonexistent resource fix

During booting of last vanilla kernel I got:
Trying to free nonexistent resource...

This because of if "ENABLE_APRICOT" is on we do:
request_region(ioaddr,...)
if (checksum test failed)
goto out1;
dev->base_addr = ioaddr;//<-here mistake

out1:
release_region(dev->base_addr,...)

Here patch which fixes this bug for me.

Signed-off-by Evgeniy Dushistov <[email protected]>

---

drivers/net/82596.c +2 -1

index bb30d5b..2797da7 100644
@@ -1192,6 +1192,8 @@ struct net_device * __init i82596_probe(int unit)
 			goto out;
 		}
 
+		dev->base_addr = ioaddr;
+
 		for (i = 0; i < 8; i++) {
 			eth_addr[i] = inb(ioaddr + 8 + i);
 			checksum += eth_addr[i];

@@ -1209,7 +1211,6 @@ struct net_device * __init i82596_probe(int unit)
 			goto out1;
 		}
 
-		dev->base_addr = ioaddr;
 		dev->irq = 10;
 	}
 #endif

Signature · 1 line

/Evgeniy