Skip to contentSkip to conversation

ide: remove redundant DMA blacklist check from __ide_dma_on()

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Nov 4, 2007 – Nov 6, 2007 libata

lore
Share & tools
lore
#0 lore raw

PATCH 18/18 ide: remove redundant DMA blacklist check from __ide_dma_on()

->ide_dma_on method is called only after successful ide_dma_check() call (ide_dma_check()->ide_tune_dma() checks DMA blacklist) or if drive->using_dma has been previously enabled for a given device (->ide_dma_on is the only place which sets drive->using_dma to '1').

There should be no functionality changes caused by this patch.

---
 drivers/ide/ide-dma.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/ide/ide-dma.c +0 -4
Index: b/drivers/ide/ide-dma.c
===================================================================
@@ -490,10 +490,6 @@ EXPORT_SYMBOL(ide_dma_host_on);
  
 int __ide_dma_on (ide_drive_t *drive)
 {
-	/* consult the list of known "bad" drives */
-	if (__ide_dma_bad_drive(drive))
-		return 1;
-
 	drive->using_dma = 1;
 	ide_toggle_bounce(drive, 1);
 
Acked-by on v1 18/18
#1 lore raw
Quoted 8 lines · Bartlomiej Zolnierkiewicz

->ide_dma_on method is called only after successful ide_dma_check() call (ide_dma_check()->ide_tune_dma() checks DMA blacklist) or if drive->using_dma has been previously enabled for a given device (->ide_dma_on is the only place which sets drive->using_dma to '1').

There should be no functionality changes caused by this patch.

MBR, Sergei