Skip to contentSkip to conversation

Makefile: Remove ncscope.out when make mrproper

PATCH In review WANG Cong 2 participants 3 messages Nov 5, 2007 Kbuild

lore
Share & tools
lore

WANG Cong

author
#0 lore raw

PATCH 1/1 Makefile: Remove ncscope.out when make mrproper

Hi, Sam!

This patch adds the ncscope.out file into cleaning targets of 'make mrproper'.

Cc Sam Ravnborg <[email protected]>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
Index: linux-2.6/Makefile
===================================================================
@@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS cscope* ncscope.out
 
 # clean - Delete most, but leave enough to build external modules
 #
#1 lore raw
Quoted 17 lines · WANG Cong

Hi, Sam!

This patch adds the ncscope.out file into cleaning targets of 'make mrproper'.

Cc Sam Ravnborg <[email protected]>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/Makefile
===================================================================

Makefile MRPROPER_DIRS += include/config include · line 1076

Quoted 5 lines
Makefile +1 -1
@@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS cscope* ncscope.out

Hi WANG.

ncscope.out is just a temporary file but I see why you like to have it covered. How about modifying the rule to look like this:

Makefile MRPROPER_DIRS += include/config include · line 1077

Quoted 2 lines
Makefile +1 -1
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS *cscope*

Or is this to broad a pattern?

Sam

author
#2 lore raw

On Mon, Nov 05, 2007 at 08:41:37AM +0100, Sam Ravnborg wrote:

<snip>

Quoted 4 lines

Hi WANG.

ncscope.out is just a temporary file but I see why you like to have it covered.

Thanks. ;)

Quoted 7 lines

How about modifying the rule to look like this:

Review

Quoted 2 lines
(quoted diff) +1 -1
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS *cscope*

Or is this to broad a pattern?

Sam

Yes, that is better. New patch below.

---

Makefile +1 -1
Index: linux-2.6/Makefile
===================================================================
@@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS *cscope*
 
 # clean - Delete most, but leave enough to build external modules
 #