Skip to contentSkip to conversation

iounmap if in vr41xx_pciu_init() pci clock is over 33MHz

PATCH Applied Roel Kluin 3 participants 3 messages Nov 4, 2007 – Nov 5, 2007 MIPS

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 iounmap if in vr41xx_pciu_init() pci clock is over 33MHz

iounmap if pci clock is over 33MHz

Signed-off-by Roel Kluin <[email protected]>

---

arch/mips/pci/pci-vr41xx.c +1 -0
index 240df9e..33c4f68 100644
@@ -154,6 +154,7 @@ static int __init vr41xx_pciu_init(void)
 		pciu_write(PCICLKSELREG, QUARTER_VTCLOCK);
 	else {
 		printk(KERN_ERR "PCI Clock is over 33MHz.\n");
+		iounmap(pciu_base);
 		return -EINVAL;
 	}
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · On Sun, 04 Nov 2007 13:00:06 +0100 Roel Kluin <[email protected]> wrote:

iounmap if pci clock is over 33MHz

Signed-off-by Roel Kluin <[email protected]>
Acked-by Yoichi Yuasa <[email protected]>
Quoted 15 lines

---

arch/mips/pci/pci-vr41xx.c +1 -0
index 240df9e..33c4f68 100644
@@ -154,6 +154,7 @@ static int __init vr41xx_pciu_init(void)
 		pciu_write(PCICLKSELREG, QUARTER_VTCLOCK);
 	else {
 		printk(KERN_ERR "PCI Clock is over 33MHz.\n");
+		iounmap(pciu_base);
 		return -EINVAL;
 	}
Applied
#2 lore raw
In reply to Roel Kluin
Quoted 1 line · Roel Kluin

iounmap if pci clock is over 33MHz

Applied. Note that this is purely cosmetic; for 64-bit kernels or anything in the low 512MB of physcial address space ioremap on a 32-bit kernel ioremap can never fail on MIPS and iounmap is a nop in this case.

Ralf