Skip to contentSkip to conversation

power_supply_{leds,sysfs}.c should #include "power_supply.h"

PATCH Applied Adrian Bunk 2 participants 2 messages Nov 5, 2007 – Nov 25, 2007

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 power_supply_{leds,sysfs}.c should #include "power_supply.h"

Every file should include the headers containing the prototypes for its global functions.

Signed-off-by Adrian Bunk <[email protected]>

---

 drivers/power/power_supply_leds.c  |    2 ++
 drivers/power/power_supply_sysfs.c |    2 ++
 2 files changed, 4 insertions(+)

e34cc994731ec9102bf5b1c7d6585c0aa87d1fa2

drivers/power/power_supply_leds.c +2 -0
index 7f8f359..80ca288 100644
@@ -12,6 +12,8 @@
 
 #include <linux/power_supply.h>
 
+#include "power_supply.h"
+
 /* Battery specific LEDs triggers. */
 
 static void power_supply_update_bat_leds(struct power_supply *psy)
drivers/power/power_supply_sysfs.c +2 -0
index 249f61b..e8ad1fd 100644
@@ -14,6 +14,8 @@
 #include <linux/ctype.h>
 #include <linux/power_supply.h>
 
+#include "power_supply.h"
+
 /*
  * This is because the name "current" breaks the device attr macro.
  * The "current" word resolves to "(get_current())" so instead of
Applied
#1 lore raw
Quoted 2 lines · Adrian Bunk

Every file should include the headers containing the prototypes for its global functions.

Applied to battery-2.6.git, thanks.

p.s.
Sorry for the delay, I've not been Cc'ed, so I've found out about that patch by pure chance (through looking in the -mm series).

Quoted 36 lines
Signed-off-by Adrian Bunk <[email protected]>

---

 drivers/power/power_supply_leds.c  |    2 ++
 drivers/power/power_supply_sysfs.c |    2 ++
 2 files changed, 4 insertions(+)

e34cc994731ec9102bf5b1c7d6585c0aa87d1fa2

drivers/power/power_supply_leds.c +2 -0
index 7f8f359..80ca288 100644
@@ -12,6 +12,8 @@
 
 #include <linux/power_supply.h>
 
+#include "power_supply.h"
+
 /* Battery specific LEDs triggers. */
 
 static void power_supply_update_bat_leds(struct power_supply *psy)
drivers/power/power_supply_sysfs.c +2 -0
index 249f61b..e8ad1fd 100644
@@ -14,6 +14,8 @@
 #include <linux/ctype.h>
 #include <linux/power_supply.h>
 
+#include "power_supply.h"
+
 /*
  * This is because the name "current" breaks the device attr macro.
  * The "current" word resolves to "(get_current())" so instead of
Signature · 4 lines
Anton Vorontsov
email: [email protected]
backup email: [email protected]
irc://irc.freenode.net/bd2