UML - Console driver cleanups
PATCH 4/6 UML - Console driver cleanups
Console driver cleanups -
Changed an instance of foo = bar + foo to foo += bar Removed checks of tty->stopped - I don't think the low-level
driver has any business looking at that
Removed an annoying warning
Signed-off-by Jeff Dike <[email protected]>
--- arch/um/drivers/line.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-)
arch/um/drivers/line.c +2 -17
@@ -48,7 +48,7 @@ static int write_room(struct line *line) n = line->head - line->tail;if (n <=0 ) - n =LINE_BUFSIZE + n;/* The other case */ + n +=LINE_BUFSIZE ;/* The other case */ return n -1 ; }
@@ -58,17 +58,10 @@ int line_write_room(struct tty_struct *tunsigned long flags;int room; -if (tty->stopped) -return 0 ; -spin_lock_irqsave (&line->lock, flags); room =write_room (line);spin_unlock_irqrestore (&line->lock, flags); -/*XXX: Warning to remove */ -if (0 == room) -printk (KERN_DEBUG "%s: %s: no room left in buffer\n" , - __FUNCTION__,tty->name);return room; }
@@ -79,8 +72,7 @@ int line_chars_in_buffer(struct tty_struint ret;spin_lock_irqsave (&line->lock, flags); - -/*write_room subtracts 1 for the needed NULL, so we readd it.*/ +/* write_room subtracts 1 for the needed NULL, so we readd it.*/ ret =LINE_BUFSIZE - (write_room (line) +1 );spin_unlock_irqrestore (&line->lock, flags);
@@ -184,10 +176,6 @@ void line_flush_buffer(struct tty_structunsigned long flags;int err; -/*XXX: copied from line_write, verify if it is correct!*/ -if (tty->stopped) -return ; -spin_lock_irqsave (&line->lock, flags); err =flush_buffer (line);spin_unlock_irqrestore (&line->lock, flags);
@@ -213,9 +201,6 @@ int line_write(struct tty_struct *tty, cunsigned long flags;int n, ret =0 ; -if (tty->stopped) -return 0 ; -spin_lock_irqsave (&line->lock, flags);if (line->head != line->tail) ret =buffer_data (line, buf, len);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel