ia64: remove per_cpu_offset()
PATCH 1/1 ia64: remove per_cpu_offset()
per_cpu_offset() was added as part of a lockdep patch, "[PATCH] lockdep: add per_cpu_offset()" (a875a69f8b00a38b4f40d9632a4fc71a159f0e0d),
but ia64 doesn't have lockdep, nor does it use per_cpu_offset() anywhere else.
This came up because Yu Lumming noticed that the ia64 version of per_cpu_offset() actually has a syntax error. Amusing as it seems to have been in the tree for months.
Review
Quoted 2 lines
(quoted diff) +1
-1-#define per_cpu_offset(x) (__per_cpu_offset(x)) +#define per_cpu_offset(x) (__per_cpu_offset[x])
Dave Miller suggested that rather than fixing the unused code it would be better to just remove it all together.
include/asm-ia64/percpu.h +0 -1
@@ -46,7 +46,6 @@#ifdef CONFIG_SMP extern unsigned long __per_cpu_offset[NR_CPUS ]; -#define per_cpu_offset (x) (__per_cpu_offset[x])/* Equal to __per_cpu_offset[smp_processor_id()], but faster to access: */ DECLARE_PER_CPU(unsigned long, local_per_cpu_offset);
NAK for now.
I'm trying to add lockdep , so please don't delete it until it could be proved really useless...
Please don't hurry...
Quoted 35 lines · Simon Horman
per_cpu_offset()was added as part of a lockdep patch, "[PATCH] lockdep: addper_cpu_offset()" (a875a69f8b00a38b4f40d9632a4fc71a159f0e0d),
but ia64 doesn't have lockdep, nor does it useper_cpu_offset()anywhere else.This came up because Yu Lumming noticed that the ia64 version of
per_cpu_offset()actually has a syntax error. Amusing as it seems to have been in the tree for months.Review
Quoted 2 lines
(quoted diff) +1
-1-#define per_cpu_offset(x) (__per_cpu_offset(x)) +#define per_cpu_offset(x) (__per_cpu_offset[x])Dave Miller suggested that rather than fixing the unused code it would be better to just remove it all together.
Signed-off-by Simon Horman <[email protected]>include/asm-ia64/percpu.h +0
-2@@ -46,7 +46,6 @@#ifdef CONFIG_SMP extern unsigned long __per_cpu_offset[NR_CPUS ]; -#define per_cpu_offset (x) (__per_cpu_offset[x])/* Equal to __per_cpu_offset[smp_processor_id()], but faster to access: */ DECLARE_PER_CPU(unsigned long, local_per_cpu_offset); -To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines · Luming Yu
NAK for now.
I'm trying to add lockdep , so please don't delete it until it could be proved really useless...
Please don't hurry...
Ok, in that case I Re-ack your typo fix patch.
Sorry for the noise.
Signature · 3 lines
Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/