Skip to contentSkip to conversation

drivers/hwmon: remove duplicated defines

PATCH In review Nicolas Kaiser 3 participants 3 messages Nov 7, 2007 – Nov 18, 2007

Subsystems (3)
Kernel janitors Hardware monitoring W83793 hardware monitoring driver
lore
Share & tools
lore

Nicolas Kaiser

author
#0 lore raw

PATCH 1/1 drivers/hwmon: remove duplicated defines

Remove duplicated defines.

Signed-off-by Nicolas Kaiser <[email protected]>

---

 drivers/hwmon/w83793.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/hwmon/w83793.c +1 -4
@@ -131,6 +131,7 @@
 #define PWM_DUTY			0
 #define PWM_START			1
 #define PWM_NONSTOP			2
+#define PWM_STOP_TIME			3
 #define W83793_REG_PWM(index, nr)	(((nr) = 0 ? 0xb3 : \
 					 (nr) = 1 ? 0x220 : 0x218) + (index))
 

@@ -407,10 +408,6 @@
 	return count;
 }
 
-#define PWM_DUTY			0
-#define PWM_START			1
-#define PWM_NONSTOP			2
-#define PWM_STOP_TIME			3
 static ssize_t
 show_pwm(struct device *dev, struct device_attribute *attr, char *buf)
 {
Acked-by on v1 1/1
#1 lore raw

Hi Nicolas,

Quoted 1 line · Nicolas Kaiser

Remove duplicated defines.

Obviously correct, thanks.

Quoted 2 lines
Signed-off-by Nicolas Kaiser <[email protected]>
Acked-by Jean Delvare <[email protected]>
Quoted 27 lines

---

 drivers/hwmon/w83793.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/hwmon/w83793.c +1 -4
@@ -131,6 +131,7 @@
 #define PWM_DUTY			0
 #define PWM_START			1
 #define PWM_NONSTOP			2
+#define PWM_STOP_TIME			3
 #define W83793_REG_PWM(index, nr)	(((nr) = 0 ? 0xb3 : \
 					 (nr) = 1 ? 0x220 : 0x218) + (index))
 

@@ -407,10 +408,6 @@
 	return count;
 }
 
-#define PWM_DUTY			0
-#define PWM_START			1
-#define PWM_NONSTOP			2
-#define PWM_STOP_TIME			3
 static ssize_t
 show_pwm(struct device *dev, struct device_attribute *attr, char *buf)
 {
Signature · 1 line
Jean Delvare
#2 lore raw
In reply to Nicolas Kaiser
Quoted 31 lines · Jean Delvare

Hi Nicolas,

Quoted 1 line · Nicolas Kaiser

Remove duplicated defines.

Obviously correct, thanks.

Quoted 2 lines
Signed-off-by Nicolas Kaiser <[email protected]>
Acked-by Jean Delvare <[email protected]>
Quoted 19 lines

---

 drivers/hwmon/w83793.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/hwmon/w83793.c +1 -0
@@ -131,6 +131,7 @@
 #define PWM_DUTY			0
 #define PWM_START			1
 #define PWM_NONSTOP			2
+#define PWM_STOP_TIME			3
 #define W83793_REG_PWM(index, nr)	(((nr) = 0 ? 0xb3 : \
 					 (nr) = 1 ? 0x220 : 0x218) + (index))
 

@@ -407,10 +408,6 @@
 	return count;
 }
Quoted 7 lines

drivers/hwmon/w83793.c line 413

Quoted 7 lines
drivers/hwmon/w83793.c +0 -4
-#define PWM_DUTY			0
-#define PWM_START			1
-#define PWM_NONSTOP			2
-#define PWM_STOP_TIME			3
 static ssize_t
 show_pwm(struct device *dev, struct device_attribute *attr, char *buf)
 {

Applied to hwmon-2.6.git/testing, thanks.

Signature · 2 lines
Mark M. Hoffman
[email protected]