Rename "virtual ethernet device" to "virtual ethernet pair device".
Subsystems (2)
PATCH 1/1 Rename "virtual ethernet device" to "virtual ethernet pair device".
There are already iSeries and pSeries virtual ethernet drivers called veth; calling a local tunnel device "veth" is confusing.
I didn't rename the module nor the header, to avoid breaking documentation and userspace programs respectively. But I'd really like to. It'd also be nice to mention "containers" somewhere in the help text (I'm assuming that's what it's for?).
drivers/net/Kconfig +5 -4
@@ -135,11 +135,12 @@ config TUN If you don't know what to use this for, you don't need it. -config VETH - tristate "Virtual ethernet device" +config VETH_PAIR + tristate "Virtual ethernet pair device" ---help--- - The device is an ethernet tunnel. Devices are created in pairs. When - one end receives the packet it appears on its pair and vice versa. + This device is a local ethernet tunnel. Devices are created in pairs. + When one end receives the packet it appears on its pair and vice + versa. config NET_SB1000 tristate "General Instruments Surfboard 1000"
drivers/net/Makefile +1 -1
@@ -201,7 +201,7 @@ obj-$(CONFIG_MACSONIC) += macsonic.o obj-$(CONFIG_MACMACE) += macmace.o obj-$(CONFIG_MAC89x0) += mac89x0.o obj-$(CONFIG_TUN) += tun.o -obj-$(CONFIG_VETH) += veth.o +obj-$(CONFIG_VETH_PAIR) += veth.o obj-$(CONFIG_NET_NETX) += netx-eth.o obj-$(CONFIG_DL2K) += dl2k.o obj-$(CONFIG_R8169) += r8169.o
David Miller
maintainerFrom: Rusty Russell <[email protected]>
Date: Wed, 7 Nov 2007 14:09:00 +1100
Quoted 9 lines
There are already iSeries and pSeries virtual ethernet drivers called veth; calling a local tunnel device "veth" is confusing.
I didn't rename the module nor the header, to avoid breaking documentation and userspace programs respectively. But I'd really like to. It'd also be nice to mention "containers" somewhere in the help text (I'm assuming that's what it's for?).
Signed-off-by Rusty Russell <[email protected]>
We had a lengthy discussion about the name on netdev. I'm sorry that you missed it, and are bringing this back up again so that we have to discuss it once more.
If anything, the veth naming makes more sense than the IBM device cases.
And that's why I decreed that last time this came up that the naming for veth was just fine.
Quoted 5 lines · On Wednesday 07 November 2007 14:19:06 David Miller wrote:
If anything, the veth naming makes more sense than the IBM device cases.
And that's why I decreed that last time this came up that the naming for veth was just fine.
OK, about the help text. IMHO noone should be using "virtual ethernet" unqualified, since there are multiple things that now refers to.
Here's a respin with just the help text changes:
==
Clarify "virtual ethernet device" to "virtual ethernet pair device".
It'd also be nice to mention "containers" somewhere in the help text (I'm assuming that's what it's for?).
drivers/net/Kconfig +4 -3
@@ -136,10 +136,11 @@ config TUN If you don't know what to use this for, you don't need it. config VETH - tristate "Virtual ethernet device" + tristate "Virtual ethernet pair device" ---help--- - The device is an ethernet tunnel. Devices are created in pairs. When - one end receives the packet it appears on its pair and vice versa. + This device is a local ethernet tunnel. Devices are created in pairs. + When one end receives the packet it appears on its pair and vice + versa. config NET_SB1000 tristate "General Instruments Surfboard 1000"
David Miller
maintainerFrom: Rusty Russell <[email protected]>
Date: Wed, 7 Nov 2007 15:04:48 +1100
Quoted 4 lines
OK, about the help text. IMHO noone should be using "virtual ethernet" unqualified, since there are multiple things that now refers to.
Here's a respin with just the help text changes:
Fair enough, applied.