ethtool: add support for supporting 10000baseT
Subsystems (2)
PATCH 1/1 ethtool: add support for supporting 10000baseT
From: Jesse Brandeburg <[email protected]>
there is missing support in ethtool for reporting 10000baseT as SUPPORTED_10000baseT_Full. The code seems to be half implemented because the "advertising" field has the implementation.
this patch just adds it for supported reporting.
---
ethtool.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
ethtool.c +7 -0
@@ -725,6 +725,13 @@ static void dump_supported(struct ethtool_cmd *ep)if (mask & SUPPORTED_2500baseX_Full) { did1++;fprintf (stdout,"2500baseX/Full " ); } +if (did1 && (mask & SUPPORTED_10000baseT_Full)) { +fprintf (stdout,"\n" ); +fprintf (stdout," " ); + } +if (mask & SUPPORTED_10000baseT_Full) { + did1++;fprintf (stdout,"10000baseT/Full " ); + }fprintf (stdout,"\n" );fprintf (stdout," Supports auto-negotiation: " );
Quoted 5 lines · Auke Kok
From: Jesse Brandeburg <[email protected]>
there is missing support in ethtool for reporting 10000baseT as
SUPPORTED_10000baseT_Full. The code seems to be half implemented because the "advertising" field has the implementation.
I reported this lack on Sourceforge a while back:
<http://sourceforge.net/tracker/index.php?func=detail&aid=1798807&group_id=3242&atid=103242>
Is anyone reading bugs reported there?
Ben.
Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job.
Quoted 10 lines · Ben Hutchings
Quoted 5 lines · Auke Kok
From: Jesse Brandeburg <[email protected]>
there is missing support in ethtool for reporting 10000baseT as
SUPPORTED_10000baseT_Full. The code seems to be half implemented because the "advertising" field has the implementation.I reported this lack on Sourceforge a while back:
<http://sourceforge.net/tracker/index.php?func=detail&aid=1798807&group_id=3242&atid=103242>
Is anyone reading bugs reported there?
not really. However with plenty of new 10gig hardware going through here we're currently looking at ethtool support and seeing if it misses anything. If you spot issues, please Cc me or Jesse and netdev and of course Jeff Garzik so we can get some patches out.
I just noticed an e1000 specific ethtool issue on there that we'll take a look at as well.
Auke
Quoted 8 lines · Auke
Quoted 7 lines · Ben Hutchings
Quoted 5 lines · Auke Kok
From: Jesse Brandeburg <[email protected]>
there is missing support in ethtool for reporting 10000baseT as
SUPPORTED_10000baseT_Full. The code seems to be half implemented because the "advertising" field has the implementation.
Quoted 7 lines
Quoted 3 lines
I reported this lack on Sourceforge a while back:
<http://sourceforge.net/tracker/index.php?func=detail&aid=1798807&group_id=3242&atid=103242>
Is anyone reading bugs reported there?not really. However with plenty of new 10gig hardware going through here we're currently looking at ethtool support and seeing if it misses anything.
I think that's the only remaining issue we have with ethtool itself. There's a wider issue of clause 45 MDIO for 10G Ethernet though.
Ben.
Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job.
Jeff Garzik
AppliedQuoted 6 lines · Auke Kok
From: Jesse Brandeburg <[email protected]>
there is missing support in ethtool for reporting 10000baseT as
SUPPORTED_10000baseT_Full. The code seems to be half implemented because the "advertising" field has the implementation.
Quoted 8 lines
this patch just adds it for supported reporting.
Signed-off-by Jesse Brandeburg <[email protected]>Signed-off-by Auke Kok <[email protected]>---
ethtool.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
applied