Skip to contentSkip to conversation

sym53c8xx: fix free_irq() regression in 2.6.24

PATCH In review Tony Battersby 2 participants 2 messages Nov 6, 2007 – Nov 7, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sym53c8xx: fix free_irq() regression in 2.6.24

The following commit changed the pointer passed to request_irq(), but failed to change the pointer passed to free_irq():

commit 99c9e0a1d6cfe1ba1169a7a81435ee85bc00e4a1

Author: Matthew Wilcox <[email protected]>
Date:   Fri Oct 5 15:55:12 2007 -0400

[SCSI] sym53c8xx: Make interrupt handler capable of returning IRQ_NONE

...

The result is that free_irq() doesn't actually take any action. This patch fixes it.

---

drivers/scsi/sym53c8xx_2/sym_glue.c renamed from drivers/scsi/sym53c8xx_2/sym_glue.c.orig +1 -1
@@ -1243,7 +1243,7 @@ static void sym_free_resources(struct sy
 	 *  Free O/S specific resources.
 	 */
 	if (pdev->irq)
-		free_irq(pdev->irq, np);
+		free_irq(pdev->irq, np->s.host);
 	if (np->s.ioaddr)
 		pci_iounmap(pdev, np->s.ioaddr);
 	if (np->s.ramaddr)
#1 lore raw
Quoted 2 lines · Tony Battersby

The following commit changed the pointer passed to request_irq(), but failed to change the pointer passed to free_irq():

Looks good.