Fix broken inode clustering
PATCH 1/1 Fix broken inode clustering
The radix tree based inode caches did away with the inode cluster hashes, replacing them with a bunch of masking and gang lookups on the radix tree.
This masking got broken when moving the code to per-ag radix trees and indexing by agino # rather than straight inode number. The result is clustered inode writeback does not cluster and things can go extremely slowly when there are lots of inodes to write.
The following patch fixes this up by comparing agino # of the inode found to the index of the cluster we are looking for.
--- fs/xfs/xfs_iget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_iget.c +1 -1
@@ -248,7 +248,7 @@ finish_inode: icl =NULL ;if (radix_tree_gang_lookup (&pag->pag_ici_root, (void **)&iq, first_index,1 )) { -if ((iq->i_ino & mask) == first_index) +if ((XFS_INO_TO_AGINO (mp, iq->i_ino) & mask) == first_index) icl = iq->i_cluster; }
Looks good Dave.
Quoted 34 lines · David Chinner
The radix tree based inode caches did away with the inode cluster hashes, replacing them with a bunch of masking and gang lookups on the radix tree.
This masking got broken when moving the code to per-ag radix trees and indexing by agino # rather than straight inode number. The result is clustered inode writeback does not cluster and things can go extremely slowly when there are lots of inodes to write.
The following patch fixes this up by comparing agino # of the inode found to the index of the cluster we are looking for.
Signed-off-by Dave Chinner <[email protected]>Tested-by Torsten Kaiser <[email protected]>--- fs/xfs/xfs_iget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Index:
2.6.x-xfs-new/fs/xfs/xfs_iget.c
===================================================================fs/xfs/xfs_iget.c +1
-1@@ -248,7 +248,7 @@ finish_inode: icl =NULL ;if (radix_tree_gang_lookup (&pag->pag_ici_root, (void **)&iq, first_index,1 )) { -if ((iq->i_ino & mask) == first_index) +if ((XFS_INO_TO_AGINO (mp, iq->i_ino) & mask) == first_index) icl = iq->i_cluster; }