(resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.

PATCH In review Kamalesh Babulal 2 participants 3 messages Nov 10, 2007 Networking

lore

Share & tools

lore

Kamalesh Babulal

author

2007-11-10 09:42 UTC #0 lore raw

PATCH 1/1 (resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.

Hi,

The 2.6.24-rc2-git1 kernel build fails, with following error

CC security/selinux/hooks.o
In file included from include/net/tcp.h:35,
from security/selinux/hooks.c:52:
include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc' include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree' make[2]: *** [security/selinux/hooks.o] Error 1
make[1]: *** [security/selinux] Error 2
make: *** [security] Error 2

The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per bucket rwlock in tcp/dccp ehash table.) caused this build failure.

Signed-off-by Kamalesh Babulal <[email protected]>

include/net/inet_hashtables.h +1 -0

index 8461cda..469216d 100644
@@ -23,6 +23,7 @@
 #include <linux/spinlock.h>
 #include <linux/types.h>
 #include <linux/wait.h>
+#include <linux/vmalloc.h>
 
 #include <net/inet_connection_sock.h>
 #include <net/inet_sock.h>

Signature · 4 lines

Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Eric Dumazet

2007-11-10 10:28 UTC #1 lore raw

Quoted 28 lines · Kamalesh Babulal

Hi,
The 2.6.24-rc2-git1 kernel build fails, with following error
CC security/selinux/hooks.o
In file included from include/net/tcp.h:35,
from security/selinux/hooks.c:52:
include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc' include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree' make[2]: *** [security/selinux/hooks.o] Error 1
make[1]: *** [security/selinux] Error 2
make: *** [security] Error 2
The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per bucket rwlock in tcp/dccp ehash table.) caused this build failure.
Signed-off-by Kamalesh Babulal <[email protected]>
--
include/net/inet_hashtables.h +0 -0
index 8461cda..469216d 100644

include/net/inet_hashtables.h line 29

Quoted 7 lines

include/net/inet_hashtables.h +1 -0

@@ -23,6 +23,7 @@
 #include <linux/spinlock.h>
 #include <linux/types.h>
 #include <linux/wait.h>
+#include <linux/vmalloc.h>
 
 #include <net/inet_connection_sock.h>
 #include <net/inet_sock.h>

Yes, same patch was posted some hours ago, but Tony didnt acknowledged it.

http://marc.info/?l=linux-kernel&m=119465902731847&w=2

Thank you

Kamalesh Babulal

author

2007-11-10 10:51 UTC #2 lore raw

Quoted 39 lines · Eric Dumazet

Quoted 28 lines · Kamalesh Babulal
Hi,
The 2.6.24-rc2-git1 kernel build fails, with following error
CC security/selinux/hooks.o
In file included from include/net/tcp.h:35,
from security/selinux/hooks.c:52:
include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc' include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree' make[2]: *** [security/selinux/hooks.o] Error 1
make[1]: *** [security/selinux] Error 2
make: *** [security] Error 2
The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per bucket rwlock in tcp/dccp ehash table.) caused this build failure.
Signed-off-by Kamalesh Babulal <[email protected]>
--
include/net/inet_hashtables.h +0 -0
index 8461cda..469216d 100644
include/net/inet_hashtables.h line 29
Quoted 7 lines
include/net/inet_hashtables.h +1 -0
@@ -23,6 +23,7 @@
 #include <linux/spinlock.h>
 #include <linux/types.h>
 #include <linux/wait.h>
+#include <linux/vmalloc.h>
 
 #include <net/inet_connection_sock.h>
 #include <net/inet_sock.h>
Yes, same patch was posted some hours ago, but Tony didnt acknowledged it.

Quoted 4 lines

http://marc.info/?l=linux-kernel&m=119465902731847&w=2
Thank you
-

Hi Eric,

Thank you and sorry for the noise.