libata: remove unused functions
PATCH 1/1 libata: remove unused functions
This patch removes the following obsolete functions:
- libata-core.c: __sata_phy_reset()
- libata-core.c: sata_phy_reset()
- libata-eh.c: ata_qc_timeout()
- libata-eh.c: ata_eng_timeout()
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/ata/libata-core.c | 78 ------------------------------- drivers/ata/libata-eh.c | 95 -------------------------------------- include/linux/libata.h | 4 - 3 files changed, 177 deletions(-)
7e9868b7e921f3235d044c78f28da8797cc63e5a
drivers/ata/libata-core.c +0 -78
@@ -2581,81 +2581,6 @@ void sata_print_link_status(struct ata_link *link) }/** -* __sata_phy_reset - Wake/reset a low-level SATA PHY -* @ap: SATA port associated with target SATA PHY. -* -* This function issues commands to standard SATA Sxxx -* PHY registers, to wake up the phy (and device), and -* clear any reset condition. -* -* LOCKING: -* PCI/etc. bus probe sem. -* -*/ -void __sata_phy_reset (struct ata_port *ap) -{ -struct ata_link *link = &ap->link; -unsigned long timeout = jiffies + (HZ *5 ); -u32 sstatus; - -if (ap->flags &ATA_FLAG_SATA_RESET ) { -/* issue phy wake/reset */ -sata_scr_write_flush (link,SCR_CONTROL ,0x301 ); -/* Couldn't find anything in SATA I/II specs, but -* AHCI-1.1 10.4.2 says at least 1 ms. */ -mdelay (1 ); - } -/* phy wake/clear reset */ -sata_scr_write_flush (link,SCR_CONTROL ,0x300 ); - -/* wait for phy to become ready, if necessary */ -do { -msleep (200 ); -sata_scr_read (link,SCR_STATUS , &sstatus); -if ((sstatus &0xf ) !=1 ) -break ; - }while (time_before (jiffies, timeout)); - -/* print link status */ -sata_print_link_status (link); - -/* TODO: phy layer with polling, timeouts, etc. */ -if (!ata_link_offline (link)) -ata_port_probe (ap); -else -ata_port_disable (ap); - -if (ap->flags &ATA_FLAG_DISABLED ) -return ; - -if (ata_busy_sleep (ap,ATA_TMOUT_BOOT_QUICK ,ATA_TMOUT_BOOT )) { -ata_port_disable (ap); -return ; - } - - ap->cbl =ATA_CBL_SATA ; -} - -/** -* sata_phy_reset - Reset SATA bus. -* @ap: SATA port associated with target SATA PHY. -* -* This function resets the SATA bus, and then probes -* the bus for devices. -* -* LOCKING: -* PCI/etc. bus probe sem. -* -*/ -void sata_phy_reset (struct ata_port *ap) -{ -__sata_phy_reset (ap); -if (ap->flags &ATA_FLAG_DISABLED ) -return ; -ata_bus_reset (ap); -} - -/** * ata_dev_pair - return other device on cable * @adev: device *
@@ -7653,8 +7578,6 @@ EXPORT_SYMBOL_GPL(ata_dev_disable);EXPORT_SYMBOL_GPL (sata_set_spd);EXPORT_SYMBOL_GPL (sata_link_debounce);EXPORT_SYMBOL_GPL (sata_link_resume); -EXPORT_SYMBOL_GPL (sata_phy_reset); -EXPORT_SYMBOL_GPL (__sata_phy_reset);EXPORT_SYMBOL_GPL (ata_bus_reset);EXPORT_SYMBOL_GPL (ata_std_prereset);EXPORT_SYMBOL_GPL (ata_std_softreset);
@@ -7725,7 +7648,6 @@ EXPORT_SYMBOL_GPL(ata_port_desc);#ifdef CONFIG_PCI EXPORT_SYMBOL_GPL (ata_port_pbar_desc);#endif /* CONFIG_PCI */ -EXPORT_SYMBOL_GPL (ata_eng_timeout);EXPORT_SYMBOL_GPL (ata_port_schedule_eh);EXPORT_SYMBOL_GPL (ata_link_abort);EXPORT_SYMBOL_GPL (ata_port_abort);
drivers/ata/libata-eh.c +0 -95
101 lines not on this page · raw message
include/linux/libata.h +0 -4
@@ -771,8 +771,6 @@ static inline int ata_port_is_dummy(struct ata_port *ap)extern void sata_print_link_status (struct ata_link *link);extern void ata_port_probe (struct ata_port *); -extern void __sata_phy_reset (struct ata_port *ap); -extern void sata_phy_reset (struct ata_port *ap);extern void ata_bus_reset (struct ata_port *ap);extern int sata_set_spd (struct ata_link *link); extern int sata_link_debounce(struct ata_link *link,
@@ -994,8 +992,6 @@ extern void sata_pmp_do_eh(struct ata_port *ap,/* * EH */ -extern void ata_eng_timeout (struct ata_port *ap); -extern void ata_port_schedule_eh (struct ata_port *ap);extern int ata_link_abort (struct ata_link *link);extern int ata_port_abort (struct ata_port *ap);
Tejun Heo
AppliedQuoted 7 lines · Adrian Bunk
This patch removes the following obsolete functions:
-libata-core.c:__sata_phy_reset()
-libata-core.c:sata_phy_reset()
-libata-eh.c:ata_qc_timeout()
-libata-eh.c:ata_eng_timeout()Signed-off-by Adrian Bunk <[email protected]>
Queued in #tj-upstream-fixes which will be merged into 2.6.24.
Thanks.
Signature · 1 line
tejun