2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
PATCH 1/1 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
Hi Andrew,
The kernel builds fails with following error, with randconfig
CC arch/powerpc/mm/stab.oarch/powerpc/mm/stab.c: In function ‘stab_initialize’:arch/powerpc/mm/stab.c:282: error: implicit declaration of function ‘HvCall1’ arch/powerpc/mm/stab.c:282: error: ‘HvCallBaseSetASR’ undeclared (first use in this function) arch/powerpc/mm/stab.c:282: error: (Each undeclared identifier is reported only once arch/powerpc/mm/stab.c:282: error: for each function it appears in.)
make[1]: *** [arch/powerpc/mm/stab.o] Error 1
make: *** [arch/powerpc/mm] Error 2
--
arch/powerpc/mm/~stab.c renamed from arch/powerpc/mm/stab.c +4 -0
@@ -21,6 +21,10 @@#include <asm/abs_addr.h> #include <asm/firmware.h> +#ifdef CONFIG_PPC_ISERIES +#include <asm/iseries/hv_call.h> +#endif /* CONFIG_PPC_ISERIES */ +struct stab_entry {unsigned long esid_data;unsigned long vsid_data;
Signature · 4 lines
Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.
Hi Kamalesh,
arch/powerpc/mm/~stab.c line 26
Quoted 4 lines · On Wed, 14 Nov 2007 16:24:10 +0530 Kamalesh Babulal…
arch/powerpc/mm/~stab.c renamed from arch/powerpc/mm/stab.c +3
-0+#ifdef CONFIG_PPC_ISERIES +#include <asm/iseries/hv_call.h> +#endif /* CONFIG_PPC_ISERIES */
You should not need the #ifdef and we prefer not to ifdef include unless necessary. Please resubmit.
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Hi Stephen,
Resubmitting the patch titled powerpc-iseries-build-failure-mm-stabc.patch in the -mm tree.
--
arch/powerpc/mm/~stab.c renamed from arch/powerpc/mm/stab.c +1 -0
@@ -20,6 +20,7 @@#include <asm/lmb.h> #include <asm/abs_addr.h> #include <asm/firmware.h> +#include <asm/iseries/hv_call.h> struct stab_entry {unsigned long esid_data;
Signature · 4 lines
Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.
PATCH 1/1 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
From: Kamalesh Babulal <[email protected]>
The kernel builds fails with following error, with randconfig
CC arch/powerpc/mm/stab.oarch/powerpc/mm/stab.c: In function ‘stab_initialize’:arch/powerpc/mm/stab.c:282: error: implicit declaration of function ‘HvCall1’ arch/powerpc/mm/stab.c:282: error: ‘HvCallBaseSetASR’ undeclared (first use in this function) arch/powerpc/mm/stab.c:282: error: (Each undeclared identifier is reported only once arch/powerpc/mm/stab.c:282: error: for each function it appears in.)
make[1]: *** [arch/powerpc/mm/stab.o] Error 1
make: *** [arch/powerpc/mm] Error 2
--- arch/powerpc/mm/stab.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 3 lines · On Mon, 19 Nov 2007 11:56:11 +0530 Kamalesh Babulal…
Resubmitting the patch titled powerpc-iseries-build-failure-mm-stabc.patch in the -mm tree.
Paulus, this should be fine for merging like above.
Cheers,
Stephen Rothwell [email protected]
arch/powerpc/mm/stab.c +1 -0
@@ -20,6 +20,7 @@#include <asm/lmb.h> #include <asm/abs_addr.h> #include <asm/firmware.h> +#include <asm/iseries/hv_call.h> struct stab_entry {unsigned long esid_data;
Signature · 1 line
1.5.3.5