Skip to contentSkip to conversation

ide: fix serverworks.c UDMA regression

PATCH Applied Tony Battersby 3 participants 5 messages Oct 15, 2007 – Nov 14, 2007 libata

lore
Share & tools
lore

Tony Battersby

author
#0 lore raw

PATCH 1/1 ide: fix serverworks.c UDMA regression

The patch described by the following excerpt from ChangeLog-2.6.22 makes it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):

commit 2d5eaa6dd744a641e75503232a01f52d0768884c

Author: Bartlomiej Zolnierkiewicz <[email protected]>
Date:   Thu May 10 00:01:08 2007 +0200

ide: rework the code for selecting the best DMA transfer mode (v3)

...

This one-line patch against 2.6.23 fixes the problem.

Signed-off-by Tony Battersby <[email protected]>

---

drivers/ide/pci/serverworks.c renamed from drivers/ide/pci/serverworks.c.orig +1 -0
@@ -97,6 +97,7 @@ static u8 svwks_udma_filter(ide_drive_t 
 			mode = 2;
 
 		switch(mode) {
+		case 3:	 mask = 0x3f; break;
 		case 2:	 mask = 0x1f; break;
 		case 1:	 mask = 0x07; break;
 		default: mask = 0x00; break;
Applied
#1 lore raw
Quoted 4 lines · Tony Battersby

The patch described by the following excerpt from ChangeLog-2.6.22 makes it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):

commit 2d5eaa6dd744a641e75503232a01f52d0768884c

Quoted 8 lines
Author: Bartlomiej Zolnierkiewicz <[email protected]>
Date:   Thu May 10 00:01:08 2007 +0200

ide: rework the code for selecting the best DMA transfer mode (v3)

...

This one-line patch against 2.6.23 fixes the problem.

Thanks!! (and sorry for the bug)

Quoted 1 line
Signed-off-by Tony Battersby <[email protected]>

applied

Greg/Chris: this is a perfect candidate for 2.6.23.2

Quoted 11 lines

---

drivers/ide/pci/serverworks.c renamed from drivers/ide/pci/serverworks.c.orig +1 -0
@@ -97,6 +97,7 @@ static u8 svwks_udma_filter(ide_drive_t 
 			mode = 2;
 
 		switch(mode) {
+		case 3:	 mask = 0x3f; break;
 		case 2:	 mask = 0x1f; break;
 		case 1:	 mask = 0x07; break;
 		default: mask = 0x00; break;
#2 lore raw
Quoted 14 lines · Bartlomiej Zolnierkiewicz
Quoted 4 lines · Tony Battersby

The patch described by the following excerpt from ChangeLog-2.6.22 makes it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):

commit 2d5eaa6dd744a641e75503232a01f52d0768884c

Quoted 8 lines
Author: Bartlomiej Zolnierkiewicz <[email protected]>
Date:   Thu May 10 00:01:08 2007 +0200

ide: rework the code for selecting the best DMA transfer mode (v3)

...

This one-line patch against 2.6.23 fixes the problem.

Quoted 7 lines

Thanks!! (and sorry for the bug)

Quoted 1 line
Signed-off-by Tony Battersby <[email protected]>

applied

Greg/Chris: this is a perfect candidate for 2.6.23.2

Thanks, got it now.

greg k-h

author
#3 lore raw
Quoted 22 lines · Greg KH
Quoted 20 lines · Bartlomiej Zolnierkiewicz
Quoted 4 lines · Tony Battersby

The patch described by the following excerpt from ChangeLog-2.6.22 makes it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):

commit 2d5eaa6dd744a641e75503232a01f52d0768884c

Quoted 9 lines
Author: Bartlomiej Zolnierkiewicz <[email protected]>
Date:   Thu May 10 00:01:08 2007 +0200

ide: rework the code for selecting the best DMA transfer mode (v3)

...

This one-line patch against 2.6.23 fixes the problem.

Thanks!! (and sorry for the bug)

Quoted 2 lines
Signed-off-by Tony Battersby <[email protected]>
Quoted 10 lines
Quoted 4 lines

applied

Greg/Chris: this is a perfect candidate for 2.6.23.2

Thanks, got it now.

greg k-h

Also applies to 2.6.22, if you are still maintaining that stable branch.

Thanks,
Tony

#4 lore raw
Quoted 28 lines · Tony Battersby
Quoted 27 lines · Greg KH
Quoted 24 lines · Bartlomiej Zolnierkiewicz
Quoted 4 lines · Tony Battersby

The patch described by the following excerpt from ChangeLog-2.6.22 makes it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):

commit 2d5eaa6dd744a641e75503232a01f52d0768884c

Quoted 9 lines
Author: Bartlomiej Zolnierkiewicz <[email protected]>
Date:   Thu May 10 00:01:08 2007 +0200

ide: rework the code for selecting the best DMA transfer mode (v3)

...

This one-line patch against 2.6.23 fixes the problem.

Thanks!! (and sorry for the bug)

Quoted 2 lines
Signed-off-by Tony Battersby <[email protected]>

applied

Greg/Chris: this is a perfect candidate for 2.6.23.2

Quoted 7 lines
Quoted 5 lines

Thanks, got it now.

greg k-h

Also applies to 2.6.22, if you are still maintaining that stable branch.

Thanks, yes, I am, in fact it's already in my todo-22 directory which I'll get to after cleaning out this HUGE backlog of .23 patches that I've been slack on attending to :(

thanks,

greg k-h