Skip to contentSkip to conversation

chelsio - Fix skb->dev setting

PATCH In review Divy Le Ray 2 participants 2 messages Nov 15, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Divy Le Ray

author
#0 lore raw

PATCH 1/1 chelsio - Fix skb->dev setting

From: Divy Le Ray <[email protected]>

eth_type_trans() now sets skb->dev.
Access skb->def after it gets set.

Signed-off-by Divy Le Ray <[email protected]>

---

 drivers/net/chelsio/sge.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/chelsio/sge.c +1 -1
index ffa7e64..4436662 100644
@@ -1379,11 +1379,11 @@ static void sge_rx(struct sge *sge, struct freelQ *fl, unsigned int len)
 	}
 	__skb_pull(skb, sizeof(*p));
 
-	skb->dev->last_rx = jiffies;
 	st = per_cpu_ptr(sge->port_stats[p->iff], smp_processor_id());
 	st->rx_packets++;
 
 	skb->protocol = eth_type_trans(skb, adapter->port[p->iff].dev);
+	skb->dev->last_rx = jiffies;
 	if ((adapter->flags & RX_CSUM_ENABLED) && p->csum == 0xffff &&
 	    skb->protocol == htons(ETH_P_IP) &&
 	    (skb->data[9] == IPPROTO_TCP || skb->data[9] == IPPROTO_UDP)) {