User Mode Linux still broken in 2.6.23.1

Rob Landley

author

2007-11-04 04:52 UTC #0 lore raw

Building with the attached .config on x86-64, it does this:

CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of function ‘release_pages’ include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of function ‘page_cache_release’ make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2

I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?

From: Rob Landley <[email protected]>

Fix build break in User Mode Linux 2.6.23.1.

Signed-off-by Rob Landley <[email protected]>

---

 arch/um/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)

arch/um/kernel/smp.c +1 -0

@@ -5,6 +5,7 @@
 
 #include "linux/percpu.h"
 #include "asm/pgalloc.h"
+#include "linux/pagemap.h"
 #include "asm/tlb.h"
 
 /* For some reason, mmu_gathers are referenced when CONFIG_SMP is off. */

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.23.1
# Sat Nov 3 20:20:52 2007
#
CONFIG_DEFCONFIG_LIST="arch/$ARCH/defconfig"
CONFIG_GENERIC_HARDIRQS=y
CONFIG_UML=y
CONFIG_MMU=y
CONFIG_NO_IOMEM=y
# CONFIG_TRACE_IRQFLAGS_SUPPORT is not set
CONFIG_LOCKDEP_SUPPORT=y
# CONFIG_STACKTRACE_SUPPORT is not set
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_GENERIC_BUG=y
CONFIG_IRQ_RELEASE_METHOD=y

#
# UML-specific options
#
# CONFIG_STATIC_LINK is not set
CONFIG_MODE_SKAS=y
CONFIG_UML_X86=y
CONFIG_64BIT=y
CONFIG_RWSEM_GENERIC_SPINLOCK=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_TOP_ADDR=0x80000000
CONFIG_3_LEVEL_PGTABLES=y
CONFIG_STUB_CODE=0x7fbfffe000
CONFIG_STUB_DATA=0x7fbffff000
CONFIG_STUB_START=0x7fbfffe000
# CONFIG_ARCH_HAS_SC_SIGNALS is not set
# CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA is not set
CONFIG_SMP_BROKEN=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
# CONFIG_SPARSEMEM_STATIC is not set
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_RESOURCES_64BIT=y
CONFIG_ZONE_DMA_FLAG=0
CONFIG_VIRT_TO_BUS=y
CONFIG_LD_SCRIPT_DYN=y
# CONFIG_NET is not set
CONFIG_BINFMT_ELF=y
# CONFIG_BINFMT_MISC is not set
CONFIG_HOSTFS=y
# CONFIG_MCONSOLE is not set
CONFIG_NEST_LEVEL=0
CONFIG_KERNEL_STACK_ORDER=1
# CONFIG_UML_REAL_TIME_CLOCK is not set

#
# General setup
#
# CONFIG_EXPERIMENTAL is not set
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=128
CONFIG_LOCALVERSION=""
# CONFIG_LOCALVERSION_AUTO is not set
# CONFIG_SWAP is not set
# CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_IKCONFIG is not set
CONFIG_LOG_BUF_SHIFT=14
# CONFIG_SYSFS_DEPRECATED is not set
# CONFIG_RELAY is not set
# CONFIG_BLK_DEV_INITRD is not set
CONFIG_SYSCTL=y
# CONFIG_EMBEDDED is not set
CONFIG_UID16=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_EXTRA_PASS is not set
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_ANON_INODES=y
CONFIG_EPOLL=y
CONFIG_SIGNALFD=y
CONFIG_EVENTFD=y
CONFIG_SHMEM=y
CONFIG_VM_EVENT_COUNTERS=y
CONFIG_SLUB_DEBUG=y
# CONFIG_SLAB is not set
CONFIG_SLUB=y
# CONFIG_SLOB is not set
CONFIG_RT_MUTEXES=y
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0
# CONFIG_MODULES is not set
CONFIG_BLOCK=y
# CONFIG_BLK_DEV_IO_TRACE is not set

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
# CONFIG_IOSCHED_AS is not set
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
# CONFIG_DEFAULT_AS is not set
# CONFIG_DEFAULT_DEADLINE is not set
# CONFIG_DEFAULT_CFQ is not set
CONFIG_DEFAULT_NOOP=y
CONFIG_DEFAULT_IOSCHED="noop"
CONFIG_BLK_DEV=y
# CONFIG_BLK_DEV_UBD is not set
# CONFIG_BLK_DEV_COW_COMMON is not set
# CONFIG_MMAPPER is not set
CONFIG_BLK_DEV_LOOP=y
# CONFIG_BLK_DEV_CRYPTOLOOP is not set
# CONFIG_BLK_DEV_RAM is not set

#
# Character Devices
#
CONFIG_STDERR_CONSOLE=y
CONFIG_STDIO_CONSOLE=y
# CONFIG_SSL is not set
# CONFIG_NULL_CHAN is not set
# CONFIG_PORT_CHAN is not set
# CONFIG_PTY_CHAN is not set
# CONFIG_TTY_CHAN is not set
# CONFIG_XTERM_CHAN is not set
CONFIG_NOCONFIG_CHAN=y
CONFIG_CON_ZERO_CHAN="fd:0,fd:1"
CONFIG_CON_CHAN="xterm"
CONFIG_SSL_CHAN="pty"
CONFIG_UNIX98_PTYS=y
# CONFIG_LEGACY_PTYS is not set
# CONFIG_RAW_DRIVER is not set
# CONFIG_WATCHDOG is not set
# CONFIG_UML_SOUND is not set
# CONFIG_SOUND is not set
# CONFIG_HOSTAUDIO is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_UML_RANDOM is not set

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
# CONFIG_PREVENT_FIRMWARE_BUILD is not set
# CONFIG_FW_LOADER is not set
# CONFIG_SYS_HYPERVISOR is not set

#
# Networking
#

#
# File systems
#
CONFIG_EXT2_FS=y
# CONFIG_EXT2_FS_XATTR is not set
# CONFIG_EXT2_FS_XIP is not set
# CONFIG_EXT3_FS is not set
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
# CONFIG_FS_POSIX_ACL is not set
# CONFIG_XFS_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_INOTIFY is not set
# CONFIG_QUOTA is not set
CONFIG_DNOTIFY=y
# CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set
# CONFIG_FUSE_FS is not set

#
# CD-ROM/DVD Filesystems
#
# CONFIG_ISO9660_FS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
# CONFIG_MSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
# CONFIG_PROC_KCORE is not set
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y
# CONFIG_TMPFS is not set
# CONFIG_HUGETLB_PAGE is not set
CONFIG_RAMFS=y

#
# Miscellaneous filesystems
#
# CONFIG_HFSPLUS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y

#
# Native Language Support
#
# CONFIG_NLS is not set

#
# Security options
#
# CONFIG_KEYS is not set
# CONFIG_SECURITY is not set
# CONFIG_CRYPTO is not set

#
# Library routines
#
# CONFIG_CRC_CCITT is not set
# CONFIG_CRC16 is not set
# CONFIG_CRC_ITU_T is not set
# CONFIG_CRC32 is not set
# CONFIG_CRC7 is not set
# CONFIG_LIBCRC32C is not set
CONFIG_PLIST=y
CONFIG_HAS_DMA=y

#
# SCSI device support
#
# CONFIG_RAID_ATTRS is not set
# CONFIG_SCSI is not set
# CONFIG_SCSI_DMA is not set
# CONFIG_SCSI_NETLINK is not set
# CONFIG_MD is not set
# CONFIG_INPUT is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set
# CONFIG_ENABLE_MUST_CHECK is not set
# CONFIG_UNUSED_SYMBOLS is not set
# CONFIG_DEBUG_FS is not set
# CONFIG_DEBUG_KERNEL is not set
# CONFIG_SLUB_DEBUG_ON is not set
CONFIG_DEBUG_BUGVERBOSE=y
# CONFIG_DEBUG_STACK_USAGE is not set

Greg KH

2007-11-14 19:02 UTC #1 lore raw

Quoted 13 lines · Rob Landley

Building with the attached .config on x86-64, it does this:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2

Quoted 4 lines

I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?

I think the patches that I have just added to the stable queue for 2.6.23.2 will fix this. If not, please let me know after testing.

thanks,

greg k-h

Rob Landley

author

2007-11-15 05:58 UTC #2 lore raw

Quoted 15 lines · On Wednesday 14 November 2007 12:54:44 Greg KH wrote:

Quoted 14 lines · Rob Landley
Building with the attached .config on x86-64, it does this:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2

Quoted 7 lines

Quoted 4 lines
I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?
I think the patches that I have just added to the stable queue for 2.6.23.2 will fix this. If not, please let me know after testing.

Where do I find these patches to test? I know where to find the stable releases, but not the "stable queue".

Documentation/stable_kernel_rules.txt just says there _is_ a stable queue, not where to access it. Google's first hit for "linux stable queue" was
http://git.kernel.org/?p=linux/kernel/git/chrisw/stable-queue.git;a=shortlog
which apparently stopped updating in march...

Happy to test the patch you mentioned, if I can figure out where to find it...

Thanks,

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

Greg KH

2007-11-15 06:03 UTC #3 lore raw

Quoted 27 lines · Rob Landley

Quoted 15 lines · On Wednesday 14 November 2007 12:54:44 Greg KH wrote:
Quoted 14 lines · Rob Landley
Building with the attached .config on x86-64, it does this:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
Quoted 7 lines
Quoted 4 lines
I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?
I think the patches that I have just added to the stable queue for 2.6.23.2 will fix this. If not, please let me know after testing.
Where do I find these patches to test? I know where to find the stable releases, but not the "stable queue".

Quoted 6 lines

Documentation/stable_kernel_rules.txt just says there _is_ a stable queue, not where to access it. Google's first hit for "linux stable queue" was
http://git.kernel.org/?p=linux/kernel/git/chrisw/stable-queue.git;a=shortlog
which apparently stopped updating in march...
Happy to test the patch you mentioned, if I can figure out where to find it...

It's at:
http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Chris and I used to have separate queues, but that got messy, I suppose we should just delete those old copies...

thanks,

greg k-h

Rob Landley

author

2007-11-15 20:57 UTC #4 lore raw

Quoted 37 lines · On Thursday 15 November 2007 00:02:55 Greg KH wrote:

Quoted 27 lines · Rob Landley
Quoted 15 lines · On Wednesday 14 November 2007 12:54:44 Greg KH wrote:
Quoted 14 lines · Rob Landley
Building with the attached .config on x86-64, it does this:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o] Error 1 make: *** [arch/um/kernel] Error 2
Quoted 7 lines
Quoted 4 lines
I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at
http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?
I think the patches that I have just added to the stable queue for 2.6.23.2 will fix this. If not, please let me know after testing.
Where do I find these patches to test? I know where to find the stable releases, but not the "stable queue".
Quoted 8 lines
Documentation/stable_kernel_rules.txt just says there _is_ a stable queue, not where to access it. Google's first hit for "linux stable queue" was
http://git.kernel.org/?p=linux/kernel/git/chrisw/stable-queue.git;a=short
log which apparently stopped updating in march...
Happy to test the patch you mentioned, if I can figure out where to find it...

Quoted 6 lines

It's at:
http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=summar
y
Chris and I used to have separate queues, but that got messy, I suppose we should just delete those old copies...

In a freshly extracted 2.6.23 tarball, I applied the 4 uml-*.patch files from stable-queue/review-2.6.23-2 in sequence (all applied cleanly), and then did the following:

cat > mini.conf << EOF && CONFIG_BINFMT_ELF=y
CONFIG_HOSTFS=y
CONFIG_LBD=y
CONFIG_BLK_DEV=y
CONFIG_BLK_DEV_LOOP=y CONFIG_STDERR_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_EXT2_FS=y
EOF
make ARCH=um allnoconfig KCONFIG_ALLCONFIG=mini.conf

Then I did:

make -j 2 ARCH=um

And it still breaks:

CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of function ‘page_cache_release’
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
make: *** Waiting for unfinished jobs....

My .config is attached.

Quoted 3 lines

thanks,
greg k-h

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.23
# Thu Nov 15 14:53:40 2007
#
CONFIG_DEFCONFIG_LIST="arch/$ARCH/defconfig"
CONFIG_GENERIC_HARDIRQS=y
CONFIG_UML=y
CONFIG_MMU=y
CONFIG_NO_IOMEM=y
# CONFIG_TRACE_IRQFLAGS_SUPPORT is not set
CONFIG_LOCKDEP_SUPPORT=y
# CONFIG_STACKTRACE_SUPPORT is not set
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_GENERIC_BUG=y
CONFIG_IRQ_RELEASE_METHOD=y

#
# UML-specific options
#
# CONFIG_STATIC_LINK is not set
CONFIG_MODE_SKAS=y
CONFIG_UML_X86=y
CONFIG_64BIT=y
CONFIG_RWSEM_GENERIC_SPINLOCK=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_TOP_ADDR=0x80000000
CONFIG_3_LEVEL_PGTABLES=y
CONFIG_STUB_CODE=0x7fbfffe000
CONFIG_STUB_DATA=0x7fbffff000
CONFIG_STUB_START=0x7fbfffe000
# CONFIG_ARCH_HAS_SC_SIGNALS is not set
# CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA is not set
CONFIG_SMP_BROKEN=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
# CONFIG_SPARSEMEM_STATIC is not set
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_RESOURCES_64BIT=y
CONFIG_ZONE_DMA_FLAG=0
CONFIG_VIRT_TO_BUS=y
CONFIG_LD_SCRIPT_DYN=y
# CONFIG_NET is not set
CONFIG_BINFMT_ELF=y
# CONFIG_BINFMT_MISC is not set
CONFIG_HOSTFS=y
# CONFIG_MCONSOLE is not set
CONFIG_NEST_LEVEL=0
CONFIG_KERNEL_STACK_ORDER=1
# CONFIG_UML_REAL_TIME_CLOCK is not set

#
# General setup
#
# CONFIG_EXPERIMENTAL is not set
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=128
CONFIG_LOCALVERSION=""
# CONFIG_LOCALVERSION_AUTO is not set
# CONFIG_SWAP is not set
# CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_IKCONFIG is not set
CONFIG_LOG_BUF_SHIFT=14
# CONFIG_SYSFS_DEPRECATED is not set
# CONFIG_RELAY is not set
# CONFIG_BLK_DEV_INITRD is not set
CONFIG_SYSCTL=y
# CONFIG_EMBEDDED is not set
CONFIG_UID16=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_EXTRA_PASS is not set
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_ANON_INODES=y
CONFIG_EPOLL=y
CONFIG_SIGNALFD=y
CONFIG_EVENTFD=y
CONFIG_SHMEM=y
CONFIG_VM_EVENT_COUNTERS=y
CONFIG_SLUB_DEBUG=y
# CONFIG_SLAB is not set
CONFIG_SLUB=y
# CONFIG_SLOB is not set
CONFIG_RT_MUTEXES=y
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0
# CONFIG_MODULES is not set
CONFIG_BLOCK=y
# CONFIG_BLK_DEV_IO_TRACE is not set

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
# CONFIG_IOSCHED_AS is not set
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
# CONFIG_DEFAULT_AS is not set
# CONFIG_DEFAULT_DEADLINE is not set
# CONFIG_DEFAULT_CFQ is not set
CONFIG_DEFAULT_NOOP=y
CONFIG_DEFAULT_IOSCHED="noop"
CONFIG_BLK_DEV=y
# CONFIG_BLK_DEV_UBD is not set
# CONFIG_BLK_DEV_COW_COMMON is not set
# CONFIG_MMAPPER is not set
CONFIG_BLK_DEV_LOOP=y
# CONFIG_BLK_DEV_CRYPTOLOOP is not set
# CONFIG_BLK_DEV_RAM is not set

#
# Character Devices
#
CONFIG_STDERR_CONSOLE=y
CONFIG_STDIO_CONSOLE=y
# CONFIG_SSL is not set
# CONFIG_NULL_CHAN is not set
# CONFIG_PORT_CHAN is not set
# CONFIG_PTY_CHAN is not set
# CONFIG_TTY_CHAN is not set
# CONFIG_XTERM_CHAN is not set
CONFIG_NOCONFIG_CHAN=y
CONFIG_CON_ZERO_CHAN="fd:0,fd:1"
CONFIG_CON_CHAN="xterm"
CONFIG_SSL_CHAN="pty"
CONFIG_UNIX98_PTYS=y
# CONFIG_LEGACY_PTYS is not set
# CONFIG_RAW_DRIVER is not set
# CONFIG_WATCHDOG is not set
# CONFIG_UML_SOUND is not set
# CONFIG_SOUND is not set
# CONFIG_HOSTAUDIO is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_UML_RANDOM is not set

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
# CONFIG_PREVENT_FIRMWARE_BUILD is not set
# CONFIG_FW_LOADER is not set
# CONFIG_SYS_HYPERVISOR is not set

#
# Networking
#

#
# File systems
#
CONFIG_EXT2_FS=y
# CONFIG_EXT2_FS_XATTR is not set
# CONFIG_EXT2_FS_XIP is not set
# CONFIG_EXT3_FS is not set
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
# CONFIG_FS_POSIX_ACL is not set
# CONFIG_XFS_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_INOTIFY is not set
# CONFIG_QUOTA is not set
CONFIG_DNOTIFY=y
# CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set
# CONFIG_FUSE_FS is not set

#
# CD-ROM/DVD Filesystems
#
# CONFIG_ISO9660_FS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
# CONFIG_MSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
# CONFIG_PROC_KCORE is not set
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y
# CONFIG_TMPFS is not set
# CONFIG_HUGETLB_PAGE is not set
CONFIG_RAMFS=y

#
# Miscellaneous filesystems
#
# CONFIG_HFSPLUS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y

#
# Native Language Support
#
# CONFIG_NLS is not set

#
# Security options
#
# CONFIG_KEYS is not set
# CONFIG_SECURITY is not set
# CONFIG_CRYPTO is not set

#
# Library routines
#
# CONFIG_CRC_CCITT is not set
# CONFIG_CRC16 is not set
# CONFIG_CRC_ITU_T is not set
# CONFIG_CRC32 is not set
# CONFIG_CRC7 is not set
# CONFIG_LIBCRC32C is not set
CONFIG_PLIST=y
CONFIG_HAS_DMA=y

#
# SCSI device support
#
# CONFIG_RAID_ATTRS is not set
# CONFIG_SCSI is not set
# CONFIG_SCSI_DMA is not set
# CONFIG_SCSI_NETLINK is not set
# CONFIG_MD is not set
# CONFIG_INPUT is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set
# CONFIG_ENABLE_MUST_CHECK is not set
# CONFIG_UNUSED_SYMBOLS is not set
# CONFIG_DEBUG_FS is not set
# CONFIG_DEBUG_KERNEL is not set
# CONFIG_SLUB_DEBUG_ON is not set
CONFIG_DEBUG_BUGVERBOSE=y
# CONFIG_DEBUG_STACK_USAGE is not set

Greg KH

2007-11-15 21:10 UTC #5 lore raw

Quoted 81 lines · Rob Landley

Quoted 37 lines · On Thursday 15 November 2007 00:02:55 Greg KH wrote:
Quoted 27 lines · Rob Landley
Quoted 15 lines · On Wednesday 14 November 2007 12:54:44 Greg KH wrote:
Quoted 14 lines · Rob Landley
Building with the attached .config on x86-64, it does this:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o] Error 1 make: *** [arch/um/kernel] Error 2
Quoted 7 lines
Quoted 4 lines
I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at
http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?
I think the patches that I have just added to the stable queue for 2.6.23.2 will fix this. If not, please let me know after testing.
Where do I find these patches to test? I know where to find the stable releases, but not the "stable queue".
Quoted 8 lines
Documentation/stable_kernel_rules.txt just says there _is_ a stable queue, not where to access it. Google's first hit for "linux stable queue" was
http://git.kernel.org/?p=linux/kernel/git/chrisw/stable-queue.git;a=short
log which apparently stopped updating in march...
Happy to test the patch you mentioned, if I can figure out where to find it...
Quoted 6 lines
It's at:
http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=summar
y
Chris and I used to have separate queues, but that got messy, I suppose we should just delete those old copies...
In a freshly extracted 2.6.23 tarball, I applied the 4 uml-*.patch files from stable-queue/review-2.6.23-2 in sequence (all applied cleanly), and then did the following:
cat > mini.conf << EOF && CONFIG_BINFMT_ELF=y
CONFIG_HOSTFS=y
CONFIG_LBD=y
CONFIG_BLK_DEV=y
CONFIG_BLK_DEV_LOOP=y CONFIG_STDERR_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_EXT2_FS=y
EOF
make ARCH=um allnoconfig KCONFIG_ALLCONFIG=mini.conf
Then I did:
make -j 2 ARCH=um
And it still breaks:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release???
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
make: *** Waiting for unfinished jobs....

Quoted 1 line

My .config is attached.

Hm, not good. I'll let Jeff handle this :)

thanks,

greg k-h

WANG Cong

2007-11-16 03:11 UTC #6 lore raw

PATCH 1/1 Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 82 lines · Greg KH

Quoted 81 lines · Rob Landley
Quoted 37 lines · On Thursday 15 November 2007 00:02:55 Greg KH wrote:
Quoted 27 lines · Rob Landley
Quoted 15 lines · On Wednesday 14 November 2007 12:54:44 Greg KH wrote:
Quoted 14 lines · Rob Landley
Building with the attached .config on x86-64, it does this:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o] Error 1 make: *** [arch/um/kernel] Error 2
Quoted 7 lines
Quoted 4 lines
I've been doing the following to fix it. I know it's not the right fix, (see the earlier thread about it at
http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?
I think the patches that I have just added to the stable queue for 2.6.23.2 will fix this. If not, please let me know after testing.
Where do I find these patches to test? I know where to find the stable releases, but not the "stable queue".
Quoted 8 lines
Documentation/stable_kernel_rules.txt just says there _is_ a stable queue, not where to access it. Google's first hit for "linux stable queue" was
http://git.kernel.org/?p=linux/kernel/git/chrisw/stable-queue.git;a=short
log which apparently stopped updating in march...
Happy to test the patch you mentioned, if I can figure out where to find it...
Quoted 6 lines
It's at:
http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=summar
y
Chris and I used to have separate queues, but that got messy, I suppose we should just delete those old copies...
In a freshly extracted 2.6.23 tarball, I applied the 4 uml-*.patch files from stable-queue/review-2.6.23-2 in sequence (all applied cleanly), and then did the following:
cat > mini.conf << EOF && CONFIG_BINFMT_ELF=y
CONFIG_HOSTFS=y
CONFIG_LBD=y
CONFIG_BLK_DEV=y
CONFIG_BLK_DEV_LOOP=y CONFIG_STDERR_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_EXT2_FS=y
EOF
make ARCH=um allnoconfig KCONFIG_ALLCONFIG=mini.conf
Then I did:
make -j 2 ARCH=um
And it still breaks:
CC arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
include/asm-generic/tlb.h:76: error: implicit declaration of function ???release_pages??? include/asm-generic/tlb.h: In function ???tlb_remove_page???:
include/asm-generic/tlb.h:105: error: implicit declaration of function ???page_cache_release???
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
make: *** Waiting for unfinished jobs....

Quoted 3 lines

Quoted 1 line
My .config is attached.
Hm, not good. I'll let Jeff handle this :)

Could you please try this patch? Can it fix the error?

Signed-off-by WANG Cong <[email protected]>

---

Makefile +0 -0

include/linux/swap.h +1 -0

index 4f3838a..2c3ce4c 100644
@@ -6,6 +6,7 @@
 #include <linux/mmzone.h>
 #include <linux/list.h>
 #include <linux/sched.h>
+#include <linux/pagemap.h>
 
 #include <asm/atomic.h>
 #include <asm/page.h>

Rob Landley

author

2007-11-16 05:01 UTC #7 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 6 lines · On Thursday 15 November 2007 21:08:32 WANG Cong wrote:

Quoted 1 line · Greg KH
Hm, not good. I'll let Jeff handle this :)
Could you please try this patch? Can it fix the error?
Signed-off-by WANG Cong <[email protected]>

Oh what a good idea.

Signed-off-by Rob Landley <[email protected]>

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

Greg KH

2007-11-16 07:24 UTC #8 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 11 lines · Rob Landley

Quoted 6 lines · On Thursday 15 November 2007 21:08:32 WANG Cong wrote:
Quoted 1 line · Greg KH
Hm, not good. I'll let Jeff handle this :)
Could you please try this patch? Can it fix the error?
Signed-off-by WANG Cong <[email protected]>
Oh what a good idea.
Signed-off-by Rob Landley <[email protected]>

Heh, we came full circle here, this was Rob's original patch :)

Rob, I'll queue this up for the next cycle, now that you've verified that it was not fixed already, thanks for testing.

greg k-h

Jeff Dike

2007-11-16 15:51 UTC #9 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 2 lines · Greg KH

Rob, I'll queue this up for the next cycle, now that you've verified that it was not fixed already, thanks for testing.

I wouldn't.

sparc includes swap.h in its pgtable.h. Adding pagemap.h to swap.h completes an include loop on sparc which blows up its build.

I have a set of patches to fix this in a different way, which I sent out for comments a few weeks ago. They
add uaccess.h to various futexes.h because these will start
failing to build when the next patch is applied
break the recursion by removing highmem.h from pagemap.h,
which needs nothing related to highmem, and sprinkle includes of highmem.h in all the files which formerly got it through pagemap.h
now, pagemap.h can be added to swap.h without blowing up sparc also, the other arches can include swap.h in their pgtables.h,
which they probably should since they define operations on swp_entry_t, which is defined in swap.h.

Jeff

Signature · 1 line

Work email - jdike at linux dot intel dot com

Greg KH

2007-11-16 16:57 UTC #10 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 8 lines · Jeff Dike

Quoted 2 lines · Greg KH
Rob, I'll queue this up for the next cycle, now that you've verified that it was not fixed already, thanks for testing.
I wouldn't.
sparc includes swap.h in its pgtable.h. Adding pagemap.h to swap.h completes an include loop on sparc which blows up its build.

Ok, nevermind, I'll drop it from my to-add queue :)

thanks for letting me know.

greg k-h

Rob Landley

author

2007-11-16 22:00 UTC #11 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

In reply to Jeff Dike

Quoted 11 lines · On Friday 16 November 2007 09:51:08 Jeff Dike wrote:

Quoted 2 lines · Greg KH
Rob, I'll queue this up for the next cycle, now that you've verified that it was not fixed already, thanks for testing.
I wouldn't.
sparc includes swap.h in its pgtable.h. Adding pagemap.h to swap.h completes an include loop on sparc which blows up its build.
I have a set of patches to fix this in a different way, which I sent out for comments a few weeks ago.

I wasn't cc'd, and missed it. I'd like to test this, do you have a link? (Or a bit more specificity than "a few weeks ago"?)

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

Jeff Dike

2007-11-17 18:54 UTC #12 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 2 lines · Rob Landley

I wasn't cc'd, and missed it. I'd like to test this, do you have a link? (Or a bit more specificity than "a few weeks ago"?)

Here are the three patches:

	http://marc.info/?l=linux-arch&m=119342916329510&w=2
	http://marc.info/?l=linux-kernel&m=119342916529516&w=2
	http://marc.info/?l=linux-kernel&m=119342708426910&w=2

				Jeff

Signature · 1 line

Work email - jdike at linux dot intel dot com

Rob Landley

author

2007-11-18 20:18 UTC #13 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 7 lines · On Saturday 17 November 2007 12:53:57 Jeff Dike wrote:

Quoted 2 lines · Rob Landley
I wasn't cc'd, and missed it. I'd like to test this, do you have a link? (Or a bit more specificity than "a few weeks ago"?)
Here are the three patches:
	http://marc.info/?l=linux-arch&m=119342916329510&w=2

Doesn't contain a patch.

Quoted 1 line

	http://marc.info/?l=linux-kernel&m=119342916529516&w=2

Doesn't apply to vanilla 2.6.23, it can't find two files and a couple other hunks failed.

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

Sam Ravnborg

2007-11-18 21:30 UTC #14 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 10 lines · Rob Landley

Quoted 7 lines · On Saturday 17 November 2007 12:53:57 Jeff Dike wrote:
Quoted 2 lines · Rob Landley
I wasn't cc'd, and missed it. I'd like to test this, do you have a link? (Or a bit more specificity than "a few weeks ago"?)
Here are the three patches:
	http://marc.info/?l=linux-arch&m=119342916329510&w=2
Doesn't contain a patch.

Took me one minute to locate PATCH 1 + 2:
http://marc.info/?l=linux-arch&m=119342916429513&w=2
http://marc.info/?l=linux-arch&m=119342916229500&w=2

Maybe this helps you.

Sam

Rob Landley

author

2007-11-19 07:15 UTC #15 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 10 lines · On Sunday 18 November 2007 15:32:03 Sam Ravnborg wrote:

Quoted 9 lines · Rob Landley
Quoted 7 lines · On Saturday 17 November 2007 12:53:57 Jeff Dike wrote:
Quoted 2 lines · Rob Landley
I wasn't cc'd, and missed it. I'd like to test this, do you have a link? (Or a bit more specificity than "a few weeks ago"?)
Here are the three patches:
	http://marc.info/?l=linux-arch&m=119342916329510&w=2

Quoted 7 lines

Quoted 1 line
Doesn't contain a patch.
Took me one minute to locate PATCH 1 + 2:
http://marc.info/?l=linux-arch&m=119342916429513&w=2
http://marc.info/?l=linux-arch&m=119342916229500&w=2
Maybe this helps you.

Same problem as previous message: they don't apply to 2.6.23. (I tried both 2.6.23 and 2.6.23.8, just to be sure.)

I don't suppose putting #ifndef guards around whatever sparc.h file hasn't got them is a reasonable hack to get this worked around during 2.6.23.x?

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

Rob Landley

author

2007-11-16 18:00 UTC #16 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

In reply to Greg KH

Quoted 7 lines · On Friday 16 November 2007 01:15:27 Greg KH wrote:

Quoted 6 lines · Rob Landley
Quoted 5 lines · On Thursday 15 November 2007 21:08:32 WANG Cong wrote:
Quoted 1 line · Greg KH
Hm, not good. I'll let Jeff handle this :)
Could you please try this patch? Can it fix the error?

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
Signed-off-by WANG Cong <[email protected]>
Oh what a good idea.
Signed-off-by Rob Landley <[email protected]>
Heh, we came full circle here, this was Rob's original patch :)

/me pleads the fifth.

(I'm all for a better fix in .24, but for .23.x this is a one-liner...)

Quoted 2 lines

Rob, I'll queue this up for the next cycle, now that you've verified that it was not fixed already, thanks for testing.

Thanks for fixing it.

Quoted 1 line

greg k-h

Rob

Signature · 2 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

Jeff Dike

2007-11-16 15:14 UTC #17 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

In reply to WANG Cong

Quoted 12 lines · WANG Cong

Could you please try this patch? Can it fix the error?
Signed-off-by WANG Cong <[email protected]>
---
Makefile +0 -0
include/linux/swap.h +0 -0
index 4f3838a..2c3ce4c 100644

include/linux/swap.h line 12

Quoted 7 lines

include/linux/swap.h +1 -0

@@ -6,6 +6,7 @@
 #include <linux/mmzone.h>
 #include <linux/list.h>
 #include <linux/sched.h>
+#include <linux/pagemap.h>
 
 #include <asm/atomic.h>
 #include <asm/page.h>

If you look further down the file, you see a comment to the effect that this will break sparc.

Jeff

Signature · 1 line

Work email - jdike at linux dot intel dot com

WANG Cong

2007-11-16 15:28 UTC #18 lore raw

Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

Quoted 18 lines · Jeff Dike

Quoted 17 lines · WANG Cong
Could you please try this patch? Can it fix the error?
Signed-off-by WANG Cong <[email protected]>
---
Makefile +0 -0
include/linux/swap.h +1 -0
index 4f3838a..2c3ce4c 100644
@@ -6,6 +6,7 @@
 #include <linux/mmzone.h>
 #include <linux/list.h>
 #include <linux/sched.h>
+#include <linux/pagemap.h>
 

Quoted 6 lines

include/linux/swap.h line 12
Quoted 2 lines
include/linux/swap.h +0 -0
 #include <asm/atomic.h>
 #include <asm/page.h>
If you look further down the file, you see a comment to the effect that this will break sparc.

Sorry, I didn't know that. ;(