ioemu: build fix

PATCH In review Christoph Egger 2 participants 6 messages Nov 15, 2007 – Nov 22, 2007

lore

Share & tools

lore

Christoph Egger

author

2007-11-15 14:00 UTC #0 lore raw

PATCH 1/1 ioemu: build fix

Hi!

Attached patch fixes the following linking error which I am seeing on BSD:

ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to _oss_ioctl' ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more undefined references to _oss_ioctl' follow

Signed-off-by Christoph Egger <[email protected]>

Signature · 12 lines

AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

tools/ioemu/Makefile.target +1 -0

diff -r ba69fe2dce91 tools/ioemu/Makefile.target
@@ -365,6 +365,7 @@ endif
 endif
 ifdef CONFIG_OSS
 AUDIODRV += ossaudio.o
+LIBS += -lossaudio
 endif
 ifdef CONFIG_COREAUDIO
 AUDIODRV += coreaudio.o

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Keir Fraser

2007-11-16 16:41 UTC #1 lore raw

That doesn't work so well on non-bsd, where libossaudio appears not to exist. Does upstream qemu have a solution for this we could pull down?

-- Keir

Quoted 21 lines · Christoph Egger

Hi!
Attached patch fixes the following linking error which I am seeing on BSD:
ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to _oss_ioctl' ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more undefined references to _oss_ioctl' follow
Signed-off-by Christoph Egger <[email protected]>

Christoph Egger

author

2007-11-16 17:22 UTC #2 lore raw

Quoted 2 lines · On Friday 16 November 2007 17:41:20 Keir Fraser wrote:

That doesn't work so well on non-bsd, where libossaudio appears not to exist. Does upstream qemu have a solution for this we could pull down?

I don't know. I haven't looked at it. I noticed this dependency on my BSD machine, where I don't have SDL installed. On the BSD machine where I have SDL installed, SDL is linked against ossaudio and therefore inherited _oss_ioctl and I didn't notice this dependency earlier.

Quoted 28 lines

-- Keir
Quoted 19 lines · Christoph Egger
Hi!
Attached patch fixes the following linking error which I am seeing on BSD:
ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to _oss_ioctl' ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more undefined references to _oss_ioctl' follow
Quoted 1 line
Signed-off-by Christoph Egger <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Signature · 12 lines

AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

Keir Fraser

2007-11-16 17:49 UTC #3 lore raw

It seems that libossaudio is a bsd-specific ossaudio compat library. Either you need to make extra -lossaudio specific to *bsd, or you need to auto-detect presence of the library (somehow). Or maybe both.

-- Keir

Quoted 39 lines · Christoph Egger

Quoted 2 lines · On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
That doesn't work so well on non-bsd, where libossaudio appears not to exist. Does upstream qemu have a solution for this we could pull down?
I don't know. I haven't looked at it. I noticed this dependency on my BSD machine, where I don't have SDL installed. On the BSD machine where I have SDL installed, SDL is linked against ossaudio and therefore inherited _oss_ioctl and I didn't notice this dependency earlier.
Quoted 28 lines
-- Keir
Quoted 19 lines · Christoph Egger
Hi!
Attached patch fixes the following linking error which I am seeing on BSD:
ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to _oss_ioctl' ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more undefined references to _oss_ioctl' follow
Quoted 1 line
Signed-off-by Christoph Egger <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Christoph Egger

author

2007-11-22 10:38 UTC #4 lore raw

Revision 1.217 in qemu looks promising, though I haven't tested it:
http://cvs.savannah.nongnu.org/viewvc/qemu/Makefile.target?root=qemu&r1=1.216&r2=1.217

Christoph

Quoted 44 lines · On Friday 16 November 2007 18:49:11 Keir Fraser wrote:

It seems that libossaudio is a bsd-specific ossaudio compat library. Either you need to make extra -lossaudio specific to *bsd, or you need to auto-detect presence of the library (somehow). Or maybe both.
-- Keir
Quoted 37 lines · Christoph Egger
Quoted 2 lines · On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
That doesn't work so well on non-bsd, where libossaudio appears not to exist. Does upstream qemu have a solution for this we could pull down?
I don't know. I haven't looked at it. I noticed this dependency on my BSD machine, where I don't have SDL installed. On the BSD machine where I have SDL installed, SDL is linked against ossaudio and therefore inherited _oss_ioctl and I didn't notice this dependency earlier.
Quoted 28 lines
-- Keir
Quoted 19 lines · Christoph Egger
Hi!
Attached patch fixes the following linking error which I am seeing on BSD:
ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to _oss_ioctl' ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more undefined references to _oss_ioctl' follow
Quoted 1 line
Signed-off-by Christoph Egger <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Signature · 12 lines

AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

Keir Fraser

2007-11-22 10:43 UTC #5 lore raw

Doesn't look to me like it addresses this issue.

-- Keir

Quoted 54 lines · Christoph Egger

Revision 1.217 in qemu looks promising, though I haven't tested it:
http://cvs.savannah.nongnu.org/viewvc/qemu/Makefile.target?root=qemu&r1=1.216&
r2=1.217
Christoph
Quoted 44 lines · On Friday 16 November 2007 18:49:11 Keir Fraser wrote:
It seems that libossaudio is a bsd-specific ossaudio compat library. Either you need to make extra -lossaudio specific to *bsd, or you need to auto-detect presence of the library (somehow). Or maybe both.
-- Keir
Quoted 37 lines · Christoph Egger
Quoted 2 lines · On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
That doesn't work so well on non-bsd, where libossaudio appears not to exist. Does upstream qemu have a solution for this we could pull down?
I don't know. I haven't looked at it. I noticed this dependency on my BSD machine, where I don't have SDL installed. On the BSD machine where I have SDL installed, SDL is linked against ossaudio and therefore inherited _oss_ioctl and I didn't notice this dependency earlier.
Quoted 28 lines
-- Keir
Quoted 19 lines · Christoph Egger
Hi!
Attached patch fixes the following linking error which I am seeing on BSD:
ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to _oss_ioctl' /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to _oss_ioctl' ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more undefined references to _oss_ioctl' follow
Quoted 1 line
Signed-off-by Christoph Egger <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel