cxgb3 - Fix resources release.

PATCH In review Divy Le Ray 1 participant 1 message Nov 16, 2007

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Divy Le Ray

author

2007-11-16 19:21 UTC #0 lore raw

PATCH 3/9 cxgb3 - Fix resources release.

From: Divy Le Ray <[email protected]>

Remove sysfs entries before unregistering the net devices.

Signed-off-by Divy Le Ray <[email protected]>

---

 drivers/net/cxgb3/cxgb3_main.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

drivers/net/cxgb3/cxgb3_main.c +4 -4

index d92da8f..9d14652 100644
@@ -2585,10 +2585,6 @@ static void __devexit remove_one(struct pci_dev *pdev)
 		sysfs_remove_group(&adapter->port[0]->dev.kobj,
 				   &cxgb3_attr_group);
 
-		for_each_port(adapter, i)
-		    if (test_bit(i, &adapter->registered_device_map))
-			unregister_netdev(adapter->port[i]);
-
 		if (is_offload(adapter)) {
 			cxgb3_adapter_unofld(adapter);
 			if (test_bit(OFFLOAD_DEVMAP_BIT,

@@ -2596,6 +2592,10 @@ static void __devexit remove_one(struct pci_dev *pdev)
 				offload_close(&adapter->tdev);
 		}
 
+		for_each_port(adapter, i)
+		    if (test_bit(i, &adapter->registered_device_map))
+			unregister_netdev(adapter->port[i]);
+
 		t3_free_sge_resources(adapter);
 		cxgb_disable_msi(adapter);