Skip to contentSkip to conversation

mac80211: add power management support -v2

PATCH In review Miguel Botón 2 participants 3 messages Nov 16, 2007 – Nov 30, 2007 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mac80211: add power management support -v2

This patch adds power management support in mac80211.

This allows us to enable power management through the "iwconfig <device=

Quoted 1 line

power=20

<off/on>" command.
The code is based on "mac80211-10.0.0" but it is a little bit modified.

include/net/mac80211.h +2 -0
index 5fcc4c1..c82b6fa 100644
@@ -452,6 +452,8 @@ struct ieee80211_conf {
 	u8 antenna_max;
 	u8 antenna_sel_tx;
 	u8 antenna_sel_rx;
+
+	u8 power_management_enable;     /* flag to enable/disable power manag=

ement=20
*/
};
=20
/**

net/mac80211/ieee80211_io= renamed from net/mac80211/ieee80211_ioctl.c +0 -0

ctl.c
index 6caa3ec..f5eebec 100644

net/mac80211/ieee80211_ioctl.c +0 -0
@@ -674,6 +687,46 @@ static int ieee80211_ioctl_giwtxpower(struct net_d=

evice=20
*dev,
return 0;
}
=20
+static int ieee80211_ioctl_siwpower(struct net_device *dev,

+				    struct iw_request_info *info,
+				    union iwreq_data *wrqu,
+				    char *extra)

+{
+ struct ieee80211_local *local =3D wdev_priv(dev->ieee80211_ptr);
+ struct ieee80211_conf *conf =3D &local->hw.conf;
+
+ if (wrqu->power.disabled) {
+ conf->power_management_enable =3D 0;
+ return ieee80211_hw_config(local);
+ }
+
+ switch (wrqu->power.flags & IW_POWER_MODE) {

+	case IW_POWER_ON:       /* If not specified */
+	case IW_POWER_MODE:     /* If set all mask */
+	case IW_POWER_ALL_R:    /* If explicitely state all */

+ break;
+ default: /* Otherwise we don't support it */
+ return -EINVAL;
+ }
+
+ conf->power_management_enable =3D 1;
+
+ return ieee80211_hw_config(local);
+}
+
+static int ieee80211_ioctl_giwpower(struct net_device *dev,

+				    struct iw_request_info *info,
+				    union iwreq_data *wrqu,
+				    char *extra)

+{
+ struct ieee80211_local *local =3D wdev_priv(dev->ieee80211_ptr);
+ struct ieee80211_conf *conf =3D &local->hw.conf;
+
+ wrqu->power.disabled =3D !conf->power_management_enable;
+
+ return 0;
+}
+
static int ieee80211_ioctl_siwrts(struct net_device *dev,
struct iw_request_info *info, struct iw_param *rts, char *extra)
@@ -1111,8 +1166,8 @@ static const iw_handler ieee80211_handler[] =3D
(iw_handler) ieee80211_ioctl_giwretry, /* SIOCGIWRETRY */
(iw_handler) ieee80211_ioctl_siwencode, /* SIOCSIWENCODE */
(iw_handler) ieee80211_ioctl_giwencode, /* SIOCGIWENCODE */
- (iw_handler) NULL, /* SIOCSIWPOWER */
- (iw_handler) NULL, /* SIOCGIWPOWER */
+ (iw_handler) ieee80211_ioctl_siwpower, /* SIOCSIWPOWER */
+ (iw_handler) ieee80211_ioctl_giwpower, /* SIOCGIWPOWER */
(iw_handler) NULL, /* -- hole -- */
(iw_handler) NULL, /* -- hole -- */
(iw_handler) ieee80211_ioctl_siwgenie, /* SIOCSIWGENIE */

--=20
Miguel Bot=C3=B3n
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw

Well, the previous patch wasn't correct. This one is valid.

--

This patch adds power management support in mac80211.

This allows us to enable power management through the "iwconfig <device=

Quoted 1 line

power <off/on>" command.

The code is based on "mac80211-10.0.0" but it is a little bit modified.

include/net/mac80211.h +2 -0
index 5fcc4c1..c82b6fa 100644
@@ -452,6 +452,8 @@ struct ieee80211_conf {
 	u8 antenna_max;
 	u8 antenna_sel_tx;
 	u8 antenna_sel_rx;
+
+	u8 power_management_enable;     /* flag to enable/disable power manag=

ement */
};
=20
/**

net/mac80211/ieee80211_io= renamed from net/mac80211/ieee80211_ioctl.c +0 -0

ctl.c
index 6caa3ec..f5eebec 100644

net/mac80211/ieee80211_ioctl.c +0 -0
@@ -674,6 +687,51 @@ static int ieee80211_ioctl_giwtxpower(struct net_d=

evice *dev,
return 0;
}
=20
+static int ieee80211_ioctl_siwpower(struct net_device *dev,

+				    struct iw_request_info *info,
+				    union iwreq_data *wrqu,
+				    char *extra)

+{
+ struct ieee80211_local *local =3D wdev_priv(dev->ieee80211_ptr);
+ struct ieee80211_conf *conf =3D &local->hw.conf;
+
+ if (wrqu->power.disabled) {
+ conf->power_management_enable =3D 0;
+ if (ieee80211_hw_config(local))
+ return -EINVAL;
+ return 0;
+ }
+
+ switch (wrqu->power.flags & IW_POWER_MODE) {

+	case IW_POWER_ON:       /* If not specified */
+	case IW_POWER_MODE:     /* If set all mask */
+	case IW_POWER_ALL_R:    /* If explicitely state all */

+ break;
+ default: /* Otherwise we don't support it */
+ return -EINVAL;
+ }
+
+ conf->power_management_enable =3D 1;
+
+ if (ieee80211_hw_config(local))
+ return -EINVAL;
+
+ return 0;
+}
+
+static int ieee80211_ioctl_giwpower(struct net_device *dev,

+				    struct iw_request_info *info,
+				    union iwreq_data *wrqu,
+				    char *extra)

+{
+ struct ieee80211_local *local =3D wdev_priv(dev->ieee80211_ptr);
+ struct ieee80211_conf *conf =3D &local->hw.conf;
+
+ wrqu->power.disabled =3D !conf->power_management_enable;
+
+ return 0;
+}
+
static int ieee80211_ioctl_siwrts(struct net_device *dev,
struct iw_request_info *info, struct iw_param *rts, char *extra)
@@ -1111,8 +1166,8 @@ static const iw_handler ieee80211_handler[] =3D
(iw_handler) ieee80211_ioctl_giwretry, /* SIOCGIWRETRY */
(iw_handler) ieee80211_ioctl_siwencode, /* SIOCSIWENCODE */
(iw_handler) ieee80211_ioctl_giwencode, /* SIOCGIWENCODE */
- (iw_handler) NULL, /* SIOCSIWPOWER */
- (iw_handler) NULL, /* SIOCGIWPOWER */
+ (iw_handler) ieee80211_ioctl_siwpower, /* SIOCSIWPOWER */
+ (iw_handler) ieee80211_ioctl_giwpower, /* SIOCGIWPOWER */
(iw_handler) NULL, /* -- hole -- */
(iw_handler) NULL, /* -- hole -- */
(iw_handler) ieee80211_ioctl_siwgenie, /* SIOCSIWGENIE */

--=20
Miguel Bot=C3=B3n
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 3 lines · On Sat, Nov 17, 2007 at 01:13:58AM +0100, Miguel Bot=F3n wrote:

This patch adds power management support in mac80211.
=20
This allows us to enable power management through the "iwconfig <devi=

ce> power <off/on>" command.

Quoted 1 line

The code is based on "mac80211-10.0.0" but it is a little bit modifie=

d.

include/net/mac80211.h struct ieee80211_conf { · line 456

Quoted 13 lines

=20

=20

include/net/mac80211.h +2 -0
index 5fcc4c1..c82b6fa 100644
@@ -452,6 +452,8 @@ struct ieee80211_conf {
 	u8 antenna_max;
 	u8 antenna_sel_tx;
 	u8 antenna_sel_rx;
+
+	u8 power_management_enable;     /* flag to enable/disable power man=

agement */

Quoted 3 lines
include/net/mac80211.h +0 -0
 };

=20
/**

I'm not overly happy with this. What about folding this into the flags variable?

John
--=20
John W. Linville
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html