fs: use list_for_each_entry_reverse and kill sb_entry

PATCH New Akinobu Mita 1 participant 1 message Nov 17, 2007 VFS

lore

Share & tools

lore

Akinobu Mita

author

2007-11-17 14:39 UTC #0 lore raw

PATCH 1/1 fs: use list_for_each_entry_reverse and kill sb_entry

Use list_for_each_entry_reverse for super_blocks list and remove unused sb_entry macro.

Signed-off-by Akinobu Mita <[email protected]>

---
 fs/fs-writeback.c  |    7 ++-----
 include/linux/fs.h |    1 -
 2 files changed, 2 insertions(+), 6 deletions(-)

fs/fs-writeback.c +2 -5

Index: 2.6-mm/fs/fs-writeback.c
===================================================================
@@ -528,8 +528,7 @@ int writeback_inodes(struct writeback_co
 	might_sleep();
 	spin_lock(&sb_lock);
 restart:
-	sb = sb_entry(super_blocks.prev);
-	for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {
+	list_for_each_entry_reverse(sb, &super_blocks, s_list) {
 		if (sb_has_dirty_inodes(sb)) {
 			/* we're making our own get_super here */
 			sb->s_count++;

@@ -593,10 +592,8 @@ static void set_sb_syncing(int val)
 {
 	struct super_block *sb;
 	spin_lock(&sb_lock);
-	sb = sb_entry(super_blocks.prev);
-	for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {
+	list_for_each_entry_reverse(sb, &super_blocks, s_list)
 		sb->s_syncing = val;
-	}
 	spin_unlock(&sb_lock);
 }

include/linux/fs.h +0 -1

Index: 2.6-mm/include/linux/fs.h
===================================================================
@@ -984,7 +984,6 @@ extern int send_sigurg(struct fown_struc
 extern struct list_head super_blocks;
 extern spinlock_t sb_lock;
 
-#define sb_entry(list)	list_entry((list), struct super_block, s_list)
 #define S_BIAS (1<<30)
 struct super_block {
 	struct list_head	s_list;		/* Keep this first */