Skip to contentSkip to conversation

pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

PATCH In review Ben Dooks 2 participants 3 messages Nov 19, 2007

Subsystems (2)
Arm (32-bit) libata
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example of using this new configuration.

Signed-off-by Ben Dooks <[email protected]>
drivers/ata/Kconfig +1 -1
diff -urpN -X linux-2.6.24-rc3-pata1/Documentation/dontdiff linux-2.6.24-rc3-pata1/drivers/ata/Kconfig linux-2.6.24-rc3-pata2/drivers/ata/Kconfig
@@ -570,7 +570,7 @@ config MACH_HAS_PATA_PLATFORM
 
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || MACH_HAS_PATA_PLATFORM
+	depends on EMBEDDED || MACH_HAS_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
arch/arm/Kconfig +1 -0
diff -urpN -X linux-2.6.24-rc3-pata1/Documentation/dontdiff linux-2.6.24-rc3-pata1/arch/arm/Kconfig linux-2.6.24-rc3-pata2/arch/arm/Kconfig
@@ -353,6 +353,7 @@ config ARCH_RPC
 	select ARCH_MAY_HAVE_PC_FDC
 	select ISA_DMA_API
 	select NO_IOPORT
+	select MACH_HAS_PATA_PLATFORM
 	help
 	  On the Acorn Risc-PC, Linux can support the internal IDE disk and
 	  CD-ROM interface, serial and parallel port, and the floppy drive.
#1 lore raw
Quoted 2 lines · Ben Dooks

Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example of using this new configuration.

I thought that it had been agreed (on linux-arch) that the name of these options shall be HAVE_foo to enable a driver configuration symbol of foo.

IOW, this should be HAVE_PATA_PLATFORM not MACH_HAS_PATA_PLATFORM.

(Not sure who introduced MACH_HAS_xxx but added Sam and Mathieu since they were involved in the discussion over HAVE_xxx.)

author
#2 lore raw
Quoted 9 lines · Russell King - ARM Linux
Quoted 2 lines · Ben Dooks

Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example of using this new configuration.

I thought that it had been agreed (on linux-arch) that the name of these options shall be HAVE_foo to enable a driver configuration symbol of foo.

IOW, this should be HAVE_PATA_PLATFORM not MACH_HAS_PATA_PLATFORM.

Ok, HAVE_PATA_PLATFORM should be unique enough without adding anything like HAVE_DRIVER_PATA_PLATFORM. If no-one else objects, I will submit a new version of these two patches.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.