Skip to contentSkip to conversation

SPARC64: check for possible NULL pointer dereference

PATCH Applied Cyrill Gorcunov 2 participants 2 messages Nov 20, 2007 – Nov 21, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SPARC64: check for possible NULL pointer dereference

From: Cyrill Gorcunov <[email protected]>

This patch adds checking for possible NULL pointer dereference if of_find_property() failed.

---
I'm not sure about the message being printed in worst case. Check please.

 arch/sparc64/kernel/pci_sun4v.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/sparc64/kernel/pci_sun4v.c +4 -0
index 8c4875b..e587a37 100644
@@ -1022,6 +1022,10 @@ void __init sun4v_pci_init(struct device_node *dp, char *model_name)
 	}
 
 	prop = of_find_property(dp, "reg", NULL);
+	if (!prop) {
+		prom_printf("SUN4V_PCI: Could not find config registers\n");
+		prom_halt();
+	}
 	regs = prop->value;
 
 	devhandle = (regs->phys_addr >> 32UL) & 0x0fffffff;